From: Dominik Vogt <vogt@linux.vnet.ibm.com>
To: gcc-patches@gcc.gnu.org
Cc: David Malcolm <dmalcolm@redhat.com>,
Andreas Krebbel <krebbel@linux.vnet.ibm.com>
Subject: Re: [PATCH] PR other/69006: S/390: Fix extra newlines after diagnostics.
Date: Fri, 29 Jan 2016 08:56:00 -0000 [thread overview]
Message-ID: <20160129085603.GB3844@linux.vnet.ibm.com> (raw)
In-Reply-To: <1453904539.7283.12.camel@redhat.com>
On Wed, Jan 27, 2016 at 09:22:19AM -0500, David Malcolm wrote:
> On Wed, 2016-01-27 at 12:01 +0100, Dominik Vogt wrote:
> > The attached patch removes a blank line after an error message.
> > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69006
>
> Presumably this was exposed by the stricter testing I added to lib/gcc
> -dg.exp in r232837?
Yes, of course.
> > - error_at (loc, "ambiguous overload for intrinsic: %s\n",
> > + error_at (loc, "ambiguous overload for intrinsic: %s",
> > IDENTIFIER_POINTER (DECL_NAME (ob_fndecl)));
> Should this code be using %qs rather than %s? (or somesuch, or is that
> a gcc 7 thing)
Yes, probably. I'll make a separate patch for this.
Ciao
Dominik ^_^ ^_^
--
Dominik Vogt
IBM Germany
next prev parent reply other threads:[~2016-01-29 8:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 11:01 Dominik Vogt
2016-01-27 14:24 ` David Malcolm
2016-01-29 8:56 ` Dominik Vogt [this message]
2016-01-29 10:13 ` Andreas Krebbel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160129085603.GB3844@linux.vnet.ibm.com \
--to=vogt@linux.vnet.ibm.com \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=krebbel@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).