From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34715 invoked by alias); 29 Jan 2016 08:56:13 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 34703 invoked by uid 89); 29 Jan 2016 08:56:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=Hx-languages-length:803, dgexp, UD:dg.exp, dg.exp X-HELO: e06smtp07.uk.ibm.com Received: from e06smtp07.uk.ibm.com (HELO e06smtp07.uk.ibm.com) (195.75.94.103) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Fri, 29 Jan 2016 08:56:11 +0000 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 29 Jan 2016 08:56:07 -0000 Received: from d06dlp03.portsmouth.uk.ibm.com (9.149.20.15) by e06smtp07.uk.ibm.com (192.168.101.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 29 Jan 2016 08:56:06 -0000 X-IBM-Helo: d06dlp03.portsmouth.uk.ibm.com X-IBM-MailFrom: vogt@linux.vnet.ibm.com X-IBM-RcptTo: gcc-patches@gcc.gnu.org Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 739BA1B08072 for ; Fri, 29 Jan 2016 08:56:14 +0000 (GMT) Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u0T8u5qG11993540 for ; Fri, 29 Jan 2016 08:56:05 GMT Received: from d06av02.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u0T8u5ek005971 for ; Fri, 29 Jan 2016 01:56:05 -0700 Received: from bl3ahm9f.de.ibm.com (sig-9-83-128-183.evts.uk.ibm.com [9.83.128.183]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u0T8u5L8005965; Fri, 29 Jan 2016 01:56:05 -0700 Received: from dvogt by bl3ahm9f.de.ibm.com with local (Exim 4.76) (envelope-from ) id 1aP4qZ-0002CZ-Q7; Fri, 29 Jan 2016 09:56:03 +0100 Date: Fri, 29 Jan 2016 08:56:00 -0000 From: Dominik Vogt To: gcc-patches@gcc.gnu.org Cc: David Malcolm , Andreas Krebbel Subject: Re: [PATCH] PR other/69006: S/390: Fix extra newlines after diagnostics. Message-ID: <20160129085603.GB3844@linux.vnet.ibm.com> Reply-To: vogt@linux.vnet.ibm.com Mail-Followup-To: vogt@linux.vnet.ibm.com, gcc-patches@gcc.gnu.org, David Malcolm , Andreas Krebbel References: <20160127110126.GA7243@linux.vnet.ibm.com> <1453904539.7283.12.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453904539.7283.12.camel@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16012908-0029-0000-0000-000005A12C13 X-SW-Source: 2016-01/txt/msg02282.txt.bz2 On Wed, Jan 27, 2016 at 09:22:19AM -0500, David Malcolm wrote: > On Wed, 2016-01-27 at 12:01 +0100, Dominik Vogt wrote: > > The attached patch removes a blank line after an error message. > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69006 > > Presumably this was exposed by the stricter testing I added to lib/gcc > -dg.exp in r232837? Yes, of course. > > - error_at (loc, "ambiguous overload for intrinsic: %s\n", > > + error_at (loc, "ambiguous overload for intrinsic: %s", > > IDENTIFIER_POINTER (DECL_NAME (ob_fndecl))); > Should this code be using %qs rather than %s? (or somesuch, or is that > a gcc 7 thing) Yes, probably. I'll make a separate patch for this. Ciao Dominik ^_^ ^_^ -- Dominik Vogt IBM Germany