From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53376 invoked by alias); 29 Jan 2016 09:06:58 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 53365 invoked by uid 89); 29 Jan 2016 09:06:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=ob_fndecl, s390cc, Format, UD:s390-c.c X-HELO: e06smtp16.uk.ibm.com Received: from e06smtp16.uk.ibm.com (HELO e06smtp16.uk.ibm.com) (195.75.94.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Fri, 29 Jan 2016 09:06:57 +0000 Received: from localhost by e06smtp16.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 29 Jan 2016 09:06:53 -0000 Received: from d06dlp02.portsmouth.uk.ibm.com (9.149.20.14) by e06smtp16.uk.ibm.com (192.168.101.146) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 29 Jan 2016 09:06:50 -0000 X-IBM-Helo: d06dlp02.portsmouth.uk.ibm.com X-IBM-MailFrom: vogt@linux.vnet.ibm.com X-IBM-RcptTo: gcc-patches@gcc.gnu.org Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 94F3A2190046 for ; Fri, 29 Jan 2016 09:06:37 +0000 (GMT) Received: from d06av08.portsmouth.uk.ibm.com (d06av08.portsmouth.uk.ibm.com [9.149.37.249]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u0T96oMG9175446 for ; Fri, 29 Jan 2016 09:06:50 GMT Received: from d06av08.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u0T96oZ7031815 for ; Fri, 29 Jan 2016 02:06:50 -0700 Received: from bl3ahm9f.de.ibm.com (sig-9-83-128-183.evts.uk.ibm.com [9.83.128.183]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u0T96nkp031786; Fri, 29 Jan 2016 02:06:49 -0700 Received: from dvogt by bl3ahm9f.de.ibm.com with local (Exim 4.76) (envelope-from ) id 1aP50y-0002dF-1o; Fri, 29 Jan 2016 10:06:48 +0100 Date: Fri, 29 Jan 2016 09:06:00 -0000 From: Dominik Vogt To: gcc-patches@gcc.gnu.org Cc: Andreas Krebbel Subject: [PATCH] S/390: Use %qs in error messages. Message-ID: <20160129090647.GA9025@linux.vnet.ibm.com> Reply-To: vogt@linux.vnet.ibm.com Mail-Followup-To: vogt@linux.vnet.ibm.com, gcc-patches@gcc.gnu.org, Andreas Krebbel MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="W/nzBZO5zC0uMSeA" Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16012909-0025-0000-0000-000008C45AAE X-SW-Source: 2016-01/txt/msg02283.txt.bz2 --W/nzBZO5zC0uMSeA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 271 The attached patch replaces %qs instead of %s in an error message, adds %qs to another and fixes indentation in one of the messages. Compiled and checked that no tests rely on the changed error messages on a zEC12. Ciao Dominik ^_^ ^_^ -- Dominik Vogt IBM Germany --W/nzBZO5zC0uMSeA Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename=0001-ChangeLog Content-length: 169 gcc/ChangeLog * config/s390/s390-c.c (s390_resolve_overloaded_builtin): Format declaration name with %qs and print it in both error messages. Also fix indentation. --W/nzBZO5zC0uMSeA Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-S-390-Use-qs-in-error-messages.patch" Content-length: 1111 >From 2455f3dd89b84e9e93ca30d0d52733f1f05a1802 Mon Sep 17 00:00:00 2001 From: Dominik Vogt Date: Fri, 29 Jan 2016 09:58:55 +0100 Subject: [PATCH] S/390: Use %qs in error messages. --- gcc/config/s390/s390-c.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/gcc/config/s390/s390-c.c b/gcc/config/s390/s390-c.c index 2b6e405..cd3584b 100644 --- a/gcc/config/s390/s390-c.c +++ b/gcc/config/s390/s390-c.c @@ -904,13 +904,14 @@ s390_resolve_overloaded_builtin (location_t loc, if (last_match_type == INT_MAX) { - error_at (loc, "invalid parameter combination for intrinsic"); + error_at (loc, "invalid parameter combination for intrinsic %qs", + IDENTIFIER_POINTER (DECL_NAME (ob_fndecl))); return error_mark_node; } else if (num_matches > 1) { - error_at (loc, "ambiguous overload for intrinsic: %s", - IDENTIFIER_POINTER (DECL_NAME (ob_fndecl))); + error_at (loc, "ambiguous overload for intrinsic %qs", + IDENTIFIER_POINTER (DECL_NAME (ob_fndecl))); return error_mark_node; } -- 2.3.0 --W/nzBZO5zC0uMSeA--