[PATCH] PR other/69006: S/390: Fix extra newlines after diagnostics.

[PATCH] PR other/69006: S/390: Fix extra newlines after diagnostics.

[Dominik Vogt]

[-- Attachment #1: Type: text/plain, Size: 170 bytes --]

The attached patch removes a blank line after an error message.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69006

Ciao

Dominik ^_^  ^_^

-- 

Dominik Vogt
IBM Germany

[-- Attachment #2: 0001-ChangeLog --]
[-- Type: text/plain, Size: 138 bytes --]

gcc/ChangeLog

	PR other/69006
	* config/s390/s390-c.c (s390_resolve_overloaded_builtin): Remove
	trailing blank line from error message.

[-- Attachment #3: 0001-PR-other-69006-S-390-Fix-extra-newlines-after-diagno.patch --]
[-- Type: text/x-diff, Size: 815 bytes --]

From ae4938b344821b3f6d244ec7fc5f9703599d3d55 Mon Sep 17 00:00:00 2001
From: Dominik Vogt <vogt@linux.vnet.ibm.com>
Date: Wed, 27 Jan 2016 11:50:49 +0100
Subject: [PATCH] PR other/69006: S/390: Fix extra newlines after
 diagnostics.

---
 gcc/config/s390/s390-c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/config/s390/s390-c.c b/gcc/config/s390/s390-c.c
index 14d030d..2b6e405 100644
--- a/gcc/config/s390/s390-c.c
+++ b/gcc/config/s390/s390-c.c
@@ -909,7 +909,7 @@ s390_resolve_overloaded_builtin (location_t loc,
     }
   else if (num_matches > 1)
     {
-      error_at (loc, "ambiguous overload for intrinsic: %s\n",
+      error_at (loc, "ambiguous overload for intrinsic: %s",
 	     IDENTIFIER_POINTER (DECL_NAME (ob_fndecl)));
       return error_mark_node;
     }
-- 
2.3.0

Re: [PATCH] PR other/69006: S/390: Fix extra newlines after diagnostics.

[David Malcolm]

On Wed, 2016-01-27 at 12:01 +0100, Dominik Vogt wrote:
> The attached patch removes a blank line after an error message.
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69006

Presumably this was exposed by the stricter testing I added to lib/gcc
-dg.exp in r232837?

>    else if (num_matches > 1)
>      {
> -      error_at (loc, "ambiguous overload for intrinsic: %s\n",
> +      error_at (loc, "ambiguous overload for intrinsic: %s",
>  	     IDENTIFIER_POINTER (DECL_NAME (ob_fndecl)));
>        return error_mark_node;
>      }

I'm not a reviewer, but FWIW the removal of the trailing "\n" looks
sane to me.

Should this code be using %qs rather than %s? (or somesuch, or is that
a gcc 7 thing)

Dave

Re: [PATCH] PR other/69006: S/390: Fix extra newlines after diagnostics.

[Dominik Vogt]

On Wed, Jan 27, 2016 at 09:22:19AM -0500, David Malcolm wrote:
> On Wed, 2016-01-27 at 12:01 +0100, Dominik Vogt wrote:
> > The attached patch removes a blank line after an error message.
> > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69006
> 
> Presumably this was exposed by the stricter testing I added to lib/gcc
> -dg.exp in r232837?

Yes, of course.

> > -      error_at (loc, "ambiguous overload for intrinsic: %s\n",
> > +      error_at (loc, "ambiguous overload for intrinsic: %s",
> >  	     IDENTIFIER_POINTER (DECL_NAME (ob_fndecl)));
 
> Should this code be using %qs rather than %s? (or somesuch, or is that
> a gcc 7 thing)

Yes, probably.  I'll make a separate patch for this.

Ciao

Dominik ^_^  ^_^

-- 

Dominik Vogt
IBM Germany

Re: [PATCH] PR other/69006: S/390: Fix extra newlines after diagnostics.

[Andreas Krebbel]

On Wed, Jan 27, 2016 at 12:01:26PM +0100, Dominik Vogt wrote:
> gcc/ChangeLog
> 
> 	PR other/69006
> 	* config/s390/s390-c.c (s390_resolve_overloaded_builtin): Remove
> 	trailing blank line from error message.

Applied.  Thanks!

-Andreas-