[PATCH] S/390: Use %qs in error messages.

[PATCH] S/390: Use %qs in error messages.

[Dominik Vogt]

[-- Attachment #1: Type: text/plain, Size: 271 bytes --]

The attached patch replaces %qs instead of %s in an error message,
adds %qs to another and fixes indentation in one of the messages.

Compiled and checked that no tests rely on the changed error
messages on a zEC12.

Ciao

Dominik ^_^  ^_^

-- 

Dominik Vogt
IBM Germany

[-- Attachment #2: 0001-ChangeLog --]
[-- Type: text/plain, Size: 169 bytes --]

gcc/ChangeLog

	* config/s390/s390-c.c (s390_resolve_overloaded_builtin): Format
	declaration name with %qs and print it in both error messages.  Also
	fix indentation.

[-- Attachment #3: 0001-S-390-Use-qs-in-error-messages.patch --]
[-- Type: text/x-diff, Size: 1110 bytes --]

From 2455f3dd89b84e9e93ca30d0d52733f1f05a1802 Mon Sep 17 00:00:00 2001
From: Dominik Vogt <vogt@linux.vnet.ibm.com>
Date: Fri, 29 Jan 2016 09:58:55 +0100
Subject: [PATCH] S/390: Use %qs in error messages.

---
 gcc/config/s390/s390-c.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/gcc/config/s390/s390-c.c b/gcc/config/s390/s390-c.c
index 2b6e405..cd3584b 100644
--- a/gcc/config/s390/s390-c.c
+++ b/gcc/config/s390/s390-c.c
@@ -904,13 +904,14 @@ s390_resolve_overloaded_builtin (location_t loc,
 
   if (last_match_type == INT_MAX)
     {
-      error_at (loc, "invalid parameter combination for intrinsic");
+      error_at (loc, "invalid parameter combination for intrinsic %qs",
+		IDENTIFIER_POINTER (DECL_NAME (ob_fndecl)));
       return error_mark_node;
     }
   else if (num_matches > 1)
     {
-      error_at (loc, "ambiguous overload for intrinsic: %s",
-	     IDENTIFIER_POINTER (DECL_NAME (ob_fndecl)));
+      error_at (loc, "ambiguous overload for intrinsic %qs",
+		IDENTIFIER_POINTER (DECL_NAME (ob_fndecl)));
       return error_mark_node;
     }
 
-- 
2.3.0

Re: [PATCH] S/390: Use %qs in error messages.

[Andreas Krebbel]

On Fri, Jan 29, 2016 at 10:06:47AM +0100, Dominik Vogt wrote:
> gcc/ChangeLog
> 
> 	* config/s390/s390-c.c (s390_resolve_overloaded_builtin): Format
> 	declaration name with %qs and print it in both error messages.  Also
> 	fix indentation.

Applied.  Thanks!

-Andreas-