From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 113622 invoked by alias); 17 Feb 2016 12:30:23 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 112153 invoked by uid 89); 17 Feb 2016 12:30:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=capital, 198 X-HELO: fencepost.gnu.org Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (208.118.235.10) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 17 Feb 2016 12:30:18 +0000 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48918) by fencepost.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1aW1FH-0001sk-NR for gcc-patches@gnu.org; Wed, 17 Feb 2016 07:30:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aW1FE-0002j9-1b for gcc-patches@gnu.org; Wed, 17 Feb 2016 07:30:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47344) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aW1FD-0002j0-SB for gcc-patches@gnu.org; Wed, 17 Feb 2016 07:30:11 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 377D1804E1; Wed, 17 Feb 2016 12:30:10 +0000 (UTC) Received: from tucnak.zalov.cz ([10.3.113.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1HCU8XN010974 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 17 Feb 2016 07:30:09 -0500 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id u1HCU5TN011925; Wed, 17 Feb 2016 13:30:05 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id u1HCU2Mt011924; Wed, 17 Feb 2016 13:30:02 +0100 Date: Wed, 17 Feb 2016 12:30:00 -0000 From: Jakub Jelinek To: Tom de Vries , Jan Hubicka , Richard Biener Cc: "gcc-patches@gnu.org" , Ilya Verbin Subject: Re: [PATCH, PR69607] Mark offload symbols as global in lto Message-ID: <20160217123002.GC3017@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <56B89150.7000209@mentor.com> <56C46149.3060503@mentor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56C46149.3060503@mentor.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg01158.txt.bz2 On Wed, Feb 17, 2016 at 01:02:17PM +0100, Tom de Vries wrote: > Mark offload symbols as global in lto I'm really not familiar with that part of LTO, so I'm CCing Honza and Richard here. > 2016-02-08 Tom de Vries > > PR lto/69607 > * lto-partition.c (promote_offload_tables): New function. > * lto-partition.h (promote_offload_tables): Declare. Just one space instead of two after : > * lto.c (do_whole_program_analysis): call promote_offload_tables. Capital C in Call. > --- /dev/null > +++ b/libgomp/testsuite/libgomp.c/target-36.c > @@ -0,0 +1,4 @@ > +/* { dg-do run { target lto } } */ > +/* { dg-additional-options "-flto -flto-partition=1to1 -fno-toplevel-reorder" } */ > + > +#include "target-1.c" > diff --git a/libgomp/testsuite/libgomp.c/target-37.c b/libgomp/testsuite/libgomp.c/target-37.c > new file mode 100644 > index 0000000..1edb21e > --- /dev/null > +++ b/libgomp/testsuite/libgomp.c/target-37.c > @@ -0,0 +1,98 @@ > +/* { dg-do run { target lto } } */ > +/* { dg-additional-sources "target-38.c" } */ > +/* { dg-additional-options "-flto -flto-partition=1to1 -fno-toplevel-reorder" } */ > + > +extern > +#ifdef __cplusplus > +"C" > +#endif > +void abort (void); Why the C++ stuff in there? Do you intend to include the testcase also in libgomp.c++? If not, it is not needed. Otherwise, the tests LGTM. Jakub