From: Jan Hubicka <hubicka@ucw.cz>
To: Richard Biener <rguenther@suse.de>
Cc: Jakub Jelinek <jakub@redhat.com>,
gcc-patches@gcc.gnu.org, Jan Hubicka <hubicka@ucw.cz>
Subject: Re: [PATCH] Fix PR56888
Date: Tue, 23 Feb 2016 10:28:00 -0000 [thread overview]
Message-ID: <20160223102809.GC43696@kam.mff.cuni.cz> (raw)
In-Reply-To: <alpine.LSU.2.11.1602221401430.31547@t29.fhfr.qr>
>
> Ok, so maybe a better question to symtab would be if there is an
> actual definition for what __builtin_FOO will call. Not really
> whether that definition is cfun. Of course all the fortify
> always-inline wrappers should not count as such (just in case
> the symtab code is confused about those).
Also GNU extern inlines that are often used to deal special cases.
>
> So,
>
> bool symbol_table::have_definition (enum built_in_fn);
>
> ? Not sure how to best implement that either. asmname lookups are
> expensive ...
I am back from China trip, so i can handle you patch if you want.
I see that by stopping the optimization on whole translation unit that
defines memcpy/memset will solve the reachability issue I mentioned
in previous mail, but also when LTOing stuff like Linux kernel, it will
prevent the optimization on the whole program.
I am not quite sure how to deal with the alwaysinline wrappers however,
because there theoretically may contain memcpy/memset loops themselves.
Honza
>
> Richard.
next prev parent reply other threads:[~2016-02-23 10:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 12:44 Richard Biener
2016-02-22 12:54 ` Jakub Jelinek
2016-02-22 12:59 ` Richard Biener
2016-02-22 13:04 ` Richard Biener
2016-02-23 10:28 ` Jan Hubicka [this message]
2016-02-23 11:32 ` Richard Biener
2017-02-14 8:42 ` Richard Biener
2017-02-16 15:58 ` Jan Hubicka
2016-02-23 10:25 ` Jan Hubicka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160223102809.GC43696@kam.mff.cuni.cz \
--to=hubicka@ucw.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).