public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Pierre-Marie de Rodat <derodat@adacore.com>
Cc: Jason Merrill <jason@redhat.com>,
	gcc-patches@gcc.gnu.org,        Cary Coutant <ccoutant@gmail.com>,
	       Eric Botcazou <ebotcazou@adacore.com>
Subject: Re: [PATCHES, PING*5] Enhance standard DWARF for Ada
Date: Thu, 25 Feb 2016 10:45:00 -0000	[thread overview]
Message-ID: <20160225104503.GO3017@tucnak.redhat.com> (raw)
In-Reply-To: <56CED8DB.4060204@adacore.com>

On Thu, Feb 25, 2016 at 11:35:07AM +0100, Pierre-Marie de Rodat wrote:
> As I said at the end of a message in another thread
> (https://gcc.gnu.org/ml/gcc-patches/2016-01/msg01078.html), I always feel
> uncomfortable writing brittle dg-scan testcases, hence the current lack of
> testcases for those DWARF changes.

I agree that catching this in scan-assembler test is hard, but guality test
would catch this.  It is true that some guality tests (mostly the ones that
test behaviour of optimized code, which differs a lot between different
architectures) have known FAILs (or known XFAILs), because the target,
compilation options and gdb version matrix is too large to catch all cases.
But, if one just looks at test_summary output before/after a change,
one can detect regressions and fix them.  Perhaps in some cases you could
just limit to -O0 guality if it is something you want to just check if
the debug info is represented properly and don't need to test
-fvar-tracking-assignments etc. handling - you can just dg-skip-if the tests
except for -O0 etc.
Similarly, it shouldn't be hard to add tcl function to check for gdb
version, and limit some tests only to a particular version of gdb or newer.

	Jakub

  reply	other threads:[~2016-02-25 10:45 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-16  8:36 [PATCHES] " Pierre-Marie de Rodat
2015-07-16  8:42 ` [PATCH 1/8] Add a flag to control the balance between GNAT encodings, and std. DWARF Pierre-Marie de Rodat
2015-07-16  9:18   ` Andreas Schwab
2015-07-16 10:16     ` Richard Biener
2015-07-16 10:19       ` Pierre-Marie de Rodat
2015-07-16  8:43 ` [PATCH 2/8] DWARF: handle variable-length records and variant parts Pierre-Marie de Rodat
2015-07-16  9:00   ` Pierre-Marie de Rodat
2015-07-16  8:44 ` [PATCH 3/8] DWARF: add a language hook to override types in debugging information Pierre-Marie de Rodat
2015-07-16  8:45 ` [PATCH 4/8] DWARF: add a language hook for fixed-point types Pierre-Marie de Rodat
2015-08-18  8:32   ` Pierre-Marie de Rodat
2015-07-16  8:46 ` [PATCH 5/8] DWARF: describe Ada dynamic arrays as proper arrays Pierre-Marie de Rodat
2015-07-16  8:49 ` [PATCH 6/8] create a macro for max dimensions for array descr. lang. hook Pierre-Marie de Rodat
2015-07-16  8:51 ` [PATCH 7/8] DWARF: add a language hook for scalar biased types Pierre-Marie de Rodat
2015-08-18  8:16   ` Pierre-Marie de Rodat
2015-07-16  8:53 ` [PATCH 8/8] DWARF: describe properly Ada packed arrays Pierre-Marie de Rodat
2015-07-23 10:59 ` [PATCHES, PING] Enhance standard DWARF for Ada Pierre-Marie de Rodat
2015-07-31 11:04   ` [PATCHES, PING*2] " Pierre-Marie de Rodat
2015-07-31 11:31     ` Pierre-Marie de Rodat
2015-08-08  9:01       ` [PATCHES, PING*3] " Pierre-Marie de Rodat
2015-08-31  9:15         ` [PATCHES, PING*4] " Pierre-Marie de Rodat
2015-10-20 20:20           ` [PATCHES, PING*5] " Pierre-Marie de Rodat
2015-11-18 20:35             ` Jason Merrill
2015-11-23 14:01               ` Pierre-Marie de Rodat
2015-11-23 21:11                 ` Jason Merrill
2015-11-24  9:19                   ` Pierre-Marie de Rodat
2015-11-25 18:36                     ` Jason Merrill
2015-11-26 12:37                       ` Pierre-Marie de Rodat
2015-12-03 10:35                         ` [PATCHES, PING] " Pierre-Marie de Rodat
2015-12-10  7:18                           ` [PATCHES, PING*2] " Pierre-Marie de Rodat
2015-12-11 20:25                         ` [PATCHES, PING*5] " Jason Merrill
2015-12-16  8:53                           ` Pierre-Marie de Rodat
2015-12-16 21:30                             ` Jason Merrill
2015-12-17 14:10                               ` Pierre-Marie de Rodat
2015-12-18 17:56                                 ` Jason Merrill
2015-12-18 17:58                                   ` Jakub Jelinek
2015-12-18 18:22                                     ` Eric Botcazou
2016-01-02 21:37                                       ` Andreas Schwab
2016-01-02 23:45                                         ` Eric Botcazou
2016-01-05  9:02                                           ` Pierre-Marie de Rodat
2015-12-18 20:23                                   ` Pierre-Marie de Rodat
2015-12-21 14:16                                     ` Pierre-Marie de Rodat
2015-12-21 15:40                                       ` Jason Merrill
2015-12-21 15:44                                         ` Pierre-Marie de Rodat
2016-02-25  9:48                             ` Jakub Jelinek
2016-02-25 10:35                               ` Pierre-Marie de Rodat
2016-02-25 10:45                                 ` Jakub Jelinek [this message]
2016-02-25 12:23                                   ` Eric Botcazou
2016-02-25 15:51                                 ` Jakub Jelinek
2016-02-25 15:59                                   ` Pierre-Marie de Rodat
2016-02-25 15:54                               ` Pierre-Marie de Rodat
2016-02-25 16:46                                 ` [PATCH] Fix DW_OP_GNU_implicit_pointer referring to DW_TAG_dwarf_procedure (PR debug/69947) Jakub Jelinek
2016-02-25 20:55                                   ` Jakub Jelinek
2016-02-26  8:59                                   ` Pierre-Marie de Rodat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160225104503.GO3017@tucnak.redhat.com \
    --to=jakub@redhat.com \
    --cc=ccoutant@gmail.com \
    --cc=derodat@adacore.com \
    --cc=ebotcazou@adacore.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jason@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).