From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 78656 invoked by alias); 25 Feb 2016 15:51:48 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 78638 invoked by uid 89); 25 Feb 2016 15:51:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: =?ISO-8859-1?Q?No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=sk:pyelfto, progress=e2, wish, speak?= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 25 Feb 2016 15:51:45 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 3FA1735A806; Thu, 25 Feb 2016 15:51:44 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-113-25.phx2.redhat.com [10.3.113.25]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1PFpglG001970 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 25 Feb 2016 10:51:43 -0500 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id u1PFpdDd032537; Thu, 25 Feb 2016 16:51:40 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id u1PFpcdl031910; Thu, 25 Feb 2016 16:51:38 +0100 Date: Thu, 25 Feb 2016 15:51:00 -0000 From: Jakub Jelinek To: Pierre-Marie de Rodat Cc: Jason Merrill , gcc-patches@gcc.gnu.org, Cary Coutant , Eric Botcazou Subject: Re: [PATCHES, PING*5] Enhance standard DWARF for Ada Message-ID: <20160225155138.GT3017@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <564CE0F7.4060801@redhat.com> <56531A3E.40504@adacore.com> <56538037.7060900@redhat.com> <56542B0F.6040102@adacore.com> <5655FF72.7030901@redhat.com> <5656FC6C.7040008@adacore.com> <566B3151.4000209@redhat.com> <56712691.4050709@adacore.com> <20160225094803.GN3017@tucnak.redhat.com> <56CED8DB.4060204@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <56CED8DB.4060204@adacore.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg01738.txt.bz2 On Thu, Feb 25, 2016 at 11:35:07AM +0100, Pierre-Marie de Rodat wrote: > On 02/25/2016 10:48 AM, Jakub Jelinek wrote: > >Unfortunately, this broke the DW_OP_GNU_implicit_pointer support, on vast > >majority of binaries and libraries gcc now emits invalid DWARF (which both > >gdb and dwz complain about and dwz refuses to optimize because of that). > > Arg, sorry about this! > > >I'm attaching two possible patches, so far untested. > > Thanks, I’m having a look as we speak. > > >So, Pierre-Marie, can I ask you to run whatever Ada debug info testsuite > >you have with the second patch? And for GCC 7 really please consider adding > >gnat.dg/guality/ and fill it with tests. > > Testing in progress… > > I have a tiny Python/pyelftools-based testsuite that checks the DIE patterns > GCC emits for several Ada types. I really wish I could somehow integrate > them to the GCC testsuite, but right now I don’t know how I could do similar > things, there. Do you have some short Ada testcase where the DW_OP_call4 referring to DW_TAG_dwarf_procedure is supposed to be emitted? I believe you must be getting there the .Ldebug_info0+0 invalid reference in the DW_OP_call4 operand. Jakub