From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 36814 invoked by alias); 26 Feb 2016 11:05:09 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 36795 invoked by uid 89); 26 Feb 2016 11:05:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=duplicates, sk:need_as, xalancbmk, regested X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 26 Feb 2016 11:05:05 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 135B3461C7; Fri, 26 Feb 2016 11:05:04 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-113-25.phx2.redhat.com [10.3.113.25]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1QB52Qb004515 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 26 Feb 2016 06:05:03 -0500 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id u1QB50XQ019467; Fri, 26 Feb 2016 12:05:00 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id u1QB4wwS016959; Fri, 26 Feb 2016 12:04:58 +0100 Date: Fri, 26 Feb 2016 11:05:00 -0000 From: Jakub Jelinek To: Jan Hubicka Cc: gcc-patches@gcc.gnu.org Subject: Re: Avoid redundant DECL_ASSEMBLER_NAME computations for ODR types Message-ID: <20160226110458.GA3017@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <20160226105249.GC94603@kam.mff.cuni.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160226105249.GC94603@kam.mff.cuni.cz> User-Agent: Mutt/1.5.24 (2015-08-30) X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg01776.txt.bz2 On Fri, Feb 26, 2016 at 11:52:50AM +0100, Jan Hubicka wrote: > Hi, > while looking into the PR testcase I noticed that we detect wrong duplicate > types. This is because we compute DECL_ASSEMBLER_NAME of a type variant which > is not necessary. > > Bootstrapped/regested x86_64-linux and I checked dumps of xalancbmk to verify > that nothing changes in ODR type merging except for the duplicates. OK? > > Honza > * tree.c (need_assembler_name_p): Do not compute mangled name for > variabt types. s/variabt/variant/ Jakub