From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: krebbel@linux.vnet.ibm.com
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 7/9] S/390: Get rid of Y constraint in vector.md.
Date: Tue, 01 Mar 2016 15:11:00 -0000 [thread overview]
Message-ID: <20160301151145.DEF62C88E@oc7340732750.ibm.com> (raw)
In-Reply-To: <20160229145756.61A92642@oc7340732750.ibm.com> from "Ulrich Weigand" at Feb 29, 2016 03:57:56 PM
I wrote:
> Andreas Krebbel wrote:
>
> > +; vec_set is supposed to *modify* an existing vector so operand 0 is
> > +; duplicated as input operand.
> > +(define_expand "vec_set<mode>"
> > + [(set (match_operand:V 0 "register_operand" "")
> > + (unspec:V [(match_operand:<non_vec> 1 "general_operand" "")
> > + (match_operand:SI 2 "shift_count_or_setmem_operand" "")
>
> This is probably only cosmetic, but should we use nonmemory_operand here
> instead of shift_count_or_setmem_operand (just like everywhere else now)?
>
> > +(define_expand "vec_extract<mode>"
> > + [(set (match_operand:<non_vec> 0 "nonimmediate_operand" "")
> > + (unspec:<non_vec> [(match_operand:V 1 "register_operand" "")
> > + (match_operand:SI 2 "shift_count_or_setmem_operand" "")]
>
> Likewise.
I just noticed that there are two more UNSPEC_VEC_SET expanders
in vx-builtins.md. I guess those should be likewise changed:
(define_expand "vec_insert<mode>"
[(set (match_operand:V_HW 0 "register_operand" "")
(unspec:V_HW [(match_operand:<non_vec> 2 "register_operand" "")
(match_operand:SI 3 "shift_count_or_setmem_operand" "")
(match_operand:V_HW 1 "register_operand" "")]
UNSPEC_VEC_SET))]
"TARGET_VX"
"")
(define_expand "vec_promote<mode>"
[(set (match_operand:V_HW 0 "register_operand" "")
(unspec:V_HW [(match_operand:<non_vec> 1 "register_operand" "")
(match_operand:SI 2 "shift_count_or_setmem_operand" "")
(match_dup 0)]
UNSPEC_VEC_SET))]
"TARGET_VX"
"")
Then the only remaining users of shift_count_or_setmem_operand are the
actual setmem patterns (so maybe the predicate can be renamed to
"setmem_operand") :-)
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2016-03-01 15:11 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 8:47 [PATCH 0/9] S/390 rework shift count handling - v3 Andreas Krebbel
2016-02-29 8:46 ` [PATCH 3/9] S/390: Get rid of Y constraint in rotate patterns Andreas Krebbel
2016-02-29 8:46 ` [PATCH 8/9] S/390: Use define_subst for the setmem patterns Andreas Krebbel
2016-02-29 8:46 ` [PATCH 9/9] S/390: Disallow SImode in s390_decompose_address Andreas Krebbel
2016-02-29 8:47 ` [PATCH 5/9] S/390: Get rid of Y constraint in arithmetic right shift patterns Andreas Krebbel
2016-02-29 8:47 ` [PATCH 4/9] S/390: Get rid of Y constraint in left and logical " Andreas Krebbel
2016-02-29 8:47 ` [PATCH 7/9] S/390: Get rid of Y constraint in vector.md Andreas Krebbel
2016-02-29 14:58 ` Ulrich Weigand
2016-03-01 15:11 ` Ulrich Weigand [this message]
2016-03-01 15:31 ` Andreas Krebbel
2016-03-08 12:51 ` [PATCH] S/390: Rename shift_count_or_setmem_operand to setmem_operand Andreas Krebbel
2016-02-29 8:47 ` [PATCH 1/9] gensupport: Fix define_subst operand renumbering Andreas Krebbel
2016-02-29 13:37 ` Bernd Schmidt
2016-03-01 9:30 ` Andreas Krebbel
2016-03-01 12:15 ` James Greenhalgh
2016-03-01 12:17 ` Bernd Schmidt
2016-03-01 12:35 ` Andreas Krebbel
2016-03-01 13:38 ` James Greenhalgh
2016-03-01 14:55 ` Andreas Krebbel
2016-02-29 8:47 ` [PATCH 2/9] S/390: Use enabled attribute overrides to disable alternatives Andreas Krebbel
2016-02-29 8:47 ` [PATCH 6/9] S/390: Get rid of Y constraint in tabort Andreas Krebbel
2016-02-29 14:59 ` [PATCH 0/9] S/390 rework shift count handling - v3 Ulrich Weigand
2016-03-01 9:30 ` Andreas Krebbel
-- strict thread matches above, loose matches on Subject: below --
2016-02-23 14:33 [PATCH 0/9] S/390 rework shift count handling - v2 Andreas Krebbel
2016-02-23 14:33 ` [PATCH 7/9] S/390: Get rid of Y constraint in vector.md Andreas Krebbel
2016-01-14 16:34 [PATCH 0/9] S/390 rework shift count handling Andreas Krebbel
2016-01-14 16:40 ` [PATCH 7/9] S/390: Get rid of Y constraint in vector.md Andreas Krebbel
2016-02-01 13:38 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160301151145.DEF62C88E@oc7340732750.ibm.com \
--to=uweigand@de.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=krebbel@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).