From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-422768-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 103968 invoked by alias); 4 Mar 2016 13:05:47 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 103950 invoked by uid 89); 4 Mar 2016 13:05:47 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:585, Cool
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 04 Mar 2016 13:05:46 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (Postfix) with ESMTPS id 44B5CC00F1D0;	Fri,  4 Mar 2016 13:05:45 +0000 (UTC)
Received: from redhat.com (ovpn-204-101.brq.redhat.com [10.40.204.101])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u24D5f6W011002	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);	Fri, 4 Mar 2016 08:05:44 -0500
Date: Fri, 04 Mar 2016 13:05:00 -0000
From: Marek Polacek <polacek@redhat.com>
To: Bernd Schmidt <bschmidt@redhat.com>
Cc: Patrick Palka <patrick@parcs.ath.cx>, David Malcolm <dmalcolm@redhat.com>,        GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 2/2] PR c/68187: fix overzealous -Wmisleading-indentation (comment #1)
Message-ID: <20160304130541.GJ10006@redhat.com>
References: <1457018483-26829-1-git-send-email-dmalcolm@redhat.com> <1457018483-26829-2-git-send-email-dmalcolm@redhat.com> <CA+C-WL9w-4EUDfDUxY4RZ8Tvm5+oOiEdRk8sA0kEWCQf-xavEg@mail.gmail.com> <56D98540.30702@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <56D98540.30702@redhat.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-SW-Source: 2016-03/txt/msg00340.txt.bz2

On Fri, Mar 04, 2016 at 01:53:20PM +0100, Bernd Schmidt wrote:
> On 03/03/2016 06:15 PM, Patrick Palka wrote:
> >Cool, this also fixes the false-positives seen in bdwgc, whose coding
> >style suggests indenting things inside an #ifdef as if it were an
> >if(), e.g.:
> >
> >     if (a)
> >       foo ();
> >#   ifndef A
> >       bar ();
> >#   endif
> >     ...
> 
> Once again I find myself thinking this is not a false positive, but terrible
> code we should warn for.

I agree.  It seems entirely sane to warn here.

	Marek