From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 55897 invoked by alias); 7 Mar 2016 10:02:05 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 55886 invoked by uid 89); 7 Mar 2016 10:02:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1187 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 07 Mar 2016 10:02:03 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 29A24C00358F; Mon, 7 Mar 2016 10:02:02 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-113-25.phx2.redhat.com [10.3.113.25]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u27A20q0005993 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 7 Mar 2016 05:02:01 -0500 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id u27A1vNR011935; Mon, 7 Mar 2016 11:01:58 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id u27A1tsK011934; Mon, 7 Mar 2016 11:01:55 +0100 Date: Mon, 07 Mar 2016 10:02:00 -0000 From: Jakub Jelinek To: Tom de Vries Cc: Jeff Law , Richard Biener , mliska , GCC Patches Subject: Re: [PATCH] Skip ubsan internal fns in tail-merge Message-ID: <20160307100155.GS3017@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <1c507aae804089fe39102391ff554d51a20ba391.1436450591.git.mliska@suse.cz> <20150709141312.GS10247@tucnak.redhat.com> <559E9481.70505@redhat.com> <20150709154153.GV10247@tucnak.redhat.com> <559EA345.6070105@redhat.com> <55A02707.6000505@redhat.com> <56DD4E9A.3030009@mentor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56DD4E9A.3030009@mentor.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-IsSubscribed: yes X-SW-Source: 2016-03/txt/msg00463.txt.bz2 On Mon, Mar 07, 2016 at 10:49:14AM +0100, Tom de Vries wrote: > This patch implements that. > > Should the asan internal function (ASAN_CHECK) be handled in the same way, > as suggested here ( https://gcc.gnu.org/ml/gcc-patches/2015-07/msg00776.html > )? > > OK for stage4 trunk if bootstrap and reg-test succeeds? Please certainly add ASAN_CHECK to the list. Perhaps more precise would be to allow merging them, but only if gimple_location (stmt1) == gimple_location (stmt2). Also, I wonder why you need to check both stmts individually, wouldn't it be better (both for the is_tm_ending and the ubsan/asan internal calls) to first call gimple_equal_p and only if it says the two are equal, check is_tm_ending (only on one stmt, if they are equal, then I hope is_tm_ending is necessarily equal for both), and similarly for the ubsan/asan ifns compare the gimple_location? > Skip ubsan internal fns in tail-merge > > 2016-03-07 Tom de Vries > > * tree-ssa-tail-merge.c (merge_stmt_p): New function, factored out > of ... > (find_duplicate): ... here. > (merge_stmt_p): Return false for ubsan functions. Jakub