From: James Greenhalgh <james.greenhalgh@arm.com>
To: Kyrill Tkachov <kyrylo.tkachov@foss.arm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Marcus Shawcroft <marcus.shawcroft@arm.com>,
Richard Earnshaw <Richard.Earnshaw@arm.com>
Subject: Re: [PATCH][AArch64] Fix thinko in handling of -momit-leaf-frame-pointer option
Date: Thu, 10 Mar 2016 16:19:00 -0000 [thread overview]
Message-ID: <20160310161910.GA8087@arm.com> (raw)
In-Reply-To: <56E195EE.4070903@foss.arm.com>
On Thu, Mar 10, 2016 at 03:42:38PM +0000, Kyrill Tkachov wrote:
> Hi all,
>
> When extending the aarch64_handle_option function for GCC 6 I introduced a thinko
> when handling the -momit-leaf-frame-pointer option and had it set the variable
> for -fomit-frame-pointer instead. This hasn't been particularly impactful because
> -momit-leaf-frame-pointer is on by default and will set -fomit-frame-pointer to true
> anyway in aarch64_override_options_after_change_1, but it would be exposed by the fix
> for PR 70044.
>
> This patch fixes that thinko.
> Bootstrapped and tested on aarch64-none-linux-gnu.
>
> Ok for trunk?
Looks obvious to me from your description. OK for trunk.
Thanks,
James
> 2016-03-10 Kyrylo Tkachov <kyrylo.tkachov@arm.com>
>
> * common/config/aarch64/aarch64-common.c (aarch64_handle_option):
> Set x_flag_omit_leaf_frame_pointer when handling
> -momit-leaf-frame-pointer.
> diff --git a/gcc/common/config/aarch64/aarch64-common.c b/gcc/common/config/aarch64/aarch64-common.c
> index 69f5da70e3d796752040de80ab1594a260e613d1..4969f07fef4c1c7d3bd7e5fa03149a4945e30b23 100644
> --- a/gcc/common/config/aarch64/aarch64-common.c
> +++ b/gcc/common/config/aarch64/aarch64-common.c
> @@ -98,7 +98,7 @@ aarch64_handle_option (struct gcc_options *opts,
> return true;
>
> case OPT_momit_leaf_frame_pointer:
> - opts->x_flag_omit_frame_pointer = val;
> + opts->x_flag_omit_leaf_frame_pointer = val;
> return true;
>
> default:
prev parent reply other threads:[~2016-03-10 16:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-10 15:42 Kyrill Tkachov
2016-03-10 16:19 ` James Greenhalgh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160310161910.GA8087@arm.com \
--to=james.greenhalgh@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kyrylo.tkachov@foss.arm.com \
--cc=marcus.shawcroft@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).