[PATCH][AArch64] Fix thinko in handling of -momit-leaf-frame-pointer option

[PATCH][AArch64] Fix thinko in handling of -momit-leaf-frame-pointer option

[Kyrill Tkachov]

[-- Attachment #1: Type: text/plain, Size: 762 bytes --]

Hi all,

When extending the aarch64_handle_option function for GCC 6 I introduced a thinko
when handling the -momit-leaf-frame-pointer option and had it set the variable
for -fomit-frame-pointer instead. This hasn't been particularly impactful because
-momit-leaf-frame-pointer is on by default and will set -fomit-frame-pointer to true
anyway in aarch64_override_options_after_change_1, but it would be exposed by the fix
for PR 70044.

This patch fixes that thinko.
Bootstrapped and tested on aarch64-none-linux-gnu.

Ok for trunk?

Thanks,
Kyrill

2016-03-10  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>

     * common/config/aarch64/aarch64-common.c (aarch64_handle_option):
     Set x_flag_omit_leaf_frame_pointer when handling
     -momit-leaf-frame-pointer.

[-- Attachment #2: aarch64-leaf-pointer.patch --]
[-- Type: text/x-patch, Size: 557 bytes --]

diff --git a/gcc/common/config/aarch64/aarch64-common.c b/gcc/common/config/aarch64/aarch64-common.c
index 69f5da70e3d796752040de80ab1594a260e613d1..4969f07fef4c1c7d3bd7e5fa03149a4945e30b23 100644
--- a/gcc/common/config/aarch64/aarch64-common.c
+++ b/gcc/common/config/aarch64/aarch64-common.c
@@ -98,7 +98,7 @@ aarch64_handle_option (struct gcc_options *opts,
       return true;
 
     case OPT_momit_leaf_frame_pointer:
-      opts->x_flag_omit_frame_pointer = val;
+      opts->x_flag_omit_leaf_frame_pointer = val;
       return true;
 
     default:

Re: [PATCH][AArch64] Fix thinko in handling of -momit-leaf-frame-pointer option

[James Greenhalgh]

On Thu, Mar 10, 2016 at 03:42:38PM +0000, Kyrill Tkachov wrote:
> Hi all,
> 
> When extending the aarch64_handle_option function for GCC 6 I introduced a thinko
> when handling the -momit-leaf-frame-pointer option and had it set the variable
> for -fomit-frame-pointer instead. This hasn't been particularly impactful because
> -momit-leaf-frame-pointer is on by default and will set -fomit-frame-pointer to true
> anyway in aarch64_override_options_after_change_1, but it would be exposed by the fix
> for PR 70044.
> 
> This patch fixes that thinko.
> Bootstrapped and tested on aarch64-none-linux-gnu.
> 
> Ok for trunk?

Looks obvious to me from your description. OK for trunk.

Thanks,
James

> 2016-03-10  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
> 
>     * common/config/aarch64/aarch64-common.c (aarch64_handle_option):
>     Set x_flag_omit_leaf_frame_pointer when handling
>     -momit-leaf-frame-pointer.

> diff --git a/gcc/common/config/aarch64/aarch64-common.c b/gcc/common/config/aarch64/aarch64-common.c
> index 69f5da70e3d796752040de80ab1594a260e613d1..4969f07fef4c1c7d3bd7e5fa03149a4945e30b23 100644
> --- a/gcc/common/config/aarch64/aarch64-common.c
> +++ b/gcc/common/config/aarch64/aarch64-common.c
> @@ -98,7 +98,7 @@ aarch64_handle_option (struct gcc_options *opts,
>        return true;
>  
>      case OPT_momit_leaf_frame_pointer:
> -      opts->x_flag_omit_frame_pointer = val;
> +      opts->x_flag_omit_leaf_frame_pointer = val;
>        return true;
>  
>      default: