From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 99090 invoked by alias); 14 Mar 2016 18:41:54 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 99081 invoked by uid 89); 14 Mar 2016 18:41:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=!pred, pred, HTo:U*bschmidt X-HELO: gate.crashing.org Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 14 Mar 2016 18:41:51 +0000 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.13.8) with ESMTP id u2EIff0A022034; Mon, 14 Mar 2016 13:41:41 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id u2EIfdps022032; Mon, 14 Mar 2016 13:41:39 -0500 Date: Mon, 14 Mar 2016 18:41:00 -0000 From: Segher Boessenkool To: Bernd Schmidt Cc: gcc-patches@gcc.gnu.org, rdsandiford@googlemail.com Subject: Re: [PATCH] genrecog: Fix crash on invalid input Message-ID: <20160314184138.GA21930@gate.crashing.org> References: <503d8081adff0ecb4a52ab0d3d96ae0771da1995.1457969588.git.segher@kernel.crashing.org> <56E6F740.2070007@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56E6F740.2070007@redhat.com> User-Agent: Mutt/1.4.2.3i X-IsSubscribed: yes X-SW-Source: 2016-03/txt/msg00789.txt.bz2 On Mon, Mar 14, 2016 at 06:39:12PM +0100, Bernd Schmidt wrote: > On 03/14/2016 04:38 PM, Segher Boessenkool wrote: > >If your machine description refers to a non-existent predicate genrecog > >crashes. This fixes it. > > Might be better to fix the caller? Yeah maybe. The next function that takes a pred also tests for !pred, but let me see what the caller of the failing case is. Segher