From: Jakub Jelinek <jakub@redhat.com>
To: James Norris <jnorris@codesourcery.com>
Cc: Thomas Schwinge <thomas@codesourcery.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
Daichi Fukuoka <dc-fukuoka@sgi.com>
Subject: Re: [gomp4] Fix handling of subarrays with update directive
Date: Wed, 23 Mar 2016 13:18:00 -0000 [thread overview]
Message-ID: <20160323131031.GA3017@tucnak.redhat.com> (raw)
In-Reply-To: <56F2948F.7010004@codesourcery.com>
On Wed, Mar 23, 2016 at 08:05:19AM -0500, James Norris wrote:
> Jakub,
>
> On 03/23/2016 05:24 AM, Jakub Jelinek wrote:
> >Otherwise LGTM, but please repost it with all the testcase changes you want
> >to make.
>
> Attached is the updated patch with the castings added, as well as
> the updated tests.
>
> Thanks!
> Jim
>
> ======
>
> 2016-03-23 James Norris <jnorris@codesourcery.com>
> Daichi Fukuoka <dc-fukuoka@sgi.com>
>
Missing
PR libgomp/69414
> * oacc-mem.c (delete_copyout, update_dev_host): Fix device address.
> * testsuite/libgomp.oacc-c-c++-common/update-1.c: Additional tests.
> * testsuite/libgomp.oacc-c-c++-common/update-1-2.c: Likewise.
> * testsuite/libgomp.oacc-fortran/update-1.f90: New file.
Ok with that change.
Jakub
next prev parent reply other threads:[~2016-03-23 13:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <56A0E84A.5030107@mentor.com>
[not found] ` <56F13A4E.20907@mentor.com>
2016-01-22 18:50 ` James Norris
2016-03-23 8:43 ` Thomas Schwinge
2016-03-23 10:33 ` Jakub Jelinek
2016-03-23 10:37 ` Fukuoka Daichi
2016-03-23 11:10 ` Jakub Jelinek
2016-03-23 11:31 ` Fukuoka Daichi
2016-03-23 13:15 ` James Norris
2016-03-23 13:18 ` Jakub Jelinek [this message]
2016-04-07 11:29 ` [gcc-5] " Thomas Schwinge
2016-04-07 11:30 ` Jakub Jelinek
2016-04-07 11:48 ` Thomas Schwinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160323131031.GA3017@tucnak.redhat.com \
--to=jakub@redhat.com \
--cc=dc-fukuoka@sgi.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jnorris@codesourcery.com \
--cc=thomas@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).