From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1755 invoked by alias); 1 Apr 2016 17:22:35 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 1737 invoked by uid 89); 1 Apr 2016 17:22:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 01 Apr 2016 17:22:31 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 145837109D; Fri, 1 Apr 2016 17:22:30 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-113-22.phx2.redhat.com [10.3.113.22]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u31HMRv1023646 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 1 Apr 2016 13:22:29 -0400 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id u31HMPnB004419; Fri, 1 Apr 2016 19:22:26 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id u31HMO8S004418; Fri, 1 Apr 2016 19:22:24 +0200 Date: Fri, 01 Apr 2016 17:22:00 -0000 From: Jakub Jelinek To: Marek Polacek Cc: Jeff Law , GCC Patches , Joseph Myers Subject: Re: [C PATCH] Fix ICE with VEC_COND_EXPR and compound literals (PR c/70307) Message-ID: <20160401172224.GE3017@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <20160401150333.GF13362@redhat.com> <56FE99BF.1020003@redhat.com> <20160401160224.GB3017@tucnak.redhat.com> <20160401161400.GG13362@redhat.com> <20160401161757.GC3017@tucnak.redhat.com> <20160401171006.GH13362@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160401171006.GH13362@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-IsSubscribed: yes X-SW-Source: 2016-04/txt/msg00074.txt.bz2 On Fri, Apr 01, 2016 at 07:10:06PM +0200, Marek Polacek wrote: > On Fri, Apr 01, 2016 at 06:17:57PM +0200, Jakub Jelinek wrote: > > Those comparisons with truthvalue_*_node would fail and DTRT. > > Or just c_fully_fold_internal all the arguments, be ready for any future > > further uses of VEC_COND_EXPR early? > > ..thus revive my earlier version of the patch that does it: > > Bootstrapped/regtested on x86_64-linux, ok for trunk? > > 2016-04-01 Marek Polacek > > PR c/70307 > * c-fold.c (c_fully_fold_internal): Handle VEC_COND_EXPR. > > * gcc.dg/torture/pr70307.c: New test. LGTM, thanks. Jakub