From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 70171 invoked by alias); 5 Apr 2016 09:18:57 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 70161 invoked by uid 89); 5 Apr 2016 09:18:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 05 Apr 2016 09:18:55 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6287480E6A; Tue, 5 Apr 2016 09:18:54 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-113-22.phx2.redhat.com [10.3.113.22]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u359Iq0T024039 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 5 Apr 2016 05:18:53 -0400 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id u359Io4u006025; Tue, 5 Apr 2016 11:18:51 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id u359InnC006024; Tue, 5 Apr 2016 11:18:49 +0200 Date: Tue, 05 Apr 2016 09:18:00 -0000 From: Jakub Jelinek To: Richard Biener Cc: Bernd Schmidt , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Fix PR70484, RTL DSE using wrong dependence check Message-ID: <20160405091849.GK19207@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <56FE931D.4030604@redhat.com> <20160404095002.GC19207@tucnak.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-IsSubscribed: yes X-SW-Source: 2016-04/txt/msg00219.txt.bz2 On Tue, Apr 05, 2016 at 11:05:44AM +0200, Richard Biener wrote: > True. By simple constant propagation I can remove a lot of code. > > I'm going to bootstrap / test the following - is this ok for trunk > now (I'm going to write a better changelog). LGTM with better Changelog, though I have small nits: > - else if ((s_info->group_id == group_id) > - && (s_info->cse_base == base)) > + if ((s_info->group_id == group_id) > + && (s_info->cse_base == base)) + if (s_info->group_id == group_id && s_info->cse_base == base) instead, please. > + if (store_info->group_id >= 0) > + { > + group_info *group > = rtx_group_vec[store_info->group_id]; The formatting looks wrong and group_info *group = rtx_group_vec[store_info->group_id]; fits now on one line. > @@ -3086,30 +2886,6 @@ scan_reads_nospill (insn_info_t insn_inf Please also rename the dse_step2_nospill scan_stores_nospill scan_reads_nospill dse_step5_nospill functions to s/_nospill//g and adjust all their uses (and perhaps function comments). Jakub