From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 60029 invoked by alias); 15 Apr 2016 11:15:30 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 59909 invoked by uid 89); 15 Apr 2016 11:15:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 15 Apr 2016 11:15:15 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5FD5A7F6CF; Fri, 15 Apr 2016 11:15:14 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-113-22.phx2.redhat.com [10.3.113.22]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u3FBFC3s005999 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 15 Apr 2016 07:15:13 -0400 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id u3FBF9E6023307; Fri, 15 Apr 2016 13:15:10 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id u3FBF7JL019445; Fri, 15 Apr 2016 13:15:07 +0200 Date: Fri, 15 Apr 2016 11:15:00 -0000 From: Jakub Jelinek To: Thomas Schwinge Cc: Bernd Schmidt , Martin Jambor , gcc-patches@gcc.gnu.org Subject: Re: Split out OMP constructs' SIMD clone supporting code (was: Splitting up gcc/omp-low.c?) Message-ID: <20160415111507.GL19207@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <20151207111758.GA24234@virgil.suse.cz> <20151207112243.GF24234@virgil.suse.cz> <20151209131930.GS5675@tucnak.redhat.com> <87si3b4mk3.fsf@kepler.schwinge.homeip.net> <5668638A.5030500@redhat.com> <20151210080835.GX5675@tucnak.redhat.com> <87y48o5toc.fsf@hertz.schwinge.homeip.net> <87twj54hx6.fsf@hertz.schwinge.homeip.net> <87h9f441ti.fsf@hertz.schwinge.homeip.net> <87ega83phf.fsf@hertz.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87ega83phf.fsf@hertz.schwinge.homeip.net> User-Agent: Mutt/1.5.24 (2015-08-30) X-IsSubscribed: yes X-SW-Source: 2016-04/txt/msg00714.txt.bz2 On Thu, Apr 14, 2016 at 10:27:40PM +0200, Thomas Schwinge wrote: > On Thu, 14 Apr 2016 18:01:13 +0200, I wrote: > > "simdclone" pass, with the > > respective supporting code. I will certainly submit line-diff patches if > > we agree that this is sound -- these two may actually be good candidates > > to do first, individually, and do that now, because they're completely > > self-contained. Makes sense? > > ;-) Made enough sense to me, so that I prepared the attached patch. I'm > also attaching a "-C" variant that I created using Git's -C5% option, and > which shows how the new file gcc/omp-simd-clone.c can be created from the > original gcc/omp-low.c. (Is that useful for review, or are you manually > doing something like that anyway?) > > > Should possibly rename omp-simd.c to omp-simd-clone.c to make it clear > > that's the only thing it does, the "simdclone" pass? > > I did that. > > I manually determined a reduced #include list for the new file > gcc/omp-simd-clone.c. Hope that's alright. > > OK to commit once bootstrap testing succeeded? Ok if you manage to do so before the (hopefully intermittent) branching. > commit 8f33dc59ad24a995694d42ee9013e0853426e190 > Author: Thomas Schwinge > Date: Thu Apr 14 21:56:31 2016 +0200 > > Split out OMP constructs' SIMD clone supporting code > > gcc/ > * omp-low.c (simd_clone_struct_alloc, simd_clone_struct_copy) > (simd_clone_vector_of_formal_parm_types) > (simd_clone_clauses_extract, simd_clone_compute_base_data_type) > (simd_clone_mangle, simd_clone_create) > (simd_clone_adjust_return_type, create_tmp_simd_array) > (simd_clone_adjust_argument_types, simd_clone_init_simd_arrays) > (struct modify_stmt_info, ipa_simd_modify_stmt_ops) > (ipa_simd_modify_function_body, simd_clone_linear_addend) > (simd_clone_adjust, expand_simd_clones, ipa_omp_simd_clone) > (pass_data_omp_simd_clone, class pass_omp_simd_clone) > (pass_omp_simd_clone::gate, make_pass_omp_simd_clone): Move > into... > * omp-simd-clone.c: ... this new file. > (simd_clone_vector_of_formal_parm_types): Make it static. > * Makefile.in (OBJS): Add omp-simd-clone.o. > > gcc/Makefile.in | 1 + > gcc/omp-low.c | 1606 ------------------------------------------------ > gcc/omp-simd-clone.c | 1654 ++++++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 1655 insertions(+), 1606 deletions(-) Jakub