From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 110767 invoked by alias); 19 Apr 2016 10:54:18 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 110525 invoked by uid 89); 19 Apr 2016 10:54:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1254 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 19 Apr 2016 10:54:13 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 873E7811A7; Tue, 19 Apr 2016 10:54:12 +0000 (UTC) Received: from laptop.zalov.cz (ovpn-116-16.ams2.redhat.com [10.36.116.16]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u3JAs8fY020287 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 19 Apr 2016 06:54:11 -0400 Received: from laptop.zalov.cz (localhost [127.0.0.1]) by laptop.zalov.cz (8.15.2/8.15.2) with ESMTP id u3JAs5g7030770; Tue, 19 Apr 2016 12:54:06 +0200 Received: (from jakub@localhost) by laptop.zalov.cz (8.15.2/8.15.2/Submit) id u3JAs153030769; Tue, 19 Apr 2016 12:54:01 +0200 Date: Tue, 19 Apr 2016 10:54:00 -0000 From: Jakub Jelinek To: Andreas Krebbel Cc: gcc-patches@gcc.gnu.org, uweigand@de.ibm.com Subject: Re: [PATCH] PR70674: S/390: Add memory barrier to stack pointer restore from fpr. Message-ID: <20160419105400.GP2920@laptop.zalov.cz> Reply-To: Jakub Jelinek References: <1461056554-18150-1-git-send-email-krebbel@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1461056554-18150-1-git-send-email-krebbel@linux.vnet.ibm.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-IsSubscribed: yes X-SW-Source: 2016-04/txt/msg00912.txt.bz2 On Tue, Apr 19, 2016 at 11:02:34AM +0200, Andreas Krebbel wrote: > I'll post the patches for the other two parts when gcc 7 entered stage > 1 again. It will not reenter stage 1 again, that happened last Friday ;) > This needs to go into 4.9/5/6 branches. Ok for 6, but I have formatting nit: > + rtx_insn *insn; > + > + if (!FP_REGNO_P (cfun_gpr_save_slot (i))) > + continue; > + Can you please: rtx fpr = gen_rtx_REG (DImode, cfun_gpr_save_slot (i)); if (i == STACK_POINTER_REGNUM) insn = emit_insn (gen_stack_restore_from_fpr (fpr)); else insn = emit_move_insn (gen_rtx_REG (DImode, i), fpr); That way IMHO it is more nicely formatted, you avoid the ugly ( at the end of line, it uses fewer lines anyway and additionally you can make it clear what the gen_rtx_REG (DImode, cfun_gpr_save_slot (i)) means by giving it a name. Of course, choose whatever other var name you prefer to describe what it is. > + if (i == STACK_POINTER_REGNUM) > + insn = emit_insn (gen_stack_restore_from_fpr ( > + gen_rtx_REG (DImode, cfun_gpr_save_slot (i)))); > + else > + insn = > + emit_move_insn (gen_rtx_REG (DImode, i), > + gen_rtx_REG (DImode, cfun_gpr_save_slot (i))); Jakub