From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32906 invoked by alias); 27 Apr 2016 14:24:21 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 30554 invoked by uid 89); 27 Apr 2016 14:24:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=genuinely, approximate, emails X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (207.82.80.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Apr 2016 14:24:01 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01lp0246.outbound.protection.outlook.com [213.199.154.246]) (Using TLS) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-14-dNQas6McTc2G2SvQ-NkPkw-1; Wed, 27 Apr 2016 15:23:55 +0100 Received: from DB5PR08CA0006.eurprd08.prod.outlook.com (2a01:111:e400:52c3::16) by AM3PR08MB0134.eurprd08.prod.outlook.com (2a01:111:e400:8847::28) with Microsoft SMTP Server (TLS) id 15.1.466.19; Wed, 27 Apr 2016 14:23:53 +0000 Received: from DB3FFO11FD033.protection.gbl (2a01:111:f400:7e04::181) by DB5PR08CA0006.outlook.office365.com (2a01:111:e400:52c3::16) with Microsoft SMTP Server (TLS) id 15.1.477.8 via Frontend Transport; Wed, 27 Apr 2016 14:23:53 +0000 Received: from nebula.arm.com (217.140.96.140) by DB3FFO11FD033.mail.protection.outlook.com (10.47.217.64) with Microsoft SMTP Server (TLS) id 15.1.477.4 via Frontend Transport; Wed, 27 Apr 2016 14:23:52 +0000 Received: from arm.com (10.1.2.79) by mail.arm.com (10.1.106.66) with Microsoft SMTP Server id 14.3.279.2; Wed, 27 Apr 2016 15:23:51 +0100 Date: Wed, 27 Apr 2016 14:24:00 -0000 From: James Greenhalgh To: Evandro Menezes CC: Wilco Dijkstra , GCC Patches , Andrew Pinski , "philipp.tomsich@theobroma-systems.com" , Benedikt Huber , Subject: Re: [AArch64] Emit square root using the Newton series Message-ID: <20160427142351.GC40892@arm.com> References: <56EB33E1.5010101@samsung.com> <56F43BF2.7020407@samsung.com> <56FEFA06.2090301@samsung.com> <5702971D.8020008@samsung.com> <57043C68.20907@samsung.com> <570D3B1B.3070008@samsung.com> MIME-Version: 1.0 In-Reply-To: <570D3B1B.3070008@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:217.140.96.140;IPV:CAL;SCL:-1;CTRY:GB;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(24454002)(189002)(199003)(36756003)(11100500001)(1076002)(1096002)(2906002)(4001350100001)(47776003)(106466001)(586003)(1220700001)(6806005)(5008740100001)(77096005)(2950100001)(104016004)(4326007)(23726003)(33656002)(50466002)(83506001)(5003600100002)(46406003)(54356999)(50986999)(87936001)(76176999)(110136002)(92566002)(86362001)(93886004)(189998001);DIR:OUT;SFP:1101;SCL:1;SRVR:AM3PR08MB0134;H:nebula.arm.com;FPR:;SPF:Pass;MLV:sfv;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;DB3FFO11FD033;1:33IvHmgYTqEbagGOUWBm3Qa1oSwuCxkDD01BGE97Zn+zfxb1IFMYJFJmOWPhYQYU0+PviXFCZjg3PIcontkv8AK4ozVBK1py72gWNFOoSdY59PCrIv+Qc/PSlQcEmW/YWJLAjkP95XiLK6L6G5GZJCCkVVSujIfUdxtAYrMCe+aGG6E3eTrbUylfEoJtiO56dNi/kL0ff9b4uYaNYiv3e1PGon37K3oTMA9+jnidrFtR0tqlaMvX5fjrhdqVfp0s+7K+VPPF/nKfwoy5P3kUP2DQx6TfH9RgblVX9RNEktTvvn1Y4wOtG7AdqoAhkr4wfD1gZSHeBgROJqpuDD/fNX8EzYIqaY/ZxRfsA21tTgojfb6rPAXfJrbk9Znr4Jb83SmynS6PKJPHk8ArrGzbrPXkoSyIMjj0X4V0/rkfbvTEeczehFbCAnw9qzOTWhNSOteYjq5pMgVHy1OIwq08Jk/x8/f4e+saB2bnfqS63e2FcxQfqoCXqqD+2rTx4hCJ7KgP9DFsO9S4a/vHYbqPcYzW9sqg7lEFv1Vxtu8OUxFXlYgrs+BlsZACCZbO654i X-MS-Office365-Filtering-Correlation-Id: c1a21315-a9a7-4eab-04af-08d36ea78f45 X-Microsoft-Exchange-Diagnostics: 1;AM3PR08MB0134;2:mblyHbB+jFrj7HTibhhl+Kvo09MeEXLELN9Em59OrQcRbsgwIAdgZT0R0GoEdids2SuDMW/4zEdVzNQULY1WlWik4N/aNJ+WtaYEEDiVDuOv7oo+Gw4Nhv+3Bi68EJSsh43U/8T504x67eNmwT287KGpjh8yuE8OoGlMkPpnxMwnAvM8rCMz8SsHaC7zAd9T;3:+oadYMPpsV6rL4MUnn03x4n0ARUEtA1OYY/mQp6lrRE7Qxu27X9dPWdlpuOtzt2s4cnbeGkDOlfHxv49ntOEedU3fcD7XjJ78688t2FZDxJP8Xvo4xQ0/kvaVPhpb/ucdg88wnLCuj1Mu2ROMtF5Y4bpbLNfPraH79c079UvZMKk119w8Mzojz776kNDOAOjHuhQj+H7x9/+S4Cto6CzRIzN/hM4oFBffbFhTlECrX9LR2EaBs9LsIFWxHfZ3XKouxSX6MYQgf8KW/yVIkONsA==;25:X2563AYrqolwlMe4GpYHVdgOM88hEMpQy1xMs7Z14EBP53oMjJMKTlngZiCj04cR1Kc2V4SFb7aWLph4+65G6DLEjACN/7RpeYqMWyFMT5Z9ZNhHVnRNK26gEHeL2fr6EkQu/vhoeG5l9aSIkFeAZkpHLn210d/4BIljt59FUyA8SIzeOCaUFV2Qklfp8ML/dtTumW/t24kvVyg7ThkqdY93Om9IjvmdUqbx8PjTNTKsZMwktwyp9GZt3eaF9Se+DAadu+ZpjFg8MXqTsktASWPEcAdvgwYq4aAXkFaViCj64EVM/CpdyQ9nlsZKWKSCzEowN4c3di1YxZ/CcQklSQ== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:AM3PR08MB0134; X-LD-Processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr NoDisclaimer: True X-Microsoft-Exchange-Diagnostics: 1;AM3PR08MB0134;20:tAlSlPproUhJKbzxfjM5AxNq3vsM8t93DCMgOAInIgd6N7vocXozQv/JKQAF/CYAbt2t8k9Bv8MdNI3R6Feqen4AwVPhJ0/7QkFRqZNXU/4Rj955H8VtYCH3gL3CXOcSZPiHAMhRoKYztXhN+CrMIidimI4Xz4IUmQmYKi6+r4JplCEXdnWNn0U2T6Cht5t55Y5d3gmnqyb7e3uWa+XrTDh+YkEVCQd1xekFUCdi7+4YQfox4StdvxuGHxOxGiBU;4:hDrYeLHblFNQuknjaqu2ZQs1VZlu2Dxq1Li5c/AALqLF+PomORsdEJ7gfmonUQVIeRDOa/66q+Ljl7Q2qJ3xgJWovArzcZThARylEzd9e4WIQ9cNF22aqNE1Dq1/chum1qn+odc7vh5MuQ/nr1uLDtsKoz3GAaJ/8yxK3CNIHnag1QPF5JudUF2L7QPuHZMaPCz3yM2v8Lzsm5UB6I/LIHi8fHRM//jfxm9Y44KOGIu64QblJDTReaY2XYEn/iZl4vPA0N3bP3BCmOdeRo5D72fO54HXqPLOXCGCj6lVVeqPX3NA9NpOjoIvgk4iiDjXikJm3lJuBl5KD1CJt0+wJRkRJRQtcpVffKLwMBjWYsutLxSL/Roftvx5zlxEvH2Z5QH4azdaU8czpm8Xfps8SK448zLS8NX6c9mSmNWhTNvcdOGQGfEwWTJpkSf79efG8iYOmJvhZNQX665yuEBc3TqxJbKp6hf6qBpiKrzCtBk= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(9101521072)(601004)(2401047)(13023025)(13013025)(13024025)(13020025)(5005006)(8121501046)(3002001)(10201501046)(6055026);SRVR:AM3PR08MB0134;BCL:0;PCL:0;RULEID:;SRVR:AM3PR08MB0134; X-Forefront-PRVS: 0925081676 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;AM3PR08MB0134;23:tq+N9NPFHpXSK7Zjheydrl7Q52i2DZP6/PhFhYgl1?= =?us-ascii?Q?5SdBSIsmhC1/kLJ+QOhLL+1o1HKygf4Yg32RQwcd7deyB+lL6b4xPd+IZKAb?= =?us-ascii?Q?ZmnqjJAZCq+SHI2SlSiTsvTd2oQs6bgjILBYWsPil7oQdb2QdDFazApa+BMe?= =?us-ascii?Q?PRizI3r0zajEamfiqPH1LOQsP75aB8Efj4HQp6VooN/Srr6ekyCpakXEqpFN?= =?us-ascii?Q?lK5U1JoT+mDGf6HSr6DzIOkWfeMKlve3Y/re3xHiiiQ4KSLPbSLDi3dmywuZ?= =?us-ascii?Q?EsBFA7OEN196aHm3zMswTvOlGJodSt+4bbWGZ5dnI/UrfzOAMu6/jzhjNXGD?= =?us-ascii?Q?kNwwy1ebQuKGd/IYAW7791jVXkY/Xh70Z57wMxve0iw+5utN8uBqNsQyjP6y?= =?us-ascii?Q?9LIKZNZhigDv6A2L46m67FNFTUtzwYdRNhN75d/4k/2d3pNzu7O0j/bTwAhY?= =?us-ascii?Q?JsLSclSSc30i/6LnC/dvAiUr367Thr28LI2YV46b1uDA5otYAZ4DvujNa/pz?= =?us-ascii?Q?nbb5eIdDExTsuinvuz+svaVWQfWKjOJ8s651ZUZ1OvR5Uvi6h4WyzPEhREP5?= =?us-ascii?Q?Q8S24fZifMVKIeZN/Tzr2US+jUT4CHOM7kJ0h1fLf8dm27zleBx41UeTVGq0?= =?us-ascii?Q?iA9Pl/duKMu8YYESbqu9XyyS5Bqg77VUGj4tLcKRrTR2ie6ykNVOg6RleeJA?= =?us-ascii?Q?HPz1lNvZuuaZ16AQgcQUfho5IkGJCS82uBpP9uibhDO1FA04Cno10nIJIzuL?= =?us-ascii?Q?qZHw4QhbZsiPDc2BJxgOS7WDpJuhB5pdXCbKWZXBjk+5IXAR46jdrXdZpv80?= =?us-ascii?Q?eYFxpbPHiL88Gl17fFO9q7K+7kOyfOoSFhMK+1Fl58vgzsfvkhI+qe9c0Pzx?= =?us-ascii?Q?9JA8tZ/qsUBEuEmbB1vgZ2NY5vjBZSlg5lj9ArNgdpTEmLiCW9qDcswC5Vym?= =?us-ascii?Q?AEy1AGAlgH2CtKu8sKTIFweawlk97wtjIMpRV6y6w=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;AM3PR08MB0134;5:xm5XriL0SKOBMEP7cETr50MCRwbgxUq+BlNUinWPbRnEGB/Wv2v36ynfrPWoqwiTbRnKchur1BtB0asWTwxCKxJpziLA9XaszwiAjtslwRk1sTMwahbIV23M3kKMYCzm2DADNWmBen0K6uNZyvWOA942wfgNq3yeZHNkXu/xY77TN6e4hY2nYScPjPqRDxuH;24:D9A6lToo7uQPywbRFsxDV5ZL6IYT/4SZ1NxapdP6sRo1A8285YYZqXuo/RHZ8Ye0VHWkhVyuvERozMc9xIIc+bVPJVveL6NwU2BxcYBXEyk=;7:+a2r0jOifRWYU79eKfcPNSJtjzJCOEqHiW9rl+2r4kTYbUiu9TSXmZvLBWPAfa/Z+lyTCquLDmOT3cY0tiJ6e2zd0WGJQY4kXPZ+rG/9CelK9pFTiphbMmotq9wJT3fpjM/mZIsY5vkiRt+xO5kkG65nq3UI/5kTxsMswhH3sr4y/6oVa42B2jIYNnPbLy+8bmAjbn2iwVGyTd55iPwEECI3KBTthdRgCCuwQBjIghc=;20:0s3j14Dt5rogZP8r2J74DTL/N5RLRbVfDFldKSNpc+3rO5SMLOKFkkuh907z3weXUa7gi5+kkRHjA4UFqS4CKzXOKoo2J5BdbqeY8O8fU93QUS7xmZsV9YM8jq+Hmlg2MyGxZBuV7lxNyratomZK8h4k0cWBxIqbaLkaN53T/VE= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2016 14:23:52.8978 (UTC) X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[217.140.96.140];Helo=[nebula.arm.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR08MB0134 X-MC-Unique: dNQas6McTc2G2SvQ-NkPkw-1 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-IsSubscribed: yes X-SW-Source: 2016-04/txt/msg01658.txt.bz2 On Tue, Apr 12, 2016 at 01:14:51PM -0500, Evandro Menezes wrote: > On 04/05/16 17:30, Evandro Menezes wrote: > >On 04/05/16 13:37, Wilco Dijkstra wrote: > >>I can't get any of these to work... Not only do I get a large > >>number of collisions and duplicated > >>code between these patches, when I try to resolve them, all I > >>get is crashes whenever I try > >>to use sqrt (even rsqrt stopped working). Do you have a patchset > >>that applies cleanly so I can > >>try all approximation routines? > > > >The original patches should be independent of each other, so > >indeed they duplicate code. > > > >This patch suite should be suitable for testing. Take look at other patch sets posted to this list for examples of how to make review easier. Please send a series of emails tagged: [Patch 0/3 AArch64] Add infrastructure for more approximate FP operations [PATCH 1/3 AArch64] Add more choices for the reciprocal square root approxi= mation [PATCH 2/3 AArch64] Emit square root using the Newton series [PATCH 3/3 AArch64] Emit division using the Newton series One patch per email, with the dependencies explicit like this, is infinitely easier to follow than the current structure of your patch set. I'm not trying to be pedantic for the sake of it, I'm genuinely unsure where the latest patch versions currently are and how I should apply them to a clean tree for review. Thanks, James