public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] Clean up tests where a later dg-do completely overrides another.
@ 2016-04-27  7:50 Dominik Vogt
  2016-04-27  8:52 ` Bernd Schmidt
                   ` (2 more replies)
  0 siblings, 3 replies; 11+ messages in thread
From: Dominik Vogt @ 2016-04-27  7:50 UTC (permalink / raw)
  To: gcc-patches; +Cc: Andreas Krebbel

[-- Attachment #1: Type: text/plain, Size: 168 bytes --]

The attached patch cleans up some (mostly unnecessary) dg-do
directives in the gcc.dg and gcc.target test cases.

Ciao

Dominik ^_^  ^_^

-- 

Dominik Vogt
IBM Germany

[-- Attachment #2: 0001-ChangeLog --]
[-- Type: text/plain, Size: 801 bytes --]

gcc/testsuite/ChangeLog

	* gcc/testsuite/gcc.dg/cpp/mac-dir-2.c: Remove pointless duplicate
	dg-do.
	* gcc/testsuite/gcc.dg/pr27003.c: Likewise.
	* gcc/testsuite/gcc.dg/tree-ssa/cswtch.c: Likewise.
	* gcc/testsuite/gcc.dg/tree-ssa/predcom-2.c: Likewise.
	* gcc/testsuite/gcc.dg/tree-ssa/predcom-4.c: Likewise.
	* gcc/testsuite/gcc.dg/tree-ssa/predcom-5.c: Likewise.
	* gcc.target/arc/mxy.c: Likewise.
	* gcc.target/arc/mswape.c: Likewise.
	* gcc.target/arc/mrtsc.c: Likewise.
	* gcc.target/arc/mcrc.c: Likewise.
	* gcc.target/arc/mdsp-packa.c: Likewise.
	* gcc.target/arc/mdvbf.c: Likewise.
	* gcc.target/arc/mlock.c: Likewise.
	* gcc.target/arc/mmac-24.c: Likewise.
	* gcc.dg/spec-options.c: Switch order of the two "dg-do run" so that
	the test ist actually "run" on sh*-*-*.  Order _does_ matter.

[-- Attachment #3: 0001-Clean-up-tests-where-a-later-dg-do-completely-overri.patch --]
[-- Type: text/x-diff, Size: 5779 bytes --]

From d21d7db706b30be13b23e8e583ecfd4445d1cdf4 Mon Sep 17 00:00:00 2001
From: Dominik Vogt <vogt@linux.vnet.ibm.com>
Date: Wed, 9 Mar 2016 15:42:23 +0100
Subject: [PATCH] Clean up tests where a later dg-do completely overrides
 another.

In most tests the first dg-do could be simply removed.  In one case the two
lines needed to be swapped so that the condition of the "run" was not
overridden by the later, unconditional "compile".
---
 gcc/testsuite/gcc.dg/cpp/mac-dir-2.c      | 2 --
 gcc/testsuite/gcc.dg/pr27003.c            | 1 -
 gcc/testsuite/gcc.dg/spec-options.c       | 2 +-
 gcc/testsuite/gcc.dg/tree-ssa/cswtch.c    | 1 -
 gcc/testsuite/gcc.dg/tree-ssa/predcom-2.c | 1 -
 gcc/testsuite/gcc.dg/tree-ssa/predcom-4.c | 1 -
 gcc/testsuite/gcc.dg/tree-ssa/predcom-5.c | 1 -
 gcc/testsuite/gcc.target/arc/mcrc.c       | 1 -
 gcc/testsuite/gcc.target/arc/mlock.c      | 1 -
 gcc/testsuite/gcc.target/arc/mmac-24.c    | 1 -
 gcc/testsuite/gcc.target/arc/mrtsc.c      | 1 -
 gcc/testsuite/gcc.target/arc/mswape.c     | 1 -
 gcc/testsuite/gcc.target/arc/mxy.c        | 1 -
 13 files changed, 1 insertion(+), 14 deletions(-)

diff --git a/gcc/testsuite/gcc.dg/cpp/mac-dir-2.c b/gcc/testsuite/gcc.dg/cpp/mac-dir-2.c
index b31ab3b..4c45d14 100644
--- a/gcc/testsuite/gcc.dg/cpp/mac-dir-2.c
+++ b/gcc/testsuite/gcc.dg/cpp/mac-dir-2.c
@@ -1,7 +1,5 @@
 /* Copyright (C) 2002 Free Software Foundation, Inc.  */
 
-/* { dg-do preprocess } */
-
 /* Source: Neil Booth, 26 Feb 2002.
 
    Test that we allow directives in macro arguments.  */
diff --git a/gcc/testsuite/gcc.dg/pr27003.c b/gcc/testsuite/gcc.dg/pr27003.c
index 5e416f4..7d886a0 100644
--- a/gcc/testsuite/gcc.dg/pr27003.c
+++ b/gcc/testsuite/gcc.dg/pr27003.c
@@ -1,4 +1,3 @@
-/* { dg-do compile } */
 /* { dg-do run } */
 /* { dg-options "-Os" } */
 
diff --git a/gcc/testsuite/gcc.dg/spec-options.c b/gcc/testsuite/gcc.dg/spec-options.c
index 1f9d8c1..e3ab23a 100644
--- a/gcc/testsuite/gcc.dg/spec-options.c
+++ b/gcc/testsuite/gcc.dg/spec-options.c
@@ -1,8 +1,8 @@
 /* Check that -mfoo is accepted if defined in a user spec
    and that it is not passed on the command line.  */
 /* Must be processed in EXTRA_SPECS to run.  */
-/* { dg-do run { target sh*-*-* } } */
 /* { dg-do compile } */
+/* { dg-do run { target sh*-*-* } } */
 /* { dg-options "-B${srcdir}/gcc.dg --specs=foo.specs -tfoo" } */
 
 extern void abort(void);
diff --git a/gcc/testsuite/gcc.dg/tree-ssa/cswtch.c b/gcc/testsuite/gcc.dg/tree-ssa/cswtch.c
index 80f92f7..5737a0e 100644
--- a/gcc/testsuite/gcc.dg/tree-ssa/cswtch.c
+++ b/gcc/testsuite/gcc.dg/tree-ssa/cswtch.c
@@ -1,4 +1,3 @@
-/* { dg-do compile } */
 /* { dg-options "-O2 -fdump-tree-switchconv" } */
 /* { dg-do run } */
 
diff --git a/gcc/testsuite/gcc.dg/tree-ssa/predcom-2.c b/gcc/testsuite/gcc.dg/tree-ssa/predcom-2.c
index 7253921..0d92f8e 100644
--- a/gcc/testsuite/gcc.dg/tree-ssa/predcom-2.c
+++ b/gcc/testsuite/gcc.dg/tree-ssa/predcom-2.c
@@ -1,4 +1,3 @@
-/* { dg-do compile } */
 /* { dg-do run } */
 /* { dg-options "-O2 -funroll-loops --param max-unroll-times=8 -fpredictive-commoning -fdump-tree-pcom-details" } */
 
diff --git a/gcc/testsuite/gcc.dg/tree-ssa/predcom-4.c b/gcc/testsuite/gcc.dg/tree-ssa/predcom-4.c
index 3244c1d..382a464 100644
--- a/gcc/testsuite/gcc.dg/tree-ssa/predcom-4.c
+++ b/gcc/testsuite/gcc.dg/tree-ssa/predcom-4.c
@@ -1,4 +1,3 @@
-/* { dg-do compile } */
 /* { dg-do run } */
 /* { dg-options "-O2 -funroll-loops --param max-unroll-times=8 -fpredictive-commoning -fdump-tree-pcom-details" } */
 
diff --git a/gcc/testsuite/gcc.dg/tree-ssa/predcom-5.c b/gcc/testsuite/gcc.dg/tree-ssa/predcom-5.c
index 7ad0d79..a3ee1d9 100644
--- a/gcc/testsuite/gcc.dg/tree-ssa/predcom-5.c
+++ b/gcc/testsuite/gcc.dg/tree-ssa/predcom-5.c
@@ -1,4 +1,3 @@
-/* { dg-do compile } */
 /* { dg-do run } */
 /* { dg-options "-O2 -funroll-loops --param max-unroll-times=8 -fpredictive-commoning -fdump-tree-pcom-details" } */
 
diff --git a/gcc/testsuite/gcc.target/arc/mcrc.c b/gcc/testsuite/gcc.target/arc/mcrc.c
index d3780bb..a449bdd 100644
--- a/gcc/testsuite/gcc.target/arc/mcrc.c
+++ b/gcc/testsuite/gcc.target/arc/mcrc.c
@@ -1,4 +1,3 @@
-/* { dg-do compile } */
 /* { dg-options "-mcrc" } */
 /* { dg-do assemble } */
 
diff --git a/gcc/testsuite/gcc.target/arc/mlock.c b/gcc/testsuite/gcc.target/arc/mlock.c
index 3a8b050..e207f91 100644
--- a/gcc/testsuite/gcc.target/arc/mlock.c
+++ b/gcc/testsuite/gcc.target/arc/mlock.c
@@ -1,4 +1,3 @@
-/* { dg-do compile } */
 /* { dg-options "-mlock" } */
 /* { dg-do assemble } */
 
diff --git a/gcc/testsuite/gcc.target/arc/mmac-24.c b/gcc/testsuite/gcc.target/arc/mmac-24.c
index 30cb698..89da0b1 100644
--- a/gcc/testsuite/gcc.target/arc/mmac-24.c
+++ b/gcc/testsuite/gcc.target/arc/mmac-24.c
@@ -1,4 +1,3 @@
-/* { dg-do compile } */
 /* { dg-options "-mmac-24" } */
 /* { dg-do assemble } */
 
diff --git a/gcc/testsuite/gcc.target/arc/mrtsc.c b/gcc/testsuite/gcc.target/arc/mrtsc.c
index 31852a5..15cb939 100644
--- a/gcc/testsuite/gcc.target/arc/mrtsc.c
+++ b/gcc/testsuite/gcc.target/arc/mrtsc.c
@@ -1,4 +1,3 @@
-/* { dg-do compile } */
 /* { dg-options "-mrtsc" } */
 /* { dg-do assemble } */
 
diff --git a/gcc/testsuite/gcc.target/arc/mswape.c b/gcc/testsuite/gcc.target/arc/mswape.c
index 692e6a2..6d23bde 100644
--- a/gcc/testsuite/gcc.target/arc/mswape.c
+++ b/gcc/testsuite/gcc.target/arc/mswape.c
@@ -1,4 +1,3 @@
-/* { dg-do compile } */
 /* { dg-options "-mswape" } */
 /* { dg-do assemble } */
 
diff --git a/gcc/testsuite/gcc.target/arc/mxy.c b/gcc/testsuite/gcc.target/arc/mxy.c
index 1ecc34d..283daf0 100644
--- a/gcc/testsuite/gcc.target/arc/mxy.c
+++ b/gcc/testsuite/gcc.target/arc/mxy.c
@@ -1,4 +1,3 @@
-/* { dg-do compile } */
 /* { dg-options "-mxy" } */
 /* { dg-do assemble } */
 
-- 
2.3.0


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] Clean up tests where a later dg-do completely overrides another.
  2016-04-27  7:50 [PATCH] Clean up tests where a later dg-do completely overrides another Dominik Vogt
@ 2016-04-27  8:52 ` Bernd Schmidt
  2016-04-29  9:24 ` Andreas Krebbel
  2016-04-29 20:03 ` Rainer Orth
  2 siblings, 0 replies; 11+ messages in thread
From: Bernd Schmidt @ 2016-04-27  8:52 UTC (permalink / raw)
  To: vogt, gcc-patches, Andreas Krebbel

On 04/27/2016 09:50 AM, Dominik Vogt wrote:
> The attached patch cleans up some (mostly unnecessary) dg-do
> directives in the gcc.dg and gcc.target test cases.

Ok except...

> 	* gcc.dg/spec-options.c: Switch order of the two "dg-do run" so that
> 	the test ist actually "run" on sh*-*-*.  Order _does_ matter.

No commentary in ChangeLogs.


Bernd

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] Clean up tests where a later dg-do completely overrides another.
  2016-04-27  7:50 [PATCH] Clean up tests where a later dg-do completely overrides another Dominik Vogt
  2016-04-27  8:52 ` Bernd Schmidt
@ 2016-04-29  9:24 ` Andreas Krebbel
  2016-04-29 20:03 ` Rainer Orth
  2 siblings, 0 replies; 11+ messages in thread
From: Andreas Krebbel @ 2016-04-29  9:24 UTC (permalink / raw)
  To: vogt, gcc-patches

On 04/27/2016 09:50 AM, Dominik Vogt wrote:
> The attached patch cleans up some (mostly unnecessary) dg-do
> directives in the gcc.dg and gcc.target test cases.

Applied. Thanks!

-Andreas-


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] Clean up tests where a later dg-do completely overrides another.
  2016-04-27  7:50 [PATCH] Clean up tests where a later dg-do completely overrides another Dominik Vogt
  2016-04-27  8:52 ` Bernd Schmidt
  2016-04-29  9:24 ` Andreas Krebbel
@ 2016-04-29 20:03 ` Rainer Orth
  2016-04-29 23:56   ` Dominik Vogt
  2 siblings, 1 reply; 11+ messages in thread
From: Rainer Orth @ 2016-04-29 20:03 UTC (permalink / raw)
  To: vogt; +Cc: gcc-patches, Andreas Krebbel

Dominik Vogt <vogt@linux.vnet.ibm.com> writes:

> The attached patch cleans up some (mostly unnecessary) dg-do
> directives in the gcc.dg and gcc.target test cases.

This part

	* gcc.dg/spec-options.c: Switch order of the two "dg-do run" so that
	the test ist actually "run" on sh*-*-*.  Order _does_ matter.

caused

FAIL: gcc.dg/spec-options.c execution test

(almost?) everywhere: on i386-pc-solaris2.12 and x86_64-pc-linux-gnu at
least, the test was a compile test before and is now an execute test.

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] Clean up tests where a later dg-do completely overrides another.
  2016-04-29 20:03 ` Rainer Orth
@ 2016-04-29 23:56   ` Dominik Vogt
  2016-05-02 15:30     ` Jeff Law
  0 siblings, 1 reply; 11+ messages in thread
From: Dominik Vogt @ 2016-04-29 23:56 UTC (permalink / raw)
  To: Rainer Orth; +Cc: gcc-patches, Andreas Krebbel

On Fri, Apr 29, 2016 at 10:03:40PM +0200, Rainer Orth wrote:
> Dominik Vogt <vogt@linux.vnet.ibm.com> writes:
> 
> > The attached patch cleans up some (mostly unnecessary) dg-do
> > directives in the gcc.dg and gcc.target test cases.
> 
> This part
> 
> 	* gcc.dg/spec-options.c: Switch order of the two "dg-do run" so that
> 	the test ist actually "run" on sh*-*-*.  Order _does_ matter.

(We're talking about this diff)
>> -/* { dg-do run { target sh*-*-* } } */
>>  /* { dg-do compile } */
>> +/* { dg-do run { target sh*-*-* } } */

> caused
> 
> FAIL: gcc.dg/spec-options.c execution test
> 
> (almost?) everywhere: on i386-pc-solaris2.12 and x86_64-pc-linux-gnu at
> least, the test was a compile test before and is now an execute test.

Yeah, sorry, I really should have mentioned this but forgot about
it.  It's a bug in DejaGnu.  When it encounters a conditional
dg-do and the condition does not match, it *still* replaces the
do-action of a prior dg-do with the current one.  With DejaGnu
prior to 1.6, there are two possibilities.

  /* { dg-do run { target sh*-*-* } } */
  /* { dg-do compile } */

The "compile" always wins.  The test is just compiled on all
platforms and not run anywhere.  With

  /* { dg-do compile } */
  /* { dg-do run { target sh*-*-* } } */

The "run" wins and the test is compiled and run everywhere, even
on targets that do not match sh*-*-*.

The bug is fixed in DejaGnu-1.6 which has been released on the
15th of April.  This is the fix:

  http://git.savannah.gnu.org/gitweb/?p=dejagnu.git;a=commit;h=569f8718b534a2cd9511a7d640352eb0126ff492

(The patch could easily be backported to earlier DejaGnu
releases.)

I think it might be best to either update DejaGnu locally or to
live with the failure.  It really indicates a bug - in DejaGnu
though, not in Gcc.  However, there are some target specific test
cases that rely on multiple conditional dg-do to work properly
that are not executed as they should be (some stuff on Power and
another target that I can't remember; Mips?).  The only way to
deal with the situation properly is to upgrade DejaGnu.  Otherwise
you either have failing test cases or test cases don't do what the
test file says.

Maybe a comment should be added to the test case

  /* If this test is *run* (not just compiled) and therefore fails
     on non sh*-targets, this is because of a bug older DejaGnu
     versions.  This is fixed with DejaGnu-1.6.  */

Ciao

Dominik ^_^  ^_^

-- 

Dominik Vogt
IBM Germany

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] Clean up tests where a later dg-do completely overrides another.
  2016-04-29 23:56   ` Dominik Vogt
@ 2016-05-02 15:30     ` Jeff Law
  2016-05-02 16:24       ` Dominik Vogt
  0 siblings, 1 reply; 11+ messages in thread
From: Jeff Law @ 2016-05-02 15:30 UTC (permalink / raw)
  To: vogt, Rainer Orth, gcc-patches, Andreas Krebbel

On 04/29/2016 05:56 PM, Dominik Vogt wrote:
>
> Yeah, sorry, I really should have mentioned this but forgot about
> it.  It's a bug in DejaGnu.  When it encounters a conditional
> dg-do and the condition does not match, it *still* replaces the
> do-action of a prior dg-do with the current one.  With DejaGnu
> prior to 1.6, there are two possibilities.
>
>   /* { dg-do run { target sh*-*-* } } */
>   /* { dg-do compile } */
>
> The "compile" always wins.  The test is just compiled on all
> platforms and not run anywhere.  With
>
>   /* { dg-do compile } */
>   /* { dg-do run { target sh*-*-* } } */
>
> The "run" wins and the test is compiled and run everywhere, even
> on targets that do not match sh*-*-*.
>
> The bug is fixed in DejaGnu-1.6 which has been released on the
> 15th of April.  This is the fix:
>
>   http://git.savannah.gnu.org/gitweb/?p=dejagnu.git;a=commit;h=569f8718b534a2cd9511a7d640352eb0126ff492
>
> (The patch could easily be backported to earlier DejaGnu
> releases.)
>
> I think it might be best to either update DejaGnu locally or to
> live with the failure.  It really indicates a bug - in DejaGnu
> though, not in Gcc.  However, there are some target specific test
> cases that rely on multiple conditional dg-do to work properly
> that are not executed as they should be (some stuff on Power and
> another target that I can't remember; Mips?).  The only way to
> deal with the situation properly is to upgrade DejaGnu.  Otherwise
> you either have failing test cases or test cases don't do what the
> test file says.
>
> Maybe a comment should be added to the test case
>
>   /* If this test is *run* (not just compiled) and therefore fails
>      on non sh*-targets, this is because of a bug older DejaGnu
>      versions.  This is fixed with DejaGnu-1.6.  */
I think we have a couple issues now that are resolved if we step forward 
to a newer version of dejagnu.

Given dejagnu-1.6 was recently released, should we just bite the bullet 
and ask everyone to step forward?

jeff

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] Clean up tests where a later dg-do completely overrides another.
  2016-05-02 15:30     ` Jeff Law
@ 2016-05-02 16:24       ` Dominik Vogt
  2016-05-18 21:59         ` Jeff Law
  0 siblings, 1 reply; 11+ messages in thread
From: Dominik Vogt @ 2016-05-02 16:24 UTC (permalink / raw)
  To: Jeff Law; +Cc: Rainer Orth, gcc-patches, Andreas Krebbel

On Mon, May 02, 2016 at 09:29:50AM -0600, Jeff Law wrote:
> On 04/29/2016 05:56 PM, Dominik Vogt wrote:
> > ...
> >Maybe a comment should be added to the test case
> >
> >  /* If this test is *run* (not just compiled) and therefore fails
> >     on non sh*-targets, this is because of a bug older DejaGnu
> >     versions.  This is fixed with DejaGnu-1.6.  */
> I think we have a couple issues now that are resolved if we step
> forward to a newer version of dejagnu.
> 
> Given dejagnu-1.6 was recently released, should we just bite the
> bullet and ask everyone to step forward?

I'm all for that.  I've recently added s390 test cases that
require Dejagnu 1.6.  Apart from the discussed problem with
spec-options.c, there are a number of Power (and some other
target) test cases that do not work properly with older Dejagnu
version but would finally work (read: actually test something) if
the new version were required.

Ciao

Dominik ^_^  ^_^

-- 

Dominik Vogt
IBM Germany

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] Clean up tests where a later dg-do completely overrides another.
  2016-05-02 16:24       ` Dominik Vogt
@ 2016-05-18 21:59         ` Jeff Law
  2016-05-26  4:18           ` Mike Stump
  2016-05-28 20:47           ` Gerald Pfeifer
  0 siblings, 2 replies; 11+ messages in thread
From: Jeff Law @ 2016-05-18 21:59 UTC (permalink / raw)
  To: vogt, Rainer Orth, gcc-patches, Andreas Krebbel

On 05/02/2016 10:24 AM, Dominik Vogt wrote:
> On Mon, May 02, 2016 at 09:29:50AM -0600, Jeff Law wrote:
>> On 04/29/2016 05:56 PM, Dominik Vogt wrote:
>>> ...
>>> Maybe a comment should be added to the test case
>>>
>>>  /* If this test is *run* (not just compiled) and therefore fails
>>>     on non sh*-targets, this is because of a bug older DejaGnu
>>>     versions.  This is fixed with DejaGnu-1.6.  */
>> I think we have a couple issues now that are resolved if we step
>> forward to a newer version of dejagnu.
>>
>> Given dejagnu-1.6 was recently released, should we just bite the
>> bullet and ask everyone to step forward?
>
> I'm all for that.  I've recently added s390 test cases that
> require Dejagnu 1.6.  Apart from the discussed problem with
> spec-options.c, there are a number of Power (and some other
> target) test cases that do not work properly with older Dejagnu
> version but would finally work (read: actually test something) if
> the new version were required.
FWIW, Fedora 24 uses dejagnu-1.6.  Not sure about other distributions.

jeff

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] Clean up tests where a later dg-do completely overrides another.
  2016-05-18 21:59         ` Jeff Law
@ 2016-05-26  4:18           ` Mike Stump
  2016-05-28 20:47           ` Gerald Pfeifer
  1 sibling, 0 replies; 11+ messages in thread
From: Mike Stump @ 2016-05-26  4:18 UTC (permalink / raw)
  To: Jeff Law; +Cc: vogt, Rainer Orth, gcc-patches, Andreas Krebbel

On May 18, 2016, at 2:59 PM, Jeff Law <law@redhat.com> wrote:
> 
> On 05/02/2016 10:24 AM, Dominik Vogt wrote:
>> On Mon, May 02, 2016 at 09:29:50AM -0600, Jeff Law wrote:
>>> On 04/29/2016 05:56 PM, Dominik Vogt wrote:
>>>> ...
>>>> Maybe a comment should be added to the test case
>>>> 
>>>> /* If this test is *run* (not just compiled) and therefore fails
>>>>    on non sh*-targets, this is because of a bug older DejaGnu
>>>>    versions.  This is fixed with DejaGnu-1.6.  */
>>> I think we have a couple issues now that are resolved if we step
>>> forward to a newer version of dejagnu.
>>> 
>>> Given dejagnu-1.6 was recently released, should we just bite the
>>> bullet and ask everyone to step forward?

We can recommend 1.6...  Just I don't see the value in going out of our way to make pre-1.6 versions behave worse then they always have for existing test cases.  If people want to add a new test case that will in effect require 1.6 to behave nicely, that's fine, just don't break 99% of the existing test cases.

> FWIW, Fedora 24 uses dejagnu-1.6.  Not sure about other distributions.

Ubuntu 16.04:

$ runtest --version
Expect version is       5.45
Tcl version is          8.6
Framework version is    1.5.3

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] Clean up tests where a later dg-do completely overrides another.
  2016-05-18 21:59         ` Jeff Law
  2016-05-26  4:18           ` Mike Stump
@ 2016-05-28 20:47           ` Gerald Pfeifer
  1 sibling, 0 replies; 11+ messages in thread
From: Gerald Pfeifer @ 2016-05-28 20:47 UTC (permalink / raw)
  To: Jeff Law; +Cc: vogt, Rainer Orth, gcc-patches, Andreas Krebbel

On Wed, 18 May 2016, Jeff Law wrote:
> FWIW, Fedora 24 uses dejagnu-1.6.  Not sure about other distributions.

openSUSE Tumbleweed is on 1.5.3, but I'm pretty sure we can get 
that updated.  FreeBSD Ports are at 1.6.

IMHO, go ahead.

Gerald

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] Clean up tests where a later dg-do completely overrides another.
@ 2016-04-30 10:55 Bernd Edlinger
  0 siblings, 0 replies; 11+ messages in thread
From: Bernd Edlinger @ 2016-04-30 10:55 UTC (permalink / raw)
  To: Dominik Vogt, Andreas Krebbel; +Cc: gcc-patches, Rainer Orth

Hi,

nice bug, we should not test it in the gcc testsuite.
Could you just split the spec-options.c test case in one that
compiles everywhere, and one that executes only on target sh*-*-* ?


Bernd.

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2016-05-28 13:44 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-27  7:50 [PATCH] Clean up tests where a later dg-do completely overrides another Dominik Vogt
2016-04-27  8:52 ` Bernd Schmidt
2016-04-29  9:24 ` Andreas Krebbel
2016-04-29 20:03 ` Rainer Orth
2016-04-29 23:56   ` Dominik Vogt
2016-05-02 15:30     ` Jeff Law
2016-05-02 16:24       ` Dominik Vogt
2016-05-18 21:59         ` Jeff Law
2016-05-26  4:18           ` Mike Stump
2016-05-28 20:47           ` Gerald Pfeifer
2016-04-30 10:55 Bernd Edlinger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).