From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105415 invoked by alias); 2 May 2016 07:15:02 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 105360 invoked by uid 89); 2 May 2016 07:15:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=nest, loopauto1c, partition, UD:loop-auto-1.c X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 02 May 2016 07:14:44 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 59EB78553B; Mon, 2 May 2016 07:14:43 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-113-135.phx2.redhat.com [10.3.113.135]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u427Ef8W007414 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 2 May 2016 03:14:43 -0400 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id u427EdnX030289; Mon, 2 May 2016 09:14:40 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id u427Ecrt030288; Mon, 2 May 2016 09:14:38 +0200 Date: Mon, 02 May 2016 07:15:00 -0000 From: Jakub Jelinek To: Nathan Sidwell Cc: GCC Patches Subject: Re: [Openacc] Adjust automatic loop partitioning Message-ID: <20160502071438.GJ26501@tucnak.zalov.cz> Reply-To: Jakub Jelinek References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-IsSubscribed: yes X-SW-Source: 2016-05/txt/msg00027.txt.bz2 On Fri, Apr 29, 2016 at 10:00:43AM -0400, Nathan Sidwell wrote: > Jakub, > currently automatic loop partitioning assigns from the innermost loop > outwards -- that was the simplest thing to implement. A better algorithm is > to assign the outermost loop to the outermost available axis, and then > assign from the innermost loop outwards. That way we (generally) get gang > partitioning on the outermost loop. Just inside that we'll get > non-partitioned loops if the nest is too deep, and the two innermost nested > loops will get worker and vector partitioning. > > This patch has been on the gomp4 branch for a while. ok for trunk? > > nathan > 2016-04-29 Nathan Sidwell > > gcc/ > * omp-low.c (struct oacc_loop): Add 'inner' field. > (new_oacc_loop_raw): Initialize it to zero. > (oacc_loop_fixed_partitions): Initialize it. > (oacc_loop_auto_partitions): Partition outermost loop to outermost > available partitioning. > > gcc/testsuite/ > * c-c++-common/goacc/loop-auto-1.c: Adjust expected warnings. > > libgomp/ > * testsuite/libgomp.oacc-c-c++-common/loop-auto-1.c: Adjust > expected partitioning. Ok. Jakub