public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Samuel Thibault <samuel.thibault@gnu.org>
To: Svante Signell <svante.signell@gmail.com>
Cc: Eric Botcazou <ebotcazou@adacore.com>,
	gcc-patches@gcc.gnu.org,	Arnaud Charlet <charlet@adacore.com>,
	Matthias Klose <doko@debian.org>
Subject: Re: Please include ada-hurd.diff upstream (try2)
Date: Wed, 04 May 2016 15:34:00 -0000	[thread overview]
Message-ID: <20160504153407.GG2861@var.bordeaux.inria.fr> (raw)
In-Reply-To: <20160504152948.GF2861@var.bordeaux.inria.fr>

Samuel Thibault, on Wed 04 May 2016 17:29:48 +0200, wrote:
> The gcc-6 build failed. I see that one of the change is:
> 
> -   --  From: /usr/include/unistd.h __getpagesize or getpagesize??
> -   function Get_Page_Size return int;
> +   --  From: /usr/include/i386-gnu/bits/shm.h __getpagesize or getpagesize??
> +   function Get_Page_Size return size_t;
> +   function Get_Page_Size return Address;
> 
> Why using size_t and Address?  Other OSes use int, and the prototype for
> getpagesize is returning int.
> 
> Also, don't use the __ versions of the glibc functions, they are
> internal aliases, the API is without __.

I.e. the proposed change below.

Samuel


2016-05-04  Samuel Thibault  <samuel.thibault@ens-lyon.org>

* s-osinte-gnu.ads: Make Get_Page_Size return int, and make it use
getpagesize instead of __getpagesize.

--- a/src/gcc/ada/s-osinte-gnu.ads
+++ b/src/gcc/ada/s-osinte-gnu.ads
@@ -344,10 +344,9 @@ package System.OS_Interface is
    --  returns the stack base of the specified thread. Only call this function
    --  when Stack_Base_Available is True.
 
-   --  From: /usr/include/i386-gnu/bits/shm.h __getpagesize or getpagesize??
-   function Get_Page_Size return size_t;
-   function Get_Page_Size return Address;
-   pragma Import (C, Get_Page_Size, "__getpagesize");
+   --  From: /usr/include/i386-gnu/bits/shm.h
+   function Get_Page_Size return int;
+   pragma Import (C, Get_Page_Size, "getpagesize");
    --  Returns the size of a page
 
    --  From /usr/include/i386-gnu/bits/mman.h

  reply	other threads:[~2016-05-04 15:34 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-01 23:42 Svante Signell
2016-03-07  5:22 ` Matthias Klose
2016-03-16 10:08 ` Eric Botcazou
2016-03-16 10:41   ` Svante Signell
2016-03-16 10:54     ` Eric Botcazou
2016-03-16 11:15       ` Svante Signell
2016-03-16 11:19         ` Arnaud Charlet
2016-03-16 21:55       ` Svante Signell
2016-03-17  7:51         ` Arnaud Charlet
2016-03-31  9:52           ` Svante Signell
2016-04-19  6:49             ` Svante Signell
2016-04-19  8:30               ` Arnaud Charlet
2016-04-25  9:22                 ` Svante Signell
2016-04-25  9:50                   ` Arnaud Charlet
2016-04-25 10:28                     ` Svante Signell
2016-04-25 10:31                       ` Arnaud Charlet
2016-04-27  7:41                       ` Eric Botcazou
2016-04-27  8:06                         ` Svante Signell
2016-05-04 15:29                           ` Samuel Thibault
2016-05-04 15:34                             ` Samuel Thibault [this message]
2016-05-04 16:02                               ` Arnaud Charlet
2016-05-04 16:43                               ` Svante Signell
2016-05-04 17:43                                 ` Svante Signell
2016-05-04 21:06                                   ` Samuel Thibault
2016-05-04 21:25                                     ` Svante Signell
2016-05-04 21:28                                       ` Samuel Thibault
2016-05-04 19:17                               ` Eric Botcazou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160504153407.GG2861@var.bordeaux.inria.fr \
    --to=samuel.thibault@gnu.org \
    --cc=charlet@adacore.com \
    --cc=doko@debian.org \
    --cc=ebotcazou@adacore.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=svante.signell@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).