From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105049 invoked by alias); 10 May 2016 11:40:50 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 105000 invoked by uid 89); 10 May 2016 11:40:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1101 X-HELO: mail-qg0-f68.google.com Received: from mail-qg0-f68.google.com (HELO mail-qg0-f68.google.com) (209.85.192.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 10 May 2016 11:40:48 +0000 Received: by mail-qg0-f68.google.com with SMTP id e35so578939qge.1 for ; Tue, 10 May 2016 04:40:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=qCU9uoS83dUHvL1GJjIjPAGTfo4BzAFf2iuDDE8+6qk=; b=jM13Ns35GTEYE9MIit/6OE+kRr0zyCKkPOoFSwktkAqhVUmw7KSoW8OSm1zC8khFui 7zFwNGqAxuYGKdmQIzE7WVcO8IcStpiltrtzZ6elb5vqPKogDKncZITbsPmYc843ww2v IspB2NDI1YsNx5CK32hFhnmuLuVWFQiSW5etO9gc5BTUk2zmwv1r97rX8gqv+yAJ13p4 e+i2pbBvUAevFElfFdNKfRrVzuaYHsfMdbb6hq474q6QxV+o0i9rlCjRwZxdCixOdL1D H4CKyHfqB95CJZLq7t5+tWIq/7qP2eRS97tQqUE25ccPgNfbf4G6i5SntXPNVjXdnB81 xUng== X-Gm-Message-State: AOPr4FX7qQ0H6DogKss9L73u/ukR3T0GTscI0xS21jMYZ4E+err0rxSk2QkKs1NtEhZJlA== X-Received: by 10.140.98.175 with SMTP id o44mr41565445qge.46.1462880446572; Tue, 10 May 2016 04:40:46 -0700 (PDT) Received: from msticlxl57.ims.intel.com (irdmzpr02-ext.ir.intel.com. [192.198.151.37]) by smtp.gmail.com with ESMTPSA id n123sm660424qhc.37.2016.05.10.04.40.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 May 2016 04:40:45 -0700 (PDT) Date: Tue, 10 May 2016 11:40:00 -0000 From: Kirill Yukhin To: Jakub Jelinek Cc: Uros Bizjak , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Don't emit AVX512DQ insns for -mavx512vl -mno-avx512dq (PR target/70927, take 2) Message-ID: <20160510113939.GA20527@msticlxl57.ims.intel.com> References: <20160503182328.GF26501@tucnak.zalov.cz> <20160509164350.GD28550@tucnak.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160509164350.GD28550@tucnak.redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2016-05/txt/msg00690.txt.bz2 Hi Jakub, On 09 May 18:43, Jakub Jelinek wrote: > On Tue, May 03, 2016 at 08:23:28PM +0200, Jakub Jelinek wrote: > > While working on a patch I'm going to post momentarily, I've noticed that > > we sometimes emit AVX512DQ specific instructions even when avx512dq is not > > enabled (in particular, EVEX andnps and andnpd are AVX512DQ plus if > > they have 128-bit or 256-bit arguments, also AVX512VL). > > > > I'm not 100% happy about the patch, because (pre-existing issue) > > get_attr_mode doesn't reflect that the insn is in that not a vector float > > insn, but perhaps we'd need to use another alternative and some ugly > > conditionals in mode attribute for that case. > > > > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk and > > after a while 6.2, or do you prefer some other fix? > > Here is perhaps better variant, which handles stuff in the mode attribute. > Now also with testcases. > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? OK. -- Thanks, K