public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 3/3] function: Restructure *logue insertion
Date: Thu, 19 May 2016 08:04:00 -0000	[thread overview]
Message-ID: <20160519080421.GA8443@gate.crashing.org> (raw)
In-Reply-To: <70c67b8f39aca9cf574f617fbfce43b93e2560ff.1463428211.git.segher@kernel.crashing.org>

On Tue, May 17, 2016 at 01:09:11AM +0000, Segher Boessenkool wrote:
> This patch restructures how the prologues/epilogues are inserted.  Sibcalls
> that run without prologue are now handled in shrink-wrap.c; it communicates
> what is already handled by setting the EDGE_IGNORE flag.  The
> try_shrink_wrapping function then doesn't need to be passed the bb_flags
> anymore.

> 2016-05-16  Segher Boessenkool  <segher@kernel.crashing.org>
> 
> 	* function.c (make_epilogue_seq): Remove epilogue_end parameter.
> 	(thread_prologue_and_epilogue_insns): Remove bb_flags.  Restructure
> 	code.  Ignore sibcalls on EDGE_IGNORE edges.
> 	* shrink-wrap.c (handle_simple_exit): New function.  Set EDGE_IGNORE
> 	on edges for sibcalls that run without prologue.  The rest of the
> 	function is combined from...
> 	(fix_fake_fallthrough_edge): ... this, and ...
> 	(try_shrink_wrapping): ... a part of this.  Remove the bb_with
> 	function argument, make it a local variable.

As promised in the 1/3 subthread, I looked at the difference of building
Linux with and without (only) this patch.  With the 24 (of 30) targets
that build, I saw no generated code differences.  There also are no
testsuite regressions on powerpc, powerpc64, powerpc64le, or x86_64.


Segher

  reply	other threads:[~2016-05-19  8:04 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-17  1:09 [PATCH 1/3] function: Do the CLEANUP_EXPENSIVE after shrink-wrapping, not before Segher Boessenkool
2016-05-17  1:09 ` [PATCH 2/3] function: Factor out make_*logue_seq Segher Boessenkool
2016-05-17 20:35   ` Jeff Law
2016-05-18 17:17   ` H.J. Lu
2016-05-18 18:11     ` Segher Boessenkool
2016-05-18 18:20       ` H.J. Lu
2016-05-18 18:24         ` H.J. Lu
2016-05-18 18:35         ` Segher Boessenkool
2016-05-18 22:13           ` Segher Boessenkool
2016-05-19  7:16             ` Jakub Jelinek
2016-05-19  7:28               ` Segher Boessenkool
2016-05-19  7:41                 ` Jakub Jelinek
2016-05-19 17:20               ` Jeff Law
2016-05-17  1:09 ` [PATCH 3/3] function: Restructure *logue insertion Segher Boessenkool
2016-05-19  8:04   ` Segher Boessenkool [this message]
2016-05-19 22:00   ` Jeff Law
2016-05-19 22:20     ` Segher Boessenkool
2016-05-20  9:28       ` Thomas Schwinge
2016-05-20 13:21         ` Thomas Schwinge
2016-05-20 14:47           ` Nathan Sidwell
2016-05-20 15:35             ` Segher Boessenkool
2016-05-20 21:27         ` Segher Boessenkool
2016-05-17  8:06 ` [PATCH 1/3] function: Do the CLEANUP_EXPENSIVE after shrink-wrapping, not before Eric Botcazou
2016-05-17  8:47   ` Segher Boessenkool
2016-05-17  9:08     ` Eric Botcazou
2016-05-17  9:18       ` Segher Boessenkool
2016-05-17 22:23         ` Segher Boessenkool
2016-05-17 22:34           ` Eric Botcazou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160519080421.GA8443@gate.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).