From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4759 invoked by alias); 19 May 2016 22:20:54 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 4745 invoked by uid 89); 19 May 2016 22:20:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=will!, Hx-languages-length:1262, watch X-HELO: gate.crashing.org Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 19 May 2016 22:20:51 +0000 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.13.8) with ESMTP id u4JMKlLJ004009; Thu, 19 May 2016 17:20:47 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id u4JMKl7I004008; Thu, 19 May 2016 17:20:47 -0500 Date: Thu, 19 May 2016 22:20:00 -0000 From: Segher Boessenkool To: Jeff Law Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH 3/3] function: Restructure *logue insertion Message-ID: <20160519222046.GE8443@gate.crashing.org> References: <213485283eede9da12b217737d95fc8f5c4be442.1463428211.git.segher@kernel.crashing.org> <70c67b8f39aca9cf574f617fbfce43b93e2560ff.1463428211.git.segher@kernel.crashing.org> <5236cc2d-fb6b-351d-2c9f-1c1419ddcf8a@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5236cc2d-fb6b-351d-2c9f-1c1419ddcf8a@redhat.com> User-Agent: Mutt/1.4.2.3i X-IsSubscribed: yes X-SW-Source: 2016-05/txt/msg01581.txt.bz2 On Thu, May 19, 2016 at 04:00:22PM -0600, Jeff Law wrote: > > * function.c (make_epilogue_seq): Remove epilogue_end parameter. > > (thread_prologue_and_epilogue_insns): Remove bb_flags. Restructure > > code. Ignore sibcalls on EDGE_IGNORE edges. > > * shrink-wrap.c (handle_simple_exit): New function. Set EDGE_IGNORE > > on edges for sibcalls that run without prologue. The rest of the > > function is combined from... > > (fix_fake_fallthrough_edge): ... this, and ... > > (try_shrink_wrapping): ... a part of this. Remove the bb_with > > function argument, make it a local variable. > For some reason I found this patch awful to walk through. In > retrospect, it might have been better break this down further. Not > because it's conceptually difficult to follow, but because the diffs > themselves are difficult to read. Yeah, I should have realised that because the changelog was hard to write. > I kept slicing out hunks when I could pair up the original code to its > new functional equivalent and hunks which were just "fluff" and kept > iterating until there was nothing left that seemed unreasonable. > > OK for the trunk, but please watch closely for any fallout. Thanks, and I will! Segher