From: Andi Kleen <andi@firstfloor.org>
To: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
Cc: Andi Kleen <andi@firstfloor.org>,
gcc-patches@gcc.gnu.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 3/5] Run profile feedback tests with autofdo
Date: Sat, 21 May 2016 21:37:00 -0000 [thread overview]
Message-ID: <20160521213703.GW13997@two.firstfloor.org> (raw)
In-Reply-To: <6632756C-F55C-45C2-ADE6-D848DD6DE7F1@gmail.com>
On Sat, May 21, 2016 at 10:55:21PM +0200, Bernhard Reutner-Fischer wrote:
> >@@ -313,6 +332,7 @@ proc profopt-execute { src } {
> > # valid, by running it after dg-additional-files-options.
> > foreach ext $prof_ext {
> > profopt-target-cleanup $tmpdir $base $ext
> >+ profopt-target-cleanup $tmpdir perf data
> > }
>
> I think I've asked this before.. Why do you need to run cleanup of perf data in this loop (and not outside)?
> Also why the asymmetry ...
perf generates a backup file if a file already exists.
> >@@ -399,7 +460,9 @@ proc profopt-execute { src } {
> > # Remove the profiling data files.
> > foreach ext $prof_ext {
> > profopt-target-cleanup $tmpdir $base $ext
> >+ profopt-target-cleanup $tmpdir perf data
> > }
> >+ file delete "perf.data"
The extra one is not needed. I'll remove it.
Thanks
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2016-05-21 21:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-21 16:37 Updated autofdo bootstrap and testing patches Andi Kleen
2016-05-21 16:37 ` [PATCH 1/5] Add gcc-auto-profile script Andi Kleen
2016-05-21 16:37 ` [PATCH 2/5] Don't cause ICEs when auto profile file is not found with checking Andi Kleen
2016-05-21 16:37 ` [PATCH 3/5] Run profile feedback tests with autofdo Andi Kleen
2016-05-21 16:38 ` [PATCH 4/5] Add make autoprofiledbootstrap Andi Kleen
2016-05-21 16:37 ` [PATCH 5/5] workaround for PR70427 Andi Kleen
2016-05-30 9:16 ` Jan Hubicka
2016-05-30 9:46 ` Andi Kleen
2016-05-21 20:55 ` [PATCH 3/5] Run profile feedback tests with autofdo Bernhard Reutner-Fischer
2016-05-21 21:37 ` Andi Kleen [this message]
2016-05-21 20:42 ` [PATCH 2/5] Don't cause ICEs when auto profile file is not found with checking Bernhard Reutner-Fischer
2016-05-30 8:49 ` Jan Hubicka
2016-05-21 18:02 ` [PATCH 1/5] Add gcc-auto-profile script Bernhard Reutner-Fischer
2016-05-30 9:37 ` Jan Hubicka
2016-05-30 9:38 ` Andi Kleen
2016-05-26 17:08 ` [PING] Re: Updated autofdo bootstrap and testing patches Andi Kleen
2016-05-30 8:22 ` [PING^2] " Andi Kleen
2016-06-04 4:12 ` [PING^3] " Andi Kleen
2016-06-06 9:55 ` [PING^2] " Bernd Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160521213703.GW13997@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=ak@linux.intel.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rep.dot.nop@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).