From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2092 invoked by alias); 21 May 2016 21:37:19 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 2083 invoked by uid 89); 21 May 2016 21:37:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: one.firstfloor.org Received: from one.firstfloor.org (HELO one.firstfloor.org) (193.170.194.197) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sat, 21 May 2016 21:37:08 +0000 Received: by one.firstfloor.org (Postfix, from userid 503) id 268EA8717B; Sat, 21 May 2016 23:37:04 +0200 (CEST) Date: Sat, 21 May 2016 21:37:00 -0000 From: Andi Kleen To: Bernhard Reutner-Fischer Cc: Andi Kleen , gcc-patches@gcc.gnu.org, Andi Kleen Subject: Re: [PATCH 3/5] Run profile feedback tests with autofdo Message-ID: <20160521213703.GW13997@two.firstfloor.org> References: <1463848586-19259-1-git-send-email-andi@firstfloor.org> <1463848586-19259-2-git-send-email-andi@firstfloor.org> <1463848586-19259-3-git-send-email-andi@firstfloor.org> <1463848586-19259-4-git-send-email-andi@firstfloor.org> <6632756C-F55C-45C2-ADE6-D848DD6DE7F1@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6632756C-F55C-45C2-ADE6-D848DD6DE7F1@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2016-05/txt/msg01727.txt.bz2 On Sat, May 21, 2016 at 10:55:21PM +0200, Bernhard Reutner-Fischer wrote: > >@@ -313,6 +332,7 @@ proc profopt-execute { src } { > > # valid, by running it after dg-additional-files-options. > > foreach ext $prof_ext { > > profopt-target-cleanup $tmpdir $base $ext > >+ profopt-target-cleanup $tmpdir perf data > > } > > I think I've asked this before.. Why do you need to run cleanup of perf data in this loop (and not outside)? > Also why the asymmetry ... perf generates a backup file if a file already exists. > >@@ -399,7 +460,9 @@ proc profopt-execute { src } { > > # Remove the profiling data files. > > foreach ext $prof_ext { > > profopt-target-cleanup $tmpdir $base $ext > >+ profopt-target-cleanup $tmpdir perf data > > } > >+ file delete "perf.data" The extra one is not needed. I'll remove it. Thanks -Andi -- ak@linux.intel.com -- Speaking for myself only.