From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: Andre.SimoesDiasVieira@arm.com ("Andre Vieira (lists)")
Cc: gcc-patches@gcc.gnu.org, law@redhat.com
Subject: Re: [RFA 1/2]: Don't ignore target_header_dir when deciding inhibit_libc
Date: Fri, 27 May 2016 16:31:00 -0000 [thread overview]
Message-ID: <20160527145135.7E3C0FD3E@oc7340732750.ibm.com> (raw)
In-Reply-To: <5745DB7E.2020806@arm.com> from "Andre Vieira (lists)" at May 25, 2016 06:06:06 PM
Andre Vieira (lists) wrote:
> On 07/04/16 10:30, Andre Vieira (lists) wrote:
> > On 17/03/16 16:33, Andre Vieira (lists) wrote:
> >> On 23/10/15 12:31, Bernd Schmidt wrote:
> >>> On 10/12/2015 11:58 AM, Ulrich Weigand wrote:
> >>>>
> >>>> Index: gcc/configure.ac
> >>>> ===================================================================
> >>>> --- gcc/configure.ac (revision 228530)
> >>>> +++ gcc/configure.ac (working copy)
> >>>> @@ -1993,7 +1993,7 @@ elif test "x$TARGET_SYSTEM_ROOT" != x; t
> >>>> fi
> >>>>
> >>>> if test x$host != x$target || test "x$TARGET_SYSTEM_ROOT" != x; then
> >>>> - if test "x$with_headers" != x; then
> >>>> + if test "x$with_headers" != x && test "x$with_headers" != xyes; then
> >>>> target_header_dir=$with_headers
> >>>> elif test "x$with_sysroot" = x; then
> >>>>
> >>>> target_header_dir="${test_exec_prefix}/${target_noncanonical}/sys-include"
> >>>>
> >>>
> >>> I'm missing the beginning of this conversation, but this looks like a
> >>> reasonable change (avoiding target_header_dir=yes for --with-headers).
> >>> So, approved.
> >>>
> >>>
> >>> Bernd
> >>>
> >> Hi there,
> >>
> >> I was wondering why this never made it to trunk. I am currently running
> >> into an issue that this patch would fix.
Seems I never actually checked this in, even though it was approved.
Thanks for the reminder, I've now checked the patch in.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2016-05-27 14:51 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 21:40 Hans-Peter Nilsson
2014-09-12 17:50 ` Ping: " Hans-Peter Nilsson
2014-09-19 6:25 ` Jeff Law
2014-09-23 21:21 ` Thomas Schwinge
2014-09-23 22:30 ` Hans-Peter Nilsson
2015-10-06 14:04 ` Ulrich Weigand
2015-10-06 14:44 ` Hans-Peter Nilsson
2015-10-06 15:25 ` Ulrich Weigand
2015-10-06 16:31 ` Hans-Peter Nilsson
2015-10-06 16:56 ` Ulrich Weigand
2015-10-06 17:28 ` Hans-Peter Nilsson
2015-10-07 15:32 ` Ulrich Weigand
2015-10-07 17:18 ` Hans-Peter Nilsson
2015-10-08 16:52 ` Ulrich Weigand
2015-10-09 2:34 ` Hans-Peter Nilsson
2015-10-12 9:58 ` Ulrich Weigand
2015-10-12 10:58 ` Hans-Peter Nilsson
2015-10-23 11:54 ` Bernd Schmidt
2016-03-17 16:35 ` Andre Vieira (lists)
2016-03-30 16:14 ` [arm-embedded]: " Andre Vieira (lists)
2016-04-07 9:31 ` [RFA 1/2]: " Andre Vieira (lists)
2016-05-25 19:37 ` Andre Vieira (lists)
2016-05-27 16:31 ` Ulrich Weigand [this message]
2016-09-09 15:04 ` [GCC-6][RFA " Andre Vieira (lists)
2016-10-17 16:05 ` Andre Vieira (lists)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160527145135.7E3C0FD3E@oc7340732750.ibm.com \
--to=uweigand@de.ibm.com \
--cc=Andre.SimoesDiasVieira@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=law@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).