From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 33119 invoked by alias); 30 May 2016 00:34:16 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 33108 invoked by uid 89); 30 May 2016 00:34:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=autofdo X-HELO: atrey.karlin.mff.cuni.cz Received: from atrey.karlin.mff.cuni.cz (HELO atrey.karlin.mff.cuni.cz) (195.113.26.193) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 30 May 2016 00:34:05 +0000 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 4018) id BE82C823D1; Mon, 30 May 2016 02:34:03 +0200 (CEST) Date: Mon, 30 May 2016 09:16:00 -0000 From: Jan Hubicka To: Andi Kleen Cc: gcc-patches@gcc.gnu.org, Andi Kleen Subject: Re: [PATCH 5/5] workaround for PR70427 Message-ID: <20160530003403.GB7778@atrey.karlin.mff.cuni.cz> References: <1463848586-19259-1-git-send-email-andi@firstfloor.org> <1463848586-19259-2-git-send-email-andi@firstfloor.org> <1463848586-19259-3-git-send-email-andi@firstfloor.org> <1463848586-19259-4-git-send-email-andi@firstfloor.org> <1463848586-19259-5-git-send-email-andi@firstfloor.org> <1463848586-19259-6-git-send-email-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1463848586-19259-6-git-send-email-andi@firstfloor.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2016-05/txt/msg02309.txt.bz2 > From: Andi Kleen > > This makes autofdo bootstrap not crash. > > This is probably not the right fix, but for now it works for me. > Not for submission. > --- > gcc/ipa-profile.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/gcc/ipa-profile.c b/gcc/ipa-profile.c > index da17bcd..c7d7792 100644 > --- a/gcc/ipa-profile.c > +++ b/gcc/ipa-profile.c > @@ -201,6 +201,8 @@ ipa_profile_generate_summary (void) > if (h->hvalue.counters[2]) > { > struct cgraph_edge * e = node->get_edge (stmt); > + if (!e) > + continue; This is odd. I do not think auto-fdo produces indirect call histograms and the edges should be present here. Do you know from where the histogram is created? Honza > if (e && !e->indirect_unknown_callee) > continue; > e->indirect_info->common_target_id > -- > 2.8.2