From: Jan Hubicka <hubicka@ucw.cz>
To: Andi Kleen <andi@firstfloor.org>
Cc: gcc-patches@gcc.gnu.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 1/5] Add gcc-auto-profile script
Date: Mon, 30 May 2016 09:37:00 -0000 [thread overview]
Message-ID: <20160530003906.GC7778@atrey.karlin.mff.cuni.cz> (raw)
In-Reply-To: <1463848586-19259-2-git-send-email-andi@firstfloor.org>
Andi,
thanks a lot for working on the auto-fdo bootstrap. It is badly needed to
have some coverage for this feature. I don't think I can approve the
build machinery changes.
> From: Andi Kleen <ak@linux.intel.com>
>
> Using autofdo is currently something difficult. It requires using the
> model specific branches taken event, which differs on different CPUs.
> The example shown in the manual requires a special patched version of
> perf that is non standard, and also will likely not work everywhere.
>
> This patch adds a new gcc-auto-profile script that figures out the
> correct event and runs perf.
>
> This is needed to actually make use of autofdo in a generic way
> in the build system and in the test suite.
>
> Since maintaining the script would be somewhat tedious (needs changes
> every time a new CPU comes out) I auto generated it from the online
> Intel event database. The script to do that is in contrib and can be
> rerun.
I guess we need to figure out how to ship this to users. At the moment
the script will tell you to rebuild when it meets new CPU, but it reffers
to gcc sources which is not the best place.
Also the script should insteall when it is documented in invoke.texi
What happens when you ahve wrong perf?
Honza
next prev parent reply other threads:[~2016-05-30 0:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-21 16:37 Updated autofdo bootstrap and testing patches Andi Kleen
2016-05-21 16:37 ` [PATCH 1/5] Add gcc-auto-profile script Andi Kleen
2016-05-21 16:37 ` [PATCH 2/5] Don't cause ICEs when auto profile file is not found with checking Andi Kleen
2016-05-21 16:37 ` [PATCH 3/5] Run profile feedback tests with autofdo Andi Kleen
2016-05-21 16:38 ` [PATCH 4/5] Add make autoprofiledbootstrap Andi Kleen
2016-05-21 16:37 ` [PATCH 5/5] workaround for PR70427 Andi Kleen
2016-05-30 9:16 ` Jan Hubicka
2016-05-30 9:46 ` Andi Kleen
2016-05-21 20:55 ` [PATCH 3/5] Run profile feedback tests with autofdo Bernhard Reutner-Fischer
2016-05-21 21:37 ` Andi Kleen
2016-05-21 20:42 ` [PATCH 2/5] Don't cause ICEs when auto profile file is not found with checking Bernhard Reutner-Fischer
2016-05-30 8:49 ` Jan Hubicka
2016-05-21 18:02 ` [PATCH 1/5] Add gcc-auto-profile script Bernhard Reutner-Fischer
2016-05-30 9:37 ` Jan Hubicka [this message]
2016-05-30 9:38 ` Andi Kleen
2016-05-26 17:08 ` [PING] Re: Updated autofdo bootstrap and testing patches Andi Kleen
2016-05-30 8:22 ` [PING^2] " Andi Kleen
2016-06-04 4:12 ` [PING^3] " Andi Kleen
2016-06-06 9:55 ` [PING^2] " Bernd Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160530003906.GC7778@atrey.karlin.mff.cuni.cz \
--to=hubicka@ucw.cz \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).