public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Michael Meissner <meissner@linux.vnet.ibm.com>,
	gcc-patches@gcc.gnu.org,
	       David Edelsohn <dje.gcc@gmail.com>,
	       Bill Schmidt <wschmidt@linux.vnet.ibm.com>
Subject: Re: [PATCH], Add PowerPC ISA 3.0 MTVSRDD support
Date: Wed, 01 Jun 2016 18:37:00 -0000	[thread overview]
Message-ID: <20160601183654.GB31838@gate.crashing.org> (raw)
In-Reply-To: <20160531234955.GA5527@ibm-tiger.the-meissners.org>

On Tue, May 31, 2016 at 07:49:55PM -0400, Michael Meissner wrote:
> This patch adds support to issue the MTVSRDD on 64-bit ISA 3.0 systems when the
> compiler has a 64-bit value in a GPR, and it wants to create a vector that has
> the 64-bit value in both sides of the 128-bit value.

>  ;; V2DF/V2DI splat
>  (define_insn "vsx_splat_<mode>"
> -  [(set (match_operand:VSX_D 0 "vsx_register_operand" "=wd,wd,wd,?<VSa>,?<VSa>,?<VSa>")
> +  [(set (match_operand:VSX_D 0 "vsx_register_operand" "=<VSa>,<VSa>,we")
>  	(vec_duplicate:VSX_D
> -	 (match_operand:<VS_scalar> 1 "splat_input_operand" "<VS_64reg>,f,Z,<VSa>,<VSa>,Z")))]
> +	 (match_operand:<VS_scalar> 1 "splat_input_operand" "<VS_64reg>,Z,r")))]
>    "VECTOR_MEM_VSX_P (<MODE>mode)"
>    "@
>     xxpermdi %x0,%x1,%x1,0
> -   xxpermdi %x0,%x1,%x1,0
>     lxvdsx %x0,%y1
> -   xxpermdi %x0,%x1,%x1,0
> -   xxpermdi %x0,%x1,%x1,0
> -   lxvdsx %x0,%y1"
> -  [(set_attr "type" "vecperm,vecperm,vecload,vecperm,vecperm,vecload")])
> +   mtvsrdd %x0,%1,%1"
> +  [(set_attr "type" "vecperm,vecload,mftgpr")])

It should use "b" instead of "r" for the mtvsrdd case.

Okay for trunk with that change, after retesting.  Okay for 6 later, too.

Thanks,


Segher

           reply	other threads:[~2016-06-01 18:37 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20160531234955.GA5527@ibm-tiger.the-meissners.org>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160601183654.GB31838@gate.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=dje.gcc@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=meissner@linux.vnet.ibm.com \
    --cc=wschmidt@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).