From: Jakub Jelinek <jakub@redhat.com>
To: Dhole <dhole@openmailbox.org>,
Bernd Schmidt <bschmidt@redhat.com>,
Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>,
Mike Stump <mikestump@comcast.net>
Cc: Eduard Sanou <eduardsanou@openmailbox.org>,
Matthias Klose <doko@ubuntu.com>,
gcc-patches@gcc.gnu.org
Subject: Fix up dg-set-compiler-env-var
Date: Thu, 02 Jun 2016 12:19:00 -0000 [thread overview]
Message-ID: <20160602121905.GE28550@tucnak.redhat.com> (raw)
In-Reply-To: <20160513170930.GN17273@panther>
Hi!
On Fri, May 13, 2016 at 07:09:30PM +0200, Dhole wrote:
> --- a/gcc/testsuite/lib/gcc-dg.exp
> +++ b/gcc/testsuite/lib/gcc-dg.exp
> @@ -451,6 +451,38 @@ proc restore-target-env-var { } {
> }
> }
>
> +proc dg-set-compiler-env-var { args } {
I've noticed last night pr61861.c FAIL in i686-linux bootstrap,
easily reproduceable with short:
make check-gcc RUNTESTFLAGS='cpp.exp=source_date* dg.exp=pr61861.c'
The problem is that in cleanup-after-saved-dg-test, there are missing global
directives, so when it tests/uses the set_compiler_env_var and
saved_compiler_env_var vars to see if it should call
restore-compiler-env-var, it uses local (non-existing) vars instead and
never restores the env var.
Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok of
trunk?
2016-06-02 Jakub Jelinek <jakub@redhat.com>
* lib/gcc-dg.exp (cleanup-after-saved-dg-test): Add missing
global set_compiler_env_var and global saved_compiler_env_var.
--- gcc/testsuite/lib/gcc-dg.exp.jj 2016-06-01 19:16:51.000000000 +0200
+++ gcc/testsuite/lib/gcc-dg.exp 2016-06-02 11:56:54.429137894 +0200
@@ -895,6 +895,8 @@ if { [info procs saved-dg-test] == [list
global shouldfail
global testname_with_flags
global set_target_env_var
+ global set_compiler_env_var
+ global saved_compiler_env_var
global keep_saved_temps_suffixes
global multiline_expected_outputs
Jakub
next prev parent reply other threads:[~2016-06-02 12:19 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 12:28 Allow embedded timestamps by C/C++ macros to be set externally (3) Dhole
2016-04-18 13:05 ` Markus Trippelsdorf
2016-05-03 14:44 ` Dhole
2016-05-03 14:53 ` Markus Trippelsdorf
2016-04-25 10:16 ` Bernd Schmidt
2016-04-26 21:29 ` Dhole
2016-04-26 23:33 ` Bernd Schmidt
2016-04-27 15:57 ` Dhole
2016-04-28 9:20 ` Matthias Klose
2016-04-28 9:22 ` Bernd Schmidt
2016-04-28 10:08 ` Jakub Jelinek
2016-04-28 10:31 ` Bernd Schmidt
2016-04-28 10:35 ` Jakub Jelinek
2016-04-28 13:10 ` Bernd Schmidt
2016-04-28 13:14 ` Jakub Jelinek
2016-04-28 18:31 ` Dhole
2016-04-29 7:17 ` Jakub Jelinek
2016-05-05 23:28 ` Eduard Sanou
2016-05-06 6:26 ` Andreas Schwab
2016-05-10 11:14 ` Dhole
2016-05-10 11:24 ` Andreas Schwab
2016-05-10 11:32 ` Bernd Schmidt
2016-05-10 15:51 ` Joseph Myers
2016-05-12 0:38 ` Dhole
2016-05-12 9:17 ` Bernd Schmidt
2016-05-13 17:11 ` Dhole
2016-05-23 23:00 ` Dhole
2016-05-24 16:45 ` Jeff Law
2016-06-01 16:29 ` Bernd Schmidt
2016-06-01 16:59 ` Matthias Klose
2016-06-02 13:01 ` Christophe Lyon
2016-06-02 13:05 ` Jakub Jelinek
2016-06-02 13:21 ` Christophe Lyon
2016-06-02 13:24 ` Jakub Jelinek
2016-06-02 14:50 ` Christophe Lyon
2016-06-02 15:04 ` Jakub Jelinek
2016-06-02 15:27 ` Bernd Schmidt
2016-06-02 15:30 ` Christophe Lyon
2016-06-02 12:19 ` Jakub Jelinek [this message]
2016-06-02 12:26 ` Fix up dg-set-compiler-env-var Bernd Schmidt
2016-06-02 12:33 ` Jakub Jelinek
2016-05-05 23:39 ` Allow embedded timestamps by C/C++ macros to be set externally (3) Dhole
2016-05-09 10:24 ` Bernd Schmidt
2016-05-09 10:38 ` Bernd Schmidt
2016-05-09 10:42 ` Jakub Jelinek
2016-05-09 11:01 ` Bernd Schmidt
2016-05-10 11:18 ` Dhole
2016-04-28 18:57 ` Martin Sebor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160602121905.GE28550@tucnak.redhat.com \
--to=jakub@redhat.com \
--cc=bschmidt@redhat.com \
--cc=dhole@openmailbox.org \
--cc=doko@ubuntu.com \
--cc=eduardsanou@openmailbox.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=mikestump@comcast.net \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).