public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jan Hubicka <hubicka@ucw.cz>
To: Richard Biener <rguenther@suse.de>
Cc: David Edelsohn <dje.gcc@gmail.com>,
	Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org>,
	GCC Patches <gcc-patches@gcc.gnu.org>,
	Jan Hubicka <hubicka@ucw.cz>,
	"William J. Schmidt" <wschmidt@linux.vnet.ibm.com>,
	Segher Boessenkool <segher@kernel.crashing.org>
Subject: Re: move increase_alignment from simple to regular ipa pass
Date: Thu, 02 Jun 2016 15:01:00 -0000	[thread overview]
Message-ID: <20160602150106.GA48112@kam.mff.cuni.cz> (raw)
In-Reply-To: <alpine.LSU.2.11.1606021454320.1493@t29.fhfr.qr>

> On Thu, 2 Jun 2016, David Edelsohn wrote:
> 
> > >>>>> Richard Biener wrote:
> > 
> > >> "This would mean the pass should get its own non-Optimization flag
> > >> initialized by targets where section anchors are usually used"
> > >> IIUC should we add a new option -fno-increase_alignment and gate the
> > >> pass on it ? Um sorry I didn't understand why targets
> > >> with section anchors (arm, aarch64, ppc) should initialize this option ?
> > >
> > > Currently the pass is only run for targets with section anchors (and there
> > > by default if they are enabled by default).  So it makes sense to
> > > run on those by default and the pass is not necessary on targets w/o
> > > section anchors as the vectorizer can easily adjust alignment itself on
> > > those.
> > 
> > PPC does not always enable section anchors -- it depends on the code
> > model.  Shouldn't this be tied to use of section anchors?
> 
> It effectively is with the patch by walking all functions to see if they
> have section anchors enabled.  That is unnecessary work for targets that

fsection-anchors                                                                
Common Report Var(flag_section_anchors)                                         
Access data in the same section from shared anchor points.                      

flag_section_anchors is not declared as Optimiation, so it can't be function
specific right now. It probably should because it is an optimization.  This
makes me wonder what happens when one function have anchors enabled and other
doesn't?  Probably anchroing or not anchoring the var will then depend on what
function comes first in the compilation order and then we will need to make
backend grok the case where static var is anchored but flag_section_anchors is
off.

I dunno what is the desired behaviour for LTOint together different code models.

Honza

> do not support section anchors at all, of course.
> 
> Richard.

  reply	other threads:[~2016-06-02 15:01 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-02 12:52 David Edelsohn
2016-06-02 12:57 ` Richard Biener
2016-06-02 15:01   ` Jan Hubicka [this message]
2016-06-03  7:57     ` Richard Biener
2016-06-03  8:05       ` Jan Hubicka
2016-06-07  8:34         ` Prathamesh Kulkarni
2016-06-08 14:15           ` Richard Biener
2016-06-08 15:09             ` Jan Hubicka
2016-06-09 20:18               ` Prathamesh Kulkarni
2016-06-09 20:23                 ` Jan Hubicka
2016-06-10  9:33                   ` Prathamesh Kulkarni
2016-06-10 11:17                     ` Richard Biener
2016-06-13  8:57                       ` Prathamesh Kulkarni
2016-06-13 10:43                         ` Jan Hubicka
2016-06-14 13:02                           ` Prathamesh Kulkarni
2016-06-17 14:22                             ` Prathamesh Kulkarni
2016-06-23 17:21                               ` Prathamesh Kulkarni
2016-06-28  9:27                                 ` Prathamesh Kulkarni
2016-07-05  9:53                                   ` Prathamesh Kulkarni
2016-07-20 11:49                                     ` Prathamesh Kulkarni
  -- strict thread matches above, loose matches on Subject: below --
2016-06-01 10:17 Prathamesh Kulkarni
2016-06-01 13:07 ` Richard Biener
2016-06-02  7:29   ` Prathamesh Kulkarni
2016-06-02  7:53     ` Richard Biener
2016-06-02  9:15       ` Prathamesh Kulkarni
2016-06-02  9:24         ` Prathamesh Kulkarni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160602150106.GA48112@kam.mff.cuni.cz \
    --to=hubicka@ucw.cz \
    --cc=dje.gcc@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=prathamesh.kulkarni@linaro.org \
    --cc=rguenther@suse.de \
    --cc=segher@kernel.crashing.org \
    --cc=wschmidt@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).