From: Jakub Jelinek <jakub@redhat.com>
To: Martin Sebor <msebor@gmail.com>
Cc: Gcc Patch List <gcc-patches@gcc.gnu.org>,
Jason Merrill <jason@redhat.com>,
"Joseph S. Myers" <joseph@codesourcery.com>
Subject: Re: [PATCH] integer overflow checking builtins in constant expressions
Date: Fri, 03 Jun 2016 07:06:00 -0000 [thread overview]
Message-ID: <20160603070637.GA7387@tucnak.redhat.com> (raw)
In-Reply-To: <5750CF25.1080801@gmail.com>
Hi!
On Thu, Jun 02, 2016 at 06:28:21PM -0600, Martin Sebor wrote:
First of all, can you please respond to the mail I've sent about
NULL argument issues (and proposal for __builtin_*_overflow_p)?
This patch as well as the nonnull attribute patch then depends on that
decision...
> + {
> + tree type = TREE_TYPE (TREE_TYPE (t));
> + tree vflow = arith_overflowed_p (opcode, type, arg0, arg1)
> + ? integer_one_node : integer_zero_node;
This looks incorrect, the return type is TREE_TYPE (t), some complex integer
type, therefore vflow needs to be
tree vflow = build_int_cst (TREE_TYPE (TREE_TYPE (t)),
arith_overflowed_p (opcode, type, arg0, arg1)
? 1 : 0);
no?
Jakub
next prev parent reply other threads:[~2016-06-03 7:06 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-01 16:40 Martin Sebor
2016-05-09 16:39 ` PING " Martin Sebor
2016-05-16 19:30 ` PING 2 " Martin Sebor
2016-05-17 18:54 ` Jason Merrill
2016-05-31 23:43 ` Martin Sebor
[not found] ` <20160531215025.GK28550@tucnak.redhat.com>
[not found] ` <574E13DD.9040401@gmail.com>
2016-06-01 7:52 ` Jakub Jelinek
2016-06-01 15:17 ` Martin Sebor
2016-06-01 15:45 ` Jakub Jelinek
2016-06-01 16:13 ` Martin Sebor
2016-06-02 3:11 ` Martin Sebor
2016-06-02 7:23 ` Jakub Jelinek
2016-06-02 7:34 ` Jakub Jelinek
2016-06-03 15:07 ` Martin Sebor
2016-06-03 15:23 ` Jakub Jelinek
2016-06-03 16:22 ` Martin Sebor
2016-06-02 23:21 ` Martin Sebor
2016-06-03 0:28 ` Martin Sebor
2016-06-03 7:06 ` Jakub Jelinek [this message]
2016-06-03 15:29 ` Martin Sebor
2016-06-03 15:32 ` Jakub Jelinek
2016-06-03 20:09 ` Martin Sebor
2016-06-06 12:36 ` Jakub Jelinek
2016-06-06 19:44 ` Jakub Jelinek
2016-06-07 9:12 ` Marek Polacek
2016-06-07 14:32 ` Jason Merrill
2016-06-07 15:51 ` Martin Sebor
2016-06-07 16:34 ` Jakub Jelinek
2016-06-07 19:35 ` Jason Merrill
2016-06-07 19:42 ` Jakub Jelinek
2016-06-07 20:30 ` Martin Sebor
2016-06-07 20:52 ` Jakub Jelinek
2016-06-07 21:56 ` Martin Sebor
2016-06-08 7:23 ` Jakub Jelinek
2016-06-08 18:38 ` Jason Merrill
2016-06-07 19:36 ` Jason Merrill
2016-06-01 18:46 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160603070637.GA7387@tucnak.redhat.com \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=joseph@codesourcery.com \
--cc=msebor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).