From: James Greenhalgh <james.greenhalgh@arm.com>
To: <gcc-patches@gcc.gnu.org>
Cc: <nd@arm.com>, <bin.cheng@arm.com>, <marcus.shawcroft@arm.com>,
<richard.earnshaw@arm.com>
Subject: Re: [AArch64 1/2] Refactor aarch64_operands_ok_for_ldpstp, aarch64_operands_adjust_ok_for_ldpstp
Date: Fri, 03 Jun 2016 08:45:00 -0000 [thread overview]
Message-ID: <20160603084508.GA29409@arm.com> (raw)
In-Reply-To: <1463476951-1567-2-git-send-email-james.greenhalgh@arm.com>
*ping* https://gcc.gnu.org/ml/gcc-patches/2016-05/msg01193.html
Thanks,
James
On Tue, May 17, 2016 at 10:22:30AM +0100, James Greenhalgh wrote:
>
> Hi,
>
> These two functions are very similar and suffer from code duplication.
> With a little bit of work we can reduce the strain on the reader by
> refactoring the functions.
>
> Essentially, we're going to remove the explicit references to reg_1,
> reg_2, reg_3, reg_4 and keep these things in arrays instead, at which
> point it becomes clear that these functions are very similar and can be
> pulled together.
>
> OK?
>
> Bootstrapped and tested for aarch64-none-linux-gnu with no issues.
>
> OK?
>
> Thanks,
> James
>
> ---
> 2016-05-17 James Greenhalgh <james.greenhalgh@arm.com>
>
> * config/aarch64/aarch64.c
> (aarch64_extract_ldpstp_operands): New.
> (aarch64_ldpstp_ops_same_reg_class_p): Likewise.
> (aarch64_ldpstp_load_regs_clobber_base_p): Likewise.
> (aarch64_ldpstp_offsets_consecutive_p): Likewise.
> (aarch64_operands_ok_for_ldpstp_1): Likewise.
> (aarch64_operands_ok_for_ldpstp): Refactor to
> aarch64_operands_ok_for_ldpstp_1.
> (aarch64_operands_adjust_ok_for_ldpstp): Likewise.
>
next prev parent reply other threads:[~2016-06-03 8:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 9:23 [Patch AArch64 0/2] Refactor ldp/stp code James Greenhalgh
2016-05-17 9:23 ` [AArch64 1/2] Refactor aarch64_operands_ok_for_ldpstp, aarch64_operands_adjust_ok_for_ldpstp James Greenhalgh
2016-06-03 8:45 ` James Greenhalgh [this message]
2016-06-03 8:59 ` Kyrill Tkachov
2016-05-17 9:23 ` [Patch AArch64 2/2] Some more cleanup of ldp/stp generation James Greenhalgh
2016-06-03 8:46 ` James Greenhalgh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160603084508.GA29409@arm.com \
--to=james.greenhalgh@arm.com \
--cc=bin.cheng@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=marcus.shawcroft@arm.com \
--cc=nd@arm.com \
--cc=richard.earnshaw@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).