From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16897 invoked by alias); 3 Jun 2016 08:45:50 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 16887 invoked by uid 89); 3 Jun 2016 08:45:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=30am X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (207.82.80.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 03 Jun 2016 08:45:38 +0000 Received: from emea01-am1-obe.outbound.protection.outlook.com (mail-am1lrp0020.outbound.protection.outlook.com [213.199.154.20]) (Using TLS) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-56-GOZoMSx3TJyofmZ2FyikpA-1; Fri, 03 Jun 2016 09:45:32 +0100 Received: from DB5PR08CA0070.eurprd08.prod.outlook.com (10.166.166.166) by AM2PR08MB0385.eurprd08.prod.outlook.com (10.161.235.23) with Microsoft SMTP Server (TLS) id 15.1.506.9; Fri, 3 Jun 2016 08:45:26 +0000 Received: from DB3FFO11OLC004.protection.gbl (2a01:111:f400:7e04::165) by DB5PR08CA0070.outlook.office365.com (2a01:111:e400:c576::38) with Microsoft SMTP Server (TLS) id 15.1.511.8 via Frontend Transport; Fri, 3 Jun 2016 08:45:25 +0000 Received: from nebula.arm.com (217.140.96.140) by DB3FFO11OLC004.mail.protection.outlook.com (10.47.217.132) with Microsoft SMTP Server (TLS) id 15.1.497.8 via Frontend Transport; Fri, 3 Jun 2016 08:45:25 +0000 Received: from arm.com (10.1.2.79) by mail.arm.com (10.1.105.66) with Microsoft SMTP Server id 14.3.294.0; Fri, 3 Jun 2016 09:45:08 +0100 Date: Fri, 03 Jun 2016 08:45:00 -0000 From: James Greenhalgh To: CC: , , , Subject: Re: [AArch64 1/2] Refactor aarch64_operands_ok_for_ldpstp, aarch64_operands_adjust_ok_for_ldpstp Message-ID: <20160603084508.GA29409@arm.com> References: <1463476951-1567-1-git-send-email-james.greenhalgh@arm.com> <1463476951-1567-2-git-send-email-james.greenhalgh@arm.com> MIME-Version: 1.0 In-Reply-To: <1463476951-1567-2-git-send-email-james.greenhalgh@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:217.140.96.140;IPV:CAL;SCL:-1;CTRY:GB;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(24454002)(377424004)(189002)(199003)(15975445007)(77096005)(106466001)(8936002)(2950100001)(19580405001)(19580395003)(83506001)(33656002)(97756001)(87936001)(46406003)(1076002)(4326007)(2906002)(47776003)(23726003)(36756003)(8676002)(4001350100001)(104016004)(6806005)(86362001)(5008740100001)(450100001)(110136002)(586003)(50466002)(5003600100002)(92566002)(54356999)(76176999)(50986999)(189998001)(2351001)(11100500001)(15760500001);DIR:OUT;SFP:1101;SCL:1;SRVR:AM2PR08MB0385;H:nebula.arm.com;FPR:;SPF:Pass;MLV:sfv;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;DB3FFO11OLC004;1:5sS3G11l2hw6wRe9yAXjGh1GZsYxYlnCi/oYkRcX/TkeDm4G6hu4VdDmgFB+/uonQz8O0nQwIO3N2Y1BMIeNzJoUj1yR5Vid5emDfbYlPYPmECMxV/QDtI/Z8D8+2WSplvMmoaU3Fg4svL0EkF2lsBz/TASePg2cUKS00P9yFccofvzyOo+ovifaLsc91x862Jn/7Gott47kT6fnuUBCg9O5r0jvDIqJmt7M6hhyRIbcH0uvqFdDOjDhUIsNXrcN5l0QgODK6aB4yFF+/sO2+Yo1tEYByF7bY7IJn5hZSPQGdKxfbpk48B9sPrsjGcLVz6B6pKu7tB5p3v8BEcbPDNRq/ZHVmD//Pe9Ah4fYM2BLHS+U3IOnlK1sphOtYMk8hvF9tuhEyyCF+U+aiTtS1lXdYnV6WnjyTXsGMddcqNsYhf0fknsmHCihxRv+UECscOesxZbdfgdLl+rL7flwYfuHGdjh3xFvQ+B9+O6w26lYkG1a1zL4+CUyHQF3qtTl X-MS-Office365-Filtering-Correlation-Id: a5c23b2d-b124-4eaf-f911-08d38b8b68c2 X-Microsoft-Exchange-Diagnostics: 1;AM2PR08MB0385;2:mBUNyPJhqvkmDCIr2+FAGBmy3MQj/FEJ/J7gV6o3QAKXB/Zj9cxPDfiGGlMQhoI1JNGUCjXj8kMsVQJfHK+KugbC+MHLAlDaGAj9HxcqhKazyORxLdZjWW+zmONT2uQ5lg5kUBXkGq2CkLcwa1m2ZfEBGDpEvZShKtJc1gn9dqqAKAj0mGh+kIEOsmbiqkeC;3:eyfGU8Ya+u58+xIPkTsikLUyV0aWMnTAqvPfZgbCqN5Hw4ZM4VEgOcpPZzcMfDKmStI7JddlS/NIQcIuPYEUvHFB2WQsbOV423GVt2BQX7x36CWb4K55vJU3tlzQ2d7Queiv2PB4g94ESuGb7jQ004yBRbjKGRgXhqemlRTu+Wv/iUnRlIuUIu3i+Nqssk7fzk/dyQx5wAM92G6W5Nej3pylwuKNEZ3M27UOx6m7gUKWcIhdKU94Ii99g0bMDruK/zEAWDH9zYqfWuIdD++QVg==;25:kvSvJrpbGmOpcFpVaFqUUNVDrrnqTYYhCrzTzFBq+CvKPDAOUbPhDf9aPn7gYPWlVcbUDk+avfBLzYLsFW0gQcZJAFw6QoWmdE3Kq2fDidyOpDISfEM+kpEFYy3TJ3OwO4Fr1Fxw5YOI0LrcMQCQAqufsnJYdUWOPSLT03UpP/ZtsetByHkPGKPVkegB4DblobN5yjM0M+RS827A2zCcHbiu2Ai8ymK2/FlygokyHesGwpxhKnRe+OVCHW4SIfJJH2HTpFymFiZR8MGYxp1jOHHK0AyGKoyE7K5MBOSnE/WFDRv5Pa7JAf92E4gyUWjURz8wQwzhk5BwjIF5HqKeTdEHUbMaliq9wXsXYAvreVqW5UsQaFOgEV4n7XIsgY6S+DFbaNE3V2LVXvY/9PP+4Hu6eVu+Y9kdRkJuZVXhJi4= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:AM2PR08MB0385; NoDisclaimer: True X-Microsoft-Exchange-Diagnostics: 1;AM2PR08MB0385;20:0WD2n7lv6D3gM4n4MO66ZfgYziLgnRXFSge3FXkOYw5N6UWzuS/0XqMNgnwyL2MhRHdtX1KMUzesSv8UATVBAQ2VazWkdGrctrW94kiKNbTpHHNIBHbEo6USp341A6EE1BuLWHeLl7Z6QAXVl03GgNVQcs24zxjFIU4oVrkajpIEjisjFkmUi6goXkio7tws86jFfd240DvplKDIIr5jBBuWrN4CKmfCmJTBd0nZNz0HxAPhlkYRPAAzjdhaGZdQ;4:y/BgQFD+7JE22Z0PteE9rl9yKFJ+tzn6Swryuzu0IziF6rKXAHh/tzCNtPU1FBgqfRAdHDiF8yjdFhM+CWYQ59GrLl/Y7iFC95LEkJhhk07s0C9PJtXZh4Dbd6SGC99YCItRGUZIQUnyBHq+JZYzUsuY6uXbXUuuhIhsiyjUkC53qS459PSb9BpwwuXBRhZNtAJP7d3vx0eE6MW6TlbX3Kg/xtpFuFldmeMVmURdSvtpcgdKAsW1nMd+QtJz/ACTo9ldPbF9pCePWnSNYRHgNbkPeAn01YffKLE+ufoQ/vfuEN0o0bzZnGNiFtXRSN14r6qrGDwPm70kjvxUO+ctZ6wGYPtPkFKvc48OTCduWN2eYneQY9I8I+DekmuLxhhDKQj4xQDOLG7JG6G/cJQk25UaIcDYq5rwmBHflNTuOhnuOcW4tN2GttmsO5pINWKz7Wf4am9HaU5sRXuX6Qy/HenNT5bTh30yRy2VyO5HK+jLwScP49Nju+L6HZA6EthrGnIxua89mUCyMzCOgBwHZvXP5L1T0vMmztFEWoH79RGoGKrspVGdvNxBO1KG6KQ7 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917)(22074186197030)(183786458502308); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13024025)(8121501046)(13023025)(5005006)(13013025)(13020025)(10201501046)(3002001)(6055026);SRVR:AM2PR08MB0385;BCL:0;PCL:0;RULEID:;SRVR:AM2PR08MB0385; X-Forefront-PRVS: 0962D394D2 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;AM2PR08MB0385;23:XwCbPpekvKrXJg/On+yiItXf3YboJomSFLmDMkVrF?= =?us-ascii?Q?Bh0dU2kMz9W1LMUxgm90erNBoSov4j7w3rzv1oVtisi5s+jNlEVwfaFZYHmG?= =?us-ascii?Q?KZUUweUcA93WIAJ+TL4ShYyXlhoWvz1NcfaTcxE+UO+cJk6z4QVsjjyUxLAN?= =?us-ascii?Q?DzgE8WapFh+zlkbBhrk5aZIYH24vh73VVGXDXqA7nCYEBieVSvq5cADYqms8?= =?us-ascii?Q?vuu83mppJCAWHmv9tPN4my93CcwFYaQt/me6f7u58bnF5EZ3FvmcsKz/vrZO?= =?us-ascii?Q?O+lwv+MMmpsTwd/GMq014urlbouCv1MuYihPXQtD0V7MABjc8a3JLYS0omWE?= =?us-ascii?Q?ueyrp9HNPFAAfX9JpC9av2JQqLCzpHCO/LHIOguMTLY14ohGUkKL+FM6lyvV?= =?us-ascii?Q?yoiLQMpm3lmoPcmBeHA4RY3WtfjZGCO66iAJ/TCly3smuPD2Ow59goWB7Rry?= =?us-ascii?Q?ErYzqJHpPUMbg/eFE8lzYcgJg4xWgScnlzjGz7eM0gftPLnY0zXaQvx/Kt0E?= =?us-ascii?Q?1Zm0dEmAL2IJJW6WqVmM6r3GL5GyLtMjkaYkifoSDp5Ozh/GOcE2qXd3Z4mo?= =?us-ascii?Q?D3Y7oyh+3wmQduISDhO6NKIsgu3AgUQeB+IDRFD2n9gKjcQDFW8c4aH8tRae?= =?us-ascii?Q?0aJWYYoRnPdR5E55aiqnZJ3QZoF+XZmwOrjUeymA//emuKXib+hb6XBdVSRt?= =?us-ascii?Q?sG0Osq4QWA9OPwFXRfI0MhSNDF299b6q9+7DqXTWsqbjInfO/iPzj62FBapQ?= =?us-ascii?Q?cgAD41qxcs6t81FodwwoXN5Bsk1wIgZpNAnCUH3iBJ62cCeR7P7li1rLbxU3?= =?us-ascii?Q?Xpu7CNrViZGeBcRMZ8IqQAxbeJjmsqF6gQiyK9KtR5taVbgFYlr1yaETgDZU?= =?us-ascii?Q?9NBw0XITJ5gHOrytvn7I2mRfL7K/EalQildhm4JZ+YFhanpCuJsc+x/OIjIK?= =?us-ascii?Q?0pj0P8S0zm+tDRBzcSUN/PLzq+tUemKSjoS1GxevxIYTbwenJ206Zkirg7Ad?= =?us-ascii?Q?NRdGtPyhf8DDztNkuhBCSyUMg2XNegmnoCOv2/FNe8xQT7+oWNIimsUw1H4L?= =?us-ascii?Q?2py+zM4LMhsz+pxqsXxeITi5lvng//bFGkFVzNiPgHLLVRD2fhWTDf/IbARQ?= =?us-ascii?Q?+1vFjllaASMQYK0RASJ30HPbzVPyfJp?= X-Microsoft-Exchange-Diagnostics: 1;AM2PR08MB0385;5:kQp1xrxBdS6TrJ4stsEMTqD6+utKz49S6MVOSoXLwjV8pXplz23N7HLXj6xKNaZOQhnz4Gx73DfDWtmdHPmPjrYHXeTmNcdR2RtiagVbdFjEtdcIX3ATjBbkQ3g2EYaxiedKxLBoaolD/Hrno4qqWQ==;24:dhmj7HrhcnlKFljeY622ted7rmFhzsP+DpZjJ2ITDTv7NPjoqGFYL9D5UAusBrGxZB/6gsrg6hzoCAYSapw/tZvWw+A2ehfQtXq7vxyPgrw=;7:35RSj+S9LMaf8lMNPMZDHJ7VviTC3iMNEdoJWEGtx1GF2xNrAq7KBcZ4eb14Q3gV3+nt+jelhDWWSQ3Q9R/Si2H9St8AmGM310ELbYCrYwBNoIakW+EhdKIPQ/Pew1E18HrVojDa+XOJQgicI0EonR66SeE0XvCyY+c22ZI+3DeZvXCOxBYXuG3dDLyah0uAmCLgn4h+cmw4FpGod7/gL3HsNu9ps6dEBBsE/wj17x0=;20:VAsLW952lO5Uu8+TWuClqNYM4GDb8Q+tKz+KtFev0tml3hOykHvhYSkdcjtHGY6hF9eWvsJ9TCd+ylLYTwAgueAFLH3cMJEx+hidHrXsUR5JWKuJwLvpl6oO1FuyhTiwxZLLuZPTyn02bpyl9j+RX6g8DFI168tftBVJ99GDjzI= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2016 08:45:25.9795 (UTC) X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[217.140.96.140];Helo=[nebula.arm.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR08MB0385 X-MC-Unique: GOZoMSx3TJyofmZ2FyikpA-1 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-IsSubscribed: yes X-SW-Source: 2016-06/txt/msg00255.txt.bz2 *ping* https://gcc.gnu.org/ml/gcc-patches/2016-05/msg01193.html Thanks, James On Tue, May 17, 2016 at 10:22:30AM +0100, James Greenhalgh wrote: >=20 > Hi, >=20 > These two functions are very similar and suffer from code duplication. > With a little bit of work we can reduce the strain on the reader by > refactoring the functions. >=20 > Essentially, we're going to remove the explicit references to reg_1, > reg_2, reg_3, reg_4 and keep these things in arrays instead, at which > point it becomes clear that these functions are very similar and can be > pulled together. >=20 > OK? >=20 > Bootstrapped and tested for aarch64-none-linux-gnu with no issues. >=20 > OK? >=20 > Thanks, > James >=20 > --- > 2016-05-17 James Greenhalgh >=20 > * config/aarch64/aarch64.c > (aarch64_extract_ldpstp_operands): New. > (aarch64_ldpstp_ops_same_reg_class_p): Likewise. > (aarch64_ldpstp_load_regs_clobber_base_p): Likewise. > (aarch64_ldpstp_offsets_consecutive_p): Likewise. > (aarch64_operands_ok_for_ldpstp_1): Likewise. > (aarch64_operands_ok_for_ldpstp): Refactor to > aarch64_operands_ok_for_ldpstp_1. > (aarch64_operands_adjust_ok_for_ldpstp): Likewise. >=20