From: Jonathan Wakely <jwakely@redhat.com>
To: Ville Voutilainen <ville.voutilainen@gmail.com>
Cc: libstdc++ <libstdc++@gcc.gnu.org>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [v3 PATCH] Support allocators in tuples of zero size.
Date: Mon, 06 Jun 2016 16:11:00 -0000 [thread overview]
Message-ID: <20160606161138.GI2629@redhat.com> (raw)
In-Reply-To: <CAFk2RUZJVkONk+o=ickt5PDb76ZJheP+W=PhDnMQg2fph7ZdyQ@mail.gmail.com>
On 05/06/16 21:15 +0300, Ville Voutilainen wrote:
> {
> public:
> void swap(tuple&) noexcept { /* no-op */ }
>+ // We need the default since we're going to define no-op
>+ // allocator constructors.
>+ tuple() = default;
>+ // No-op allocator constructors.
>+ template<typename _Alloc>
>+ tuple(allocator_arg_t __tag, const _Alloc& __a) { }
>+ template<typename _Alloc>
>+ tuple(allocator_arg_t __tag, const _Alloc& __a, const tuple& __in) { }
Please remove the names of the unused parameters, so we don't get
warnings with -Wsystem-headers -Wunused-parameter.
OK with that change, thanks.
prev parent reply other threads:[~2016-06-06 16:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-05 17:59 Ville Voutilainen
2016-06-05 18:16 ` Ville Voutilainen
2016-06-06 16:11 ` Jonathan Wakely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160606161138.GI2629@redhat.com \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=ville.voutilainen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).