From: James Greenhalgh <james.greenhalgh@arm.com>
To: Alan Lawrence <alan.lawrence@arm.com>
Cc: <gcc-patches@gcc.gnu.org>, <marcus.shawcroft@arm.com>,
<richard.earnshaw@arm.com>, <charlet@adacore.com>,
<ebotcazou@libertysurf.fr>, <nd@arm.com>
Subject: Re: [PATCH 2/2][AArch64] Tests of AAPCS64 updates for alignment attribute
Date: Tue, 07 Jun 2016 11:09:00 -0000 [thread overview]
Message-ID: <20160607110817.GB4240@arm.com> (raw)
In-Reply-To: <1452867463-30768-3-git-send-email-alan.lawrence@arm.com>
On Fri, Jan 15, 2016 at 02:17:43PM +0000, Alan Lawrence wrote:
> Here I've added both tests using the abitest.h framework(which verifies values
> are passed in the correct registers as specified by the AAPCS64), and separate
> tests which verify that called functions read arguments from the same locations
> as they are passed. Hence, each test_align-N.c corresponds to rec_align-N.c.
>
> I've tried to stay consistent with the existing naming of e.g. test_10.c,
> test_align-1.c, va_arg-10.c, but would be happy to change to another scheme
> if preferred! (e.g. func-ret-1.c ?)
>
> Cheers, Alan
These tests are OK.
I'll commit them alongside patch 1/2 from this series tomorrow.
Thanks,
James
>
> gcc/testsuite/ChangeLog:
>
> * gcc.target/aarch64/aapcs64/aapcs64.exp: Also execute rec_*.c
> * gcc.target//aarch64/aapcs64/rec_align-5.c: New.
> * gcc.target//aarch64/aapcs64/rec_align-6.c: New.
> * gcc.target//aarch64/aapcs64/rec_align-7.c: New.
> * gcc.target//aarch64/aapcs64/rec_align-8.c: New.
> * gcc.target//aarch64/aapcs64/rec_align-9.c: New.
> * gcc.target//aarch64/aapcs64/test_align-5.c: New.
> * gcc.target//aarch64/aapcs64/test_align-6.c: New.
> * gcc.target//aarch64/aapcs64/test_align-7.c: New.
> * gcc.target//aarch64/aapcs64/test_align-8.c: New.
> * gcc.target//aarch64/aapcs64/test_align-9.c: New.
> * gcc.target//aarch64/aapcs64/rec_vaarg-1.c: New.
> * gcc.target//aarch64/aapcs64/rec_vaarg-2.c: New.
next prev parent reply other threads:[~2016-06-07 11:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 14:17 [PATCH 0/2][AArch64] Implement " Alan Lawrence
2016-01-15 14:18 ` [PATCH 1/2][AArch64] " Alan Lawrence
2016-01-15 14:18 ` [PATCH 2/2][AArch64] Tests of " Alan Lawrence
2016-06-07 11:09 ` James Greenhalgh [this message]
2016-01-18 17:11 ` [PATCH 0/2][AArch64] Implement " Eric Botcazou
2016-01-21 17:23 ` Alan Lawrence
2016-01-22 17:16 ` [PATCH 1/2][AArch64] " Alan Lawrence
2016-01-22 18:49 ` Eric Botcazou
2016-02-22 15:07 ` Alan Lawrence
2016-02-26 14:52 ` James Greenhalgh
2016-03-04 17:24 ` Alan Lawrence
2016-03-11 10:18 ` Alan Lawrence
2016-06-07 11:07 ` James Greenhalgh
2016-06-08 17:04 ` James Greenhalgh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160607110817.GB4240@arm.com \
--to=james.greenhalgh@arm.com \
--cc=alan.lawrence@arm.com \
--cc=charlet@adacore.com \
--cc=ebotcazou@libertysurf.fr \
--cc=gcc-patches@gcc.gnu.org \
--cc=marcus.shawcroft@arm.com \
--cc=nd@arm.com \
--cc=richard.earnshaw@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).