From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85700 invoked by alias); 13 Jun 2016 10:21:44 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 85677 invoked by uid 89); 13 Jun 2016 10:21:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: =?ISO-8859-1?Q?No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=fran=e7ois, Fran=e7ois, HContent-Transfer-Encoding:8bit?= X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 13 Jun 2016 10:21:42 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 05F8A3F731; Mon, 13 Jun 2016 10:21:41 +0000 (UTC) Received: from localhost (ovpn-116-103.ams2.redhat.com [10.36.116.103]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u5DALe73029778; Mon, 13 Jun 2016 06:21:40 -0400 Date: Mon, 13 Jun 2016 10:21:00 -0000 From: Jonathan Wakely To: =?iso-8859-1?Q?Fran=E7ois?= Dumont Cc: "libstdc++@gcc.gnu.org" , gcc-patches Subject: Re: Container debug light mode Message-ID: <20160613102139.GB11538@redhat.com> References: <575885E2.1050000@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <575885E2.1050000@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.6.1 (2016-04-27) X-SW-Source: 2016-06/txt/msg00937.txt.bz2 On 08/06/16 22:53 +0200, François Dumont wrote: >Hi > > Here is the patch I already proposed to introduce the debug light >mode for vector and deque containers. > > It also simplify some internal calls. This looks great, and I'd like to see it on trunk, but could you split it into two patches please? The simplifications to use __iterator_category and replace insert() with _M_insert_* are good but are unrelated to the debug mode parts so if there are two separate commits it's easier to backport one piece separately, or to identify any regressions that might be introduced.