public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Pat Haugen <pthaugen@linux.vnet.ibm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
	David Edelsohn <dje.gcc@gmail.com>
Subject: Re: [PATCH, rs6000] Scheduling update
Date: Mon, 27 Jun 2016 22:43:00 -0000	[thread overview]
Message-ID: <20160627222118.GE27655@gate.crashing.org> (raw)
In-Reply-To: <57719E98.5040806@linux.vnet.ibm.com>

On Mon, Jun 27, 2016 at 04:46:00PM -0500, Pat Haugen wrote:
> On 06/22/2016 02:10 PM, Segher Boessenkool wrote:
> >> Index: config/rs6000/htm.md
> >> ===================================================================
> >> --- config/rs6000/htm.md	(revision 237621)
> >> +++ config/rs6000/htm.md	(working copy)
> >> @@ -72,7 +72,8 @@ (define_insn "*tabort"
> >>     (set (match_operand:BLK 2) (unspec:BLK [(match_dup 2)] UNSPEC_HTM_FENCE))]
> >>    "TARGET_HTM"
> >>    "tabort. %0"
> >> -  [(set_attr "type" "htm")
> >> +  [(set_attr "type" "htmsimple")
> >> +   (set_attr "power9_alu2" "yes")
> >>     (set_attr "length" "4")])
> > 
> > What determines if an insn is htm or htmsimple?
> > 
> htm insns are cracked whereas htmsimple are not.

Sorry, I wasn't clear.  That is what is the difference on p9, sure.
But is there some pattern to this?  Some difference that does not depend
on a specific CPU implementation.

>         (rs6000_sched_init): Fix initialization of last_scheduled_insn.
>         Initialize divCnt/vec_load_pendulum.

You missed divCnt here :-)

> +(define_insn_reservation "power9-vecdiv" 32
> +  (and (eq_attr "type" "vecdiv")
> +       (eq_attr "size" "!128")
> +       (eq_attr "cpu" "power9"))
> +  "DU_super_power9,VSU_super_power9")

Does that work, the ! ?


This looks much better :-)

Okay for trunk; okay for 6 later.  Thanks,


Segher

      reply	other threads:[~2016-06-27 22:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-21 17:46 Pat Haugen
2016-06-22 19:11 ` Segher Boessenkool
2016-06-27 14:58   ` Pat Haugen
2016-06-27 20:45     ` Segher Boessenkool
2016-06-27 21:30       ` Pat Haugen
2016-06-27 21:44         ` Segher Boessenkool
2016-06-27 22:21   ` Pat Haugen
2016-06-27 22:43     ` Segher Boessenkool [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160627222118.GE27655@gate.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=dje.gcc@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=pthaugen@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).