From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 70290 invoked by alias); 15 Jul 2016 12:05:25 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 69183 invoked by uid 89); 15 Jul 2016 12:05:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=3.7 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_PBL,RCVD_IN_RP_RNBL autolearn=no version=3.3.2 spammy=ciao, H*M:ibm, H*i:sk:5559f51, H*MI:sk:5559f51 X-HELO: oc5510024614.ibm.com Received: from p57B18396.dip0.t-ipconnect.de (HELO oc5510024614.ibm.com) (87.177.131.150) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 15 Jul 2016 12:05:23 +0000 Received: by oc5510024614.ibm.com (Postfix, from userid 500) id D07B6B5CD; Fri, 15 Jul 2016 14:05:24 +0200 (CEST) Date: Fri, 15 Jul 2016 12:05:00 -0000 From: Dominik Vogt To: Bernd Schmidt Cc: Jeff Law , gcc-patches@gcc.gnu.org, Andreas Krebbel , Ulrich Weigand , Andreas Arnez Subject: Re: [PATCH v5] Allocate constant size dynamic stack space in the prologue Message-ID: <20160715120524.GA9923@linux.vnet.ibm.com> Reply-To: vogt@linux.vnet.ibm.com Mail-Followup-To: vogt@linux.vnet.ibm.com, Bernd Schmidt , Jeff Law , gcc-patches@gcc.gnu.org, Andreas Krebbel , Ulrich Weigand , Andreas Arnez References: <03ecb4c1-3d2f-0ff7-1110-7519a5106d5a@redhat.com> <20160623154814.GA23280@linux.vnet.ibm.com> <20160624123044.GA12401@linux.vnet.ibm.com> <20160704121955.GA9654@linux.vnet.ibm.com> <8f09eb18-0159-5fc7-8004-161466bfb349@redhat.com> <20160707115716.GA14409@linux.vnet.ibm.com> <20160711114412.GA6171@linux.vnet.ibm.com> <20160714091054.GA2862@linux.vnet.ibm.com> <5559f515-28bd-24e7-838c-cd2efd11bc50@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5559f515-28bd-24e7-838c-cd2efd11bc50@redhat.com> User-Agent: Mutt/1.5.20 (2009-12-10) X-SW-Source: 2016-07/txt/msg00929.txt.bz2 On Fri, Jul 15, 2016 at 01:51:51PM +0200, Bernd Schmidt wrote: > On 07/14/2016 11:10 AM, Dominik Vogt wrote: > > >- if (flag_stack_usage_info) > >- stack_usage_size += extra; > >+ /*!!!*/ > >+ if (flag_stack_usage_info && pstack_usage_size) > >+ *pstack_usage_size += extra; > > What does the comment mean? It means that I wanted to look at that code location for some reason and forgot to do so. Need to check why I've put it in there in the first place. > Other than that it looks ok, although I still feel uneasy about the > unexplained movement of code since v1 - next time you fix a bug in a > patch, please document what happened. Yep. Ciao Dominik ^_^ ^_^ -- Dominik Vogt IBM Germany