From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 65692 invoked by alias); 20 Jul 2016 14:25:38 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 65677 invoked by uid 89); 20 Jul 2016 14:25:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 20 Jul 2016 14:25:36 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4A8A4D4D8F for ; Wed, 20 Jul 2016 14:25:35 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-204-43.brq.redhat.com [10.40.204.43]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u6KEPXc7010589 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 20 Jul 2016 10:25:34 -0400 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id u6KEPWCM023951; Wed, 20 Jul 2016 16:25:32 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id u6KEPVJP023950; Wed, 20 Jul 2016 16:25:31 +0200 Date: Wed, 20 Jul 2016 14:25:00 -0000 From: Jakub Jelinek To: David Malcolm Cc: gcc-patches@gcc.gnu.org, Jeff Law , Jason Merrill Subject: Re: [PATCH v2] C++ FE: handle misspelled identifiers and typenames Message-ID: <20160720142531.GV7387@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <6502df71-c1ed-8922-e054-a75cc0770fbf@redhat.com> <1469026018-22172-1-git-send-email-dmalcolm@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1469026018-22172-1-git-send-email-dmalcolm@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-IsSubscribed: yes X-SW-Source: 2016-07/txt/msg01266.txt.bz2 On Wed, Jul 20, 2016 at 10:46:58AM -0400, David Malcolm wrote: > + /* Skip anticipated decls of builtin functions. */ > + if (TREE_CODE (t) == FUNCTION_DECL) > + if (DECL_BUILT_IN (t)) > + if (DECL_ANTICIPATED (t)) Just a style comment, wouldn't if (TREE_CODE (t) == FUNCTION_DECL && DECL_BUILT_IN (t) && DECL_ANTICIPATED (t)) continue; be better? Jakub