From: Andre Vehreschild <vehre@gmx.de>
To: GCC-Patches-ML <gcc-patches@gcc.gnu.org>,
GCC-Fortran-ML <fortran@gcc.gnu.org>
Subject: [Fortran, patch, pr71936, v1] [6/7 Regression] ICE in wide_int_to_tree, at tree.c:1487
Date: Sun, 07 Aug 2016 13:32:00 -0000 [thread overview]
Message-ID: <20160807153200.70c7e7c3@vepi2> (raw)
[-- Attachment #1: Type: text/plain, Size: 393 bytes --]
Hi all,
attached patch fixes the ICE by ensuring that when the SOURCE=/MOLD=
expression is an array-valued function call with no ref, the ref of
object to allocate is taken. The array properties nevertheless are
taken from the function's result.
Bootstraps and regtests ok on x86_64-linux-gnu/F23. Ok for trunk and
gcc-6?
Regards,
Andre
--
Andre Vehreschild * Email: vehre ad gmx dot de
[-- Attachment #2: pr71936_1.clog --]
[-- Type: text/plain, Size: 360 bytes --]
gcc/fortran/ChangeLog:
2016-08-07 Andre Vehreschild <vehre@gcc.gnu.org>
PR fortran/71936
* trans-array.c (gfc_array_allocate): When SOURCE= is a function
stick with the ref of the object to allocate.
gcc/testsuite/ChangeLog:
2016-08-07 Andre Vehreschild <vehre@gcc.gnu.org>
PR fortran/71936
* gfortran.dg/allocate_with_source_21.f03: New test.
[-- Attachment #3: pr71936_1.patch --]
[-- Type: text/x-patch, Size: 1939 bytes --]
diff --git a/gcc/fortran/trans-array.c b/gcc/fortran/trans-array.c
index 7572755..6d5a0ef 100644
--- a/gcc/fortran/trans-array.c
+++ b/gcc/fortran/trans-array.c
@@ -5431,12 +5431,19 @@ gfc_array_allocate (gfc_se * se, gfc_expr * expr, tree status, tree errmsg,
if (ref->u.ar.type == AR_FULL && expr3 != NULL)
{
+ gfc_ref *old_ref = ref;
/* F08:C633: Array shape from expr3. */
ref = expr3->ref;
/* Find the last reference in the chain. */
if (!retrieve_last_ref (&ref, &prev_ref))
- return false;
+ {
+ if (expr3->expr_type == EXPR_FUNCTION
+ && gfc_expr_attr (expr3).dimension)
+ ref = old_ref;
+ else
+ return false;
+ }
alloc_w_e3_arr_spec = true;
}
diff --git a/gcc/testsuite/gfortran.dg/allocate_with_source_21.f03 b/gcc/testsuite/gfortran.dg/allocate_with_source_21.f03
new file mode 100644
index 0000000..fbf3159
--- /dev/null
+++ b/gcc/testsuite/gfortran.dg/allocate_with_source_21.f03
@@ -0,0 +1,52 @@
+! { dg-do compile }
+
+! Check fix for pr71936.
+! Contributed by Gerhard Steinmetz
+
+program p
+ type t
+ end type
+
+ call test2()
+ call test4()
+ call test1()
+ call test3()
+contains
+ function f_p()
+ class(t), pointer :: f_p(:)
+ nullify(f_p)
+ end
+
+ function f_a()
+ class(t), allocatable :: f_a(:)
+ end
+
+ subroutine test1()
+ class(t), allocatable :: x(:)
+ allocate (x, mold=f_a())
+ deallocate (x)
+ allocate (x, source=f_a())
+ end subroutine
+
+ subroutine test2()
+ class(t), pointer :: x(:)
+ allocate (x, mold=f_p())
+ deallocate (x)
+ allocate (x, source=f_p())
+ end
+
+ subroutine test3()
+ class(t), pointer :: x(:)
+ allocate (x, mold=f_a())
+ deallocate (x)
+ allocate (x, source=f_a())
+ end
+
+ subroutine test4()
+ class(t), allocatable :: x(:)
+ allocate (x, mold=f_p())
+ deallocate (x)
+ allocate (x, source=f_p())
+ end subroutine
+end
+
next reply other threads:[~2016-08-07 13:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-07 13:32 Andre Vehreschild [this message]
2016-08-08 9:33 ` Paul Richard Thomas
2016-08-08 9:58 ` Andre Vehreschild
2016-08-09 9:09 ` Richard Biener
2016-08-11 8:13 ` Andre Vehreschild
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160807153200.70c7e7c3@vepi2 \
--to=vehre@gmx.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).