From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 46925 invoked by alias); 8 Aug 2016 08:29:06 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 46910 invoked by uid 89); 8 Aug 2016 08:29:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=jumped, D*ucw.cz, U*hubicka, coremarks X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (146.101.78.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 08 Aug 2016 08:28:55 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01lp0177.outbound.protection.outlook.com [213.199.154.177]) (Using TLS) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-75-97IpH8EIN9CNFbUkcQCL0g-1; Mon, 08 Aug 2016 09:28:48 +0100 Received: from DB5PR08CA0016.eurprd08.prod.outlook.com (10.163.102.154) by HE1PR08MB0713.eurprd08.prod.outlook.com (10.163.179.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.549.15; Mon, 8 Aug 2016 08:28:46 +0000 Received: from DB3FFO11FD023.protection.gbl (2a01:111:f400:7e04::125) by DB5PR08CA0016.outlook.office365.com (2a01:111:e400:52c3::26) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.549.15 via Frontend Transport; Mon, 8 Aug 2016 08:28:46 +0000 Received: from nebula.arm.com (217.140.96.140) by DB3FFO11FD023.mail.protection.outlook.com (10.47.217.54) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.557.8 via Frontend Transport; Mon, 8 Aug 2016 08:28:46 +0000 Received: from arm.com (10.1.2.79) by mail.arm.com (10.1.106.66) with Microsoft SMTP Server id 14.3.294.0; Mon, 8 Aug 2016 09:28:31 +0100 Date: Mon, 08 Aug 2016 08:29:00 -0000 From: James Greenhalgh To: Andrew Pinski CC: Jan Hubicka , Jeff Law , GCC Patches , Subject: Re: backward threading heuristics tweek Message-ID: <20160808082830.GA14494@arm.com> References: <20160606101953.GC12313@kam.mff.cuni.cz> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:217.140.96.140;IPV:CAL;SCL:-1;CTRY:GB;EFV:NLI;SFV:NSPM;SFS:(10009020)(979002)(6009001)(7916002)(2980300002)(438002)(189002)(24454002)(199003)(377454003)(189998001)(87936001)(106466001)(246002)(7846002)(19580395003)(19580405001)(50986999)(36756003)(104016004)(83506001)(26826002)(86362001)(54356999)(76176999)(356003)(50466002)(2950100001)(11100500001)(586003)(7696003)(2906002)(4326007)(47776003)(23726003)(97756001)(77096005)(33656002)(46406003)(3480700004)(92566002)(1411001)(110136002)(8936002)(4001350100001)(8676002)(1076002)(305945005)(18370500001)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR08MB0713;H:nebula.arm.com;FPR:;SPF:Pass;PTR:fw-tnat.cambridge.arm.com;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;DB3FFO11FD023;1:wDe5eMUk2lfOeh3tKc2DCfTlyavUCBQFiWGeO1238bv1hX898BdzQxnNSksob1qOh/Ctc5wfkVhojWnU28nU8/mR0bLYauzOxMC5gefCbcgzrh4GhuEnKTXsrKSL1x/VHkE7KyE46RQgUESik/qeO+b4B09eLvhBK+zjyy5CQcQd4Pf2BqxVk7ZzlaqTZA+3ZR9NaOD8rU5jARTHq9W7398lDgP+W5nE1c5Ur5jeQD07gQJobzrca2Izqz+bw1D6mp9aTxtig6EfaOvz+hmxpWcnGElDDQmYQ5vhzwcrBqxzvK3MjcHwuG/1w9vdWtcRQSSGqnFkTlshf17HWigOz9KejztdaotV3vP1ojzM5fM+gEh+oBY4aeMkXGSHhEHa9rDdC5c3fWS6jvFHcTdHxcOseEos8GKTS0pG/pOCXnqu94X5h89qYPuJKvTorual8HQb+FUsEePxgCjHVK2z1IpAhh98LejvJJBbY+8thix48k43co+pQxl6RNQcFZLYzl8sSNdKEuF2+yC4/k6ofUpC6HJ34xTRcWvHP9NlvAPoNrxMQfPPnV6qaDHj0Qi3d3QuTkvxVqPtSNEoKgVkp0SI44huKVnKprNZLycYMiI= X-MS-Office365-Filtering-Correlation-Id: bcb47a19-4707-4490-a662-08d3bf66044c X-Microsoft-Exchange-Diagnostics: 1;HE1PR08MB0713;2:SGCTo8ToOudd2GzCzwrvxSwcewvE/EYDToe/fF+fTNV6GZYhjIYEmN+OX5LtXtp3A6f2oAEXE0psLB6nqLV0ZtfsJI9ttXqYPDVsHvNfWAQnxGQ0uALmoGMr8GH/P+4wYmF+wbUi9Ff/op24YT1gLHWnoISL9/KbeUPKKhV+V4P0yc2XS7y5Lll4E/Uy/QyD;3:4M0flOmrd8JZ+i1wNXrGwVXqzIkZEXJn79GShLxuOzoCwHUcC97xk7qZ2I0LGwGwgMY3zRBPh+X2U+p/xFevuJWC3aQV8JbIWZ0qmttrTic+nZsEh+ERdVMwF+md0votMwAoQlchvm+j2Ox7xMr4eZiKi4HHVstvJ1DuU4QhnyoWWhrBNzOOf3qw0lDmSlpws/3Ym8BihDlI4RAirv7PQdKJFTFDomH6lVstsh6h7H1MkeHpr1R3NHMsfBju/eaPrt+30j/dvFp02kR7ExWdZw==;25:FZ3a1R1U45tMfA/EiDzOs0m97w8xzWnFP3g4RVIEJFPg70vuh5k7ex5tevSIwqg3rFAP+RvFFSdzRiSOomU59iSiCTfRS+c+N0IvowUWVREeIoWvwgIiqbHrHKLV2ui6oL4wcIMUSo1ODVNX49A6Fy+cgwmGpPjwmEJrLugsftLSpK2KBRvlV4+qGlbTTVsWMlZaw72dp3tc3oAR/rbnwZt9nuULqzPOCu24NsGkg6kEkZlJICmL90TgCKmXTFk53mxSzpxDK1rg8f3ZzKpM4439VaOFup3atJLZp3xEg5yEQ2Aarhc7XqZp70b4VPH8WmTLk8sLKkmaHozTpdkffXVRKEMp7xtVz9Rqa8IOQd3lRb6GjMS4vagfGnsZmwH6OKFEP1J4n0UQj5A8a5QXaIOygJHMl73fn/uE7k6RhbM= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:HE1PR08MB0713; X-Microsoft-Exchange-Diagnostics: 1;HE1PR08MB0713;31:0cLP3HlavUdTGxsOJw9/67UsmgjDW7LjrhzDayFCzuXp7u2XI5yRwkxapCFklbR48QrvG38AT+7dB+o+HH7u9k/roPrJ8YeHBSWP0vGD6dGQlVV6DEgf300zJRhHcLLtXrTAY3xnRn2xVfzcar1h0N3Snc0tS1YsiO1+RMxrrX7xmcYKnL39dQ8yoJXl6+URbFlky49If6kmhsVM26kbcmZzOoU/mcoho/3ZOlDm33E=;20:kJtRcoDTowvIqW1b2s4wgjJZixfabPVk9mIsSsZTocMVlVXp2qLf+kfiPyqfTKUIzOrFRHPrjzihBxUbEbgxg1OXsELimTHi+XFel+dvnQEEX8Ht0qJW7eG733oTC9e+wCQ9d/cqgLufNT6BW1jv1v7q6ihf3FGA8uXcO4JvizhwyfMNtjk//kUvuX3SXVTCxNnxaOZRwnCANOCPMXTYPPwfey1YIDQqjqW1lIUji5tZS9pnY13AbwT7fp0LDMdV NoDisclaimer: True X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(22074186197030)(183786458502308); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13020025)(13024025)(13023025)(13013025)(8121501046)(5005006)(10201501046)(3002001)(6055026);SRVR:HE1PR08MB0713;BCL:0;PCL:0;RULEID:;SRVR:HE1PR08MB0713; X-Microsoft-Exchange-Diagnostics: 1;HE1PR08MB0713;4:jYJ2ZT5UEMz1+4KSm31qhLmektXcdIkYGXebHg0FJXx2qyKpcIGTtPbbyxVn5rk4IyZZNugW9zyuXTC59yw0RVdc0HPez5MroyISTjlzuBbLLKNd6kMygXQw4Klmt8TF5px61I9gBGpp5+Bf9xIoPC6uInthvloo5jH46JUN2WAw48FFRybfz5KY8L4b8uo8D1D4//2zyPoi6C8+5ie/CGXBWOHn0RT3z4RToQ1eCqqv9HFuf/HFXYcccBPGzBoBTshxb+r4UqA7eKPQ1H5xrpwveba/v9OFXex9OCBArAPBNoi/9TVCQcFojoUdifn0KnLJ6mv2fuckyel3cDURZbAwIV2kLDV65D2VGbyxx29ohUHjNEgNt5m0ooxh0en7jp8nN4nZOCz8hqHowZUV/KB2FAYpN6rspj0zaW9LD+OGiEKQ48zs4urARSpxVSf9T4Iaj91v8XLTYGwdzVxO7kVjVpoE4X7Zypx7IKriaA+2fIt4g93aQqLcrwJgDwg3nKDmQGU/bHfo6rPZBgpL9kLyH5QZGiiMLN8j6tS8FC0= X-Forefront-PRVS: 00286C0CA6 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;HE1PR08MB0713;23:BORkaAKnmQA6nsOolv8YfZkYskbnPvg1DXjDOjiat?= =?us-ascii?Q?FeS9+K6xIGsYeYEmQO/6FN3tuvnrCEEiTcYWrLe1qah05wdBhSp7n/aRrvsj?= =?us-ascii?Q?VRZD6kgU3qUgg9by2+X23z13EREILvJjKbcIx0jc/gxkGEB7g0r3Ng5ks4bY?= =?us-ascii?Q?tazOQAWrxcOD/1G88nnRgKV4dvPvKsro6k5yj/cQxkxljgWpIw1eSEH4f1hs?= =?us-ascii?Q?jh/ho6ZJAVFo61F8/I/2nqpXFJN3d3vkD+BSbTGP8cAazEoey4KeE7mLHLCP?= =?us-ascii?Q?SZBa0rAQFR0azD/YaNEx7j9E92dHmaoWKkp3jucxIxPnj8gWHfoWvbdK12TR?= =?us-ascii?Q?v6h3P+2PAU0H2N3xHhrGqzFWT0isS+AJWWqODv1/fH6hfWDDfcJ54wHk7Vzg?= =?us-ascii?Q?JAbiwkMfZM6z4zFGafRUQPwc26rnJZPvQZ8ffcibDJc9LP6qYocztZaTT+Fl?= =?us-ascii?Q?2CqAdVCRU5+u/wMD9S6p4mtq52dwDHXUsn+FDqr1rrMTgsMClFQCD17ThCcw?= =?us-ascii?Q?LK0JXeyyd6euDfqae8dLDm/WAsDL71O3ScC8vNH9WQzcVf/LtGwgWj+I2V0V?= =?us-ascii?Q?wdpbiXJ8ZC7hf11sqAbziLmursVtmQq/h7BFPv4sVFnZotE29zB9003TsqmA?= =?us-ascii?Q?JQlugxO1gFsJJBg7beGf+6txajS8O+ebgttinqRkC5+LrKLEy/x6OG6e//9Q?= =?us-ascii?Q?LTGtEWFBg6HPISmyr9UALzFmvZyrt+Oi/Rx0xaz1oOQhPgpxIfZNoTE9H7FM?= =?us-ascii?Q?QmOUmp8RN19clB92bfpCRtvtwApZL5KVAUfj0v3P+qOJ+x9viXzkVYL9g+sF?= =?us-ascii?Q?8o7Smc5NDDvXMGnbZXjvLx/PUNiOGZQXCU4WSQSkOPbfY2QQ+a8iTJnfs3PJ?= =?us-ascii?Q?x7w5DSHywXw+siIQ+9CcU6b9JRCaJZqoVTXZBgnrPDfxDnBgKqBFBUjYnLRr?= =?us-ascii?Q?ZUOFO9C8vRjYu5FPXhkKNBVh3AsUKx/ueJnMqQ6gW9GQpxArH/3Jp1OU+6mM?= =?us-ascii?Q?32Lx3jRjK7oEm5ZptKslYHSYq15/9/oktd3cnfgLPmGT8xtX9+WFTPmjGc+M?= =?us-ascii?Q?7gfGFMxKmjDK6wFQnPaxeWjAiLVqzZmc8Q/ExmxVJ0wvjHDsK7WtsqiR0UV4?= =?us-ascii?Q?pl00sjr4KzvmrHSYZgHoZe6/TSmfcico869m84dHmDw0rimW0o65B/sJX4Iw?= =?us-ascii?Q?PG9cua/8sFXqy3WWgUBaRIcilKU6rlL7yC9jUABrLCfS0ZN1HLrPOQPijxNQ?= =?us-ascii?Q?4V+BxXFkMX6In/pbmYBHTfmVGp3xO9EjdDT6UWA?= X-Microsoft-Exchange-Diagnostics: 1;HE1PR08MB0713;6:tRzCa4wDAtz567Tbe+sjuysa/4NTNxs1R54ZFqIiTElfIZMhOqq+52l6IKr8DJq0w3kE30xPW9seiYOAkPGpTmy9FYCKeRruCKPGrUogbho7VffZKTx/Vf3pKg6pMD33tRgXZdctr1ArZ7bteO3A2cB5kXhdgQ6hWpBXevD4lJjTigq5LNUi4mR0ATKlw889Jh93knO2Y0DNS4b8uO/G+J5kj/odJj581Tj2sLdmkbI6NL/VsVx5kkUC3fwcij9Gq4eOQcMUktN6ngWND8Oi2ePf9vpAfvzlwtSTTqQeCb8GMzq5kvSCCP4E4OxQgn2079b56F7NbEb+WxPm0jjUUQ==;5:lprOJdhVBPdKQPgPn65O6OVFG0nwXt3zBpirtvwC3ikv4GhihDRUqW5IpX9+jGbAe02oFbb8vDmBFmllVmrE6MVudIjqXHkMUUwB43i6D2FFkquSebv1ruH74XtMc+8yMo6M/LVB4VYbmS+zGh+12w==;24:0rLnOr9+7tSQC/HrosPZ4QkKh1fNV+cy7YbBd/Jc1uEd9xMUQtP4rW/FeXZM1/7kBds78w5IiXWFzSRrjMshYpzysl50/vfqduWCmYQef8U=;7:OFKgnX1LGM2kAr3ClIaw6O7NVmI9+79l0f1igYTWA2nl20sIRz9vrVSnkHFV02t+YFfIIzYf4tMoxM8ErxTIGO1dqN/x3hSoihql/hWbMCyG6agt2YGJfCvZdVojI3t83Qo0TKxc2BA2rPJDXn7eSZVPntub0BYJSbvj84xLb3P3jJQaQHaeMiBxAcq0qsDezhEgK7tB1rNG1q81a4sflwaBR3FKvqABevs//r0VKPqoZCzCcNyjOxky0oSfw/mO SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;HE1PR08MB0713;20:7j028MeCC1mYu1ZESYmPWiWKm5tCMEGGqc9hfuhEsZLe82wIjuL86y6PFUhM33+BHDSP4bSbRs/Ep8t2YJw1Kx5cymuGYaiDzaEnrMcdpxCg4Y68sj3qhy025gorjJef+G74D3TXL7H0ko5OzTxHA9jVnWbbwbblHoMB80ThiEo= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2016 08:28:46.6421 (UTC) X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[217.140.96.140];Helo=[nebula.arm.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR08MB0713 X-MC-Unique: 97IpH8EIN9CNFbUkcQCL0g-1 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-IsSubscribed: yes X-SW-Source: 2016-08/txt/msg00573.txt.bz2 On Sun, Aug 07, 2016 at 10:30:48AM -0700, Andrew Pinski wrote: > On Mon, Jun 6, 2016 at 3:19 AM, Jan Hubicka wrote: > > Hi, > > while looking into profile mismatches introduced by the backward thread= ing pass > > I noticed that the heuristics seems quite simplistics. First it should= be > > profile sensitive and disallow duplication when optimizing cold paths. = Second > > it should use estimate_num_insns because gimple statement count is not = really > > very realistic estimate of final code size effect and third there seems= to be > > no reason to disable the pass for functions optimized for size. > > > > If we block duplication for more than 1 insns for size optimized paths = the pass > > is able to do majority of threading decisions that are for free and imp= rove codegen. > > The code size benefit was between 0.5% to 2.7% on testcases I tried (tr= amp3d, > > GCC modules, xlanancbmk and some other stuff around my hd). > > > > Bootstrapped/regtested x86_64-linux, seems sane? > > > > The pass should also avoid calling cleanup_cfg when no trheading was do= ne > > and i do not see why it is guarded by expensive_optimizations. What are= the > > main compile time complexity limitations? >=20 > This patch caused a huge regression (~11%) on coremarks on ThunderX. > I assume other targets too. > Basically it looks like the path is no longer thread jumped. This also caused: FAIL: gcc.dg/tree-ssa/pr69270-3.c scan-tree-dump-times uncprop1 ", 1" 4 Failures: gcc.dg/tree-ssa/pr69270-3.c =09 Bisected to:=20 Author: hubicka Date: Sun Aug 7 10:50:16 2016 +0000 * tree-ssa-threadbackward.c: Include tree-inline.h (profitable_jump_thread_path): Use estimate_num_insns to estimate size of copied block; for cold paths reduce duplication. (find_jump_threads_backwards): Remove redundant tests. (pass_thread_jumps::gate): Enable for -Os. * gcc.dg/tree-ssa/ssa-dom-thread-7.c: Update testcase. svn+ssh://gcc.gnu.org/svn/gcc/trunk@239219=20 On my aarch64-none-linux-gnu and x86_64-none-linux-gnu automatic bisect robots. Thanks, James