From: Segher Boessenkool <segher@kernel.crashing.org>
To: Alan Modra <amodra@gmail.com>
Cc: gcc-patches@gcc.gnu.org, Arseny Solokha <asolokha@gmx.com>
Subject: Re: [RS6000] e500 part of pr71680
Date: Tue, 09 Aug 2016 19:59:00 -0000 [thread overview]
Message-ID: <20160809195938.GB32126@gate.crashing.org> (raw)
In-Reply-To: <20160809090446.GB13182@bubble.grove.modra.org>
On Tue, Aug 09, 2016 at 06:34:46PM +0930, Alan Modra wrote:
> The fallback part of HARD_REGNO_CALLER_SAVE_MODE, choose_hard_reg_mode,
> returns DFmode for SImode when TARGET_E500_DOUBLE. This confuses
> lra when attempting to save ctr around a call.
>
> Arseny, the bug reporter, has regression tested this patch.
> OK to apply?
Okay for trunk, thanks,
Segher
> PR target/71680
> * config/rs6000/rs6000.h (HARD_REGNO_CALLER_SAVE_MODE): Return
> SImode for TARGET_E500_DOUBLE when given SImode.
>
> diff --git a/gcc/config/rs6000/rs6000.h b/gcc/config/rs6000/rs6000.h
> index af77258..353f388 100644
> --- a/gcc/config/rs6000/rs6000.h
> +++ b/gcc/config/rs6000/rs6000.h
> @@ -1273,6 +1273,8 @@ enum data_align { align_abi, align_opt, align_both };
> && ((MODE) == VOIDmode || ALTIVEC_OR_VSX_VECTOR_MODE (MODE)) \
> && FP_REGNO_P (REGNO) \
> ? V2DFmode \
> + : TARGET_E500_DOUBLE && (MODE) == SImode \
> + ? SImode \
> : TARGET_E500_DOUBLE && ((MODE) == VOIDmode || (MODE) == DFmode) \
> ? DFmode \
> : !TARGET_E500_DOUBLE && FLOAT128_IBM_P (MODE) && FP_REGNO_P (REGNO) \
prev parent reply other threads:[~2016-08-09 19:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-09 9:04 Alan Modra
2016-08-09 19:59 ` Segher Boessenkool [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160809195938.GB32126@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=amodra@gmail.com \
--cc=asolokha@gmx.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).