From: Jakub Jelinek <jakub@redhat.com>
To: kugan <kugan.vivekanandarajah@linaro.org>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Richard Biener <richard.guenther@gmail.com>
Subject: Re: [PR72835] Incorrect arithmetic optimization involving bitfield arguments
Date: Tue, 09 Aug 2016 21:46:00 -0000 [thread overview]
Message-ID: <20160809214617.GB14857@tucnak.redhat.com> (raw)
In-Reply-To: <98613cff-7c48-1a56-0014-6d87c35a8f26@linaro.org>
On Wed, Aug 10, 2016 at 07:42:25AM +1000, kugan wrote:
> There was no new regression while testing. I also moved the testcase from
> gcc.dg/torture/pr72835.c to gcc.dg/tree-ssa/pr72835.c. Is this OK for trunk?
This looks strange. The tree-ssa-reassoc.c code has been trying to never
reuse SSA_NAMEs if they would hold a different value.
So there should be no resetting of flow sensitive info needed.
> gcc/testsuite/ChangeLog:
>
> 2016-08-10 Kugan Vivekanandarajah <kuganv@linaro.org>
>
> PR tree-optimization/72835
> * gcc.dg/tree-ssa/pr72835.c: New test.
>
> gcc/ChangeLog:
>
> 2016-08-10 Kugan Vivekanandarajah <kuganv@linaro.org>
>
> PR tree-optimization/72835
> * tree-ssa-reassoc.c (rewrite_expr_tree): Reset value_range of LHS when
> operands are changed.
> (rewrite_expr_tree_parallel): Likewise.
Jakub
next prev parent reply other threads:[~2016-08-09 21:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-09 13:43 kugan
2016-08-09 21:43 ` kugan
2016-08-09 21:46 ` Jakub Jelinek [this message]
2016-08-09 21:51 ` kugan
2016-08-09 21:55 ` Jakub Jelinek
2016-08-09 22:51 ` kugan
2016-08-10 1:46 ` kugan
2016-08-10 8:57 ` Jakub Jelinek
2016-08-10 9:14 ` kugan
2016-08-10 10:28 ` Richard Biener
2016-08-10 23:09 ` kugan
2016-08-19 8:19 ` Kugan Vivekanandarajah
2016-08-25 12:24 ` Richard Biener
2016-09-02 8:09 ` Kugan Vivekanandarajah
2016-09-14 11:38 ` Richard Biener
2016-09-18 21:58 ` kugan
2016-09-19 13:49 ` Richard Biener
2016-09-20 3:27 ` kugan
2016-09-20 12:01 ` Richard Biener
2016-08-09 21:50 ` Andrew Pinski
2016-08-09 21:53 ` kugan
2016-09-14 14:31 ` Georg-Johann Lay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160809214617.GB14857@tucnak.redhat.com \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kugan.vivekanandarajah@linaro.org \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).