public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Marek Polacek <polacek@redhat.com>
To: Richard Biener <rguenther@suse.de>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>, Jason Merrill <jason@redhat.com>
Subject: Re: RFC: A few more fallthrus
Date: Fri, 12 Aug 2016 10:14:00 -0000	[thread overview]
Message-ID: <20160812101411.GX7007@redhat.com> (raw)
In-Reply-To: <alpine.LSU.2.11.1608120919110.26629@t29.fhfr.qr>

On Fri, Aug 12, 2016 at 09:20:36AM +0200, Richard Biener wrote:
> > --- gcc/gcc/tree-complex.c
> > +++ gcc/gcc/tree-complex.c
> > @@ -1336,6 +1336,8 @@ expand_complex_division (gimple_stmt_iterator *gsi, tree inner_type,
> >        rr = gimplify_build2 (gsi, code, inner_type, ai, bi);
> >        ri = gimplify_build2 (gsi, code, inner_type, ar, bi);
> >        ri = gimplify_build1 (gsi, NEGATE_EXPR, inner_type, ri);
> > +      /* XXX Really fallthru?  */
> > +      /* FALLTHRU */
> >  
> 
> 
> Nope, looks like a bug to me.

Thanks, thus:

Bootstrapped/regtested on x86_64-linux, applying to trunk.

2016-08-12  Marek Polacek  <polacek@redhat.com>

	PR c/7652
	* tree-complex.c (expand_complex_division): Add missing break.

diff --git gcc/tree-complex.c gcc/tree-complex.c
index d7baf22..7668520 100644
--- gcc/tree-complex.c
+++ gcc/tree-complex.c
@@ -1336,6 +1336,7 @@ expand_complex_division (gimple_stmt_iterator *gsi, tree inner_type,
       rr = gimplify_build2 (gsi, code, inner_type, ai, bi);
       ri = gimplify_build2 (gsi, code, inner_type, ar, bi);
       ri = gimplify_build1 (gsi, NEGATE_EXPR, inner_type, ri);
+      break;
 
     case PAIR (ONLY_REAL, VARYING):
     case PAIR (ONLY_IMAG, VARYING):

	Marek

  reply	other threads:[~2016-08-12 10:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-11 14:49 Marek Polacek
2016-08-12  7:20 ` Richard Biener
2016-08-12 10:14   ` Marek Polacek [this message]
2016-08-16 16:59 ` Marek Polacek
2016-08-18  3:13   ` Jeff Law
2016-10-05 19:47     ` Jason Merrill

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160812101411.GX7007@redhat.com \
    --to=polacek@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jason@redhat.com \
    --cc=rguenther@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).